From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752090AbdBMJdF (ORCPT <rfc822;w@1wt.eu>);
        Mon, 13 Feb 2017 04:33:05 -0500
Received: from mout.web.de ([212.227.15.3]:51619 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751007AbdBMJdD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 13 Feb 2017 04:33:03 -0500
Subject: Re: [PATCH 3/5] IB/hfi1: Adjust another size determination in
 hfi1_user_sdma_alloc_queues()
To: Johannes Thumshirn <jthumshirn@suse.de>, linux-rdma@vger.kernel.org
References: <8a997282-09c7-0f9f-645e-d7c6e8c79e67@users.sourceforge.net>
 <0fdf4d81-58d7-c6fc-b37f-41d47675dd83@users.sourceforge.net>
 <fc714096-8534-2231-17fd-8e3ca3f7a87b@suse.de>
Cc: Dennis Dalessandro <dennis.dalessandro@intel.com>,
        Doug Ledford <dledford@redhat.com>,
        Hal Rosenstock <hal.rosenstock@gmail.com>,
        Mike Marciniszyn <mike.marciniszyn@intel.com>,
        Sean Hefty <sean.hefty@intel.com>, LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <4dca91c1-488d-120d-bd25-74f400242bd2@users.sourceforge.net>
Date: Mon, 13 Feb 2017 10:32:13 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <fc714096-8534-2231-17fd-8e3ca3f7a87b@suse.de>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:gSNj5+UsgH60jTWi5NZJpQsWhnTxxpITyUip3MdOKNXzZdum1iR
 +7XHMfDa7M+VsXh2a+jQ/+t+OxZb8BIs9HJmhsgm/bzCfmmdXb2RlNXBC/O7QN4XviZU1jx
 /wMVEbvXNMhJ982HWzt4dztx8f685YUwMnEgcize7yScGqumNXDt2RbLqEB6lAyQiG7T1W1
 sdzmNHwHM1ZsPgx6NThew==
X-UI-Out-Filterresults: notjunk:1;V01:K0:lblpePpO0uU=:y+SLbgZ/UAhG/t3Dv+h1RN
 nbG6QMa/dZcaR7/Q+wrSJtJZJWLcC3pcHuAeIIEaQAAMNOXsp/is0NoBwHQmUIjn53l3FxAyM
 lGqtAnY2/eJPaslwD3/zsSp5ValXTnRUiF7tvXtsKJ/AiPAAFBXJHYQh8h5ePaKqsD8GoOlYn
 wcPLSHZUexhM9uJe41Psl6bgXPjWzlZk8fMYlShisThu0znr6wRjMdCFSo3nZREihv6ribQu6
 IeF8BJNoMuROuWN26CB35pX4F11JAK76MPNmk3FdLwYASU7SbFIE6MTFqiC46Lb5iRONtgJn4
 7+X3A6/orbgwYj5Vy62gRTRBjiolFj22uiG/IDJ1DxkivhYILhM+FNhSWuXRi+blvcMn8j9ZI
 OdZEmwjvhQnX81iA5iazdV7QtLZGFaLwL1rdp0wjkb4oUtARd1g2MHUB8+ECaERbLNKgdTF3K
 cgnk857AV9cYbz5NlZgwo87L1af7IiQJXDJ91MEDMHF0fvr6ycvT3VJmq7ogZbg++k01d2FZk
 2NLReKBI/NUBZpvoVmAZGqbADkBBfzOVavWuuI6oCTvZSh7YnAAnC71jIgqLGOVZwQfbhClik
 3vPfRVQSNju323f4x+Icy6l9tsCR5BUSeBNy8/GwFIjQsyAkgy0w4UQ7uLfQnBt+WJpT0uEow
 +cbqVbpcs9sVjacSSxFGZjyV73cXb76mt2d9t8X0IYpiVFDhVXMPUhok+m3cavJb8Ch37od/7
 RkoTVYBOqvwvt0+oKB5yKnbGHRCt1C94oiONSVSe6dk/3uq8DovhOVX5xmCRMfAdyBdGz7JJR
 6KrsQYd
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> @@ -443,8 +442,8 @@ int hfi1_user_sdma_alloc_queues(struct hfi1_ctxtdata *uctxt, struct file *fp)
>>  	if (!cq)
>>  		goto cq_nomem;
>>  
>> -	memsize = PAGE_ALIGN(sizeof(*cq->comps) * hfi1_sdma_comp_ring_size);
>> -	cq->comps = vmalloc_user(memsize);
>> +	cq->comps = vmalloc_user(PAGE_ALIGN(sizeof(*cq->comps)
>> +				 * hfi1_sdma_comp_ring_size));
>>  	if (!cq->comps)
>>  		goto cq_comps_nomem;
>>  
>>
> 
> IMHO this makes readability worse.

How often does it really make sense to keep such a product in this local variable?


> What's the intention behind this patch?

I suggested just another simple omission of an extra variable.

Regards,
Markus