From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8935B36196C for ; Wed, 5 Aug 2026 16:21:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785946898; cv=none; b=owCaMN4Wxu1WFCmhPfOW38U+oEVkfVtkqXMPBRrLaQzi9wM5XyXx0pgCB0lckFoAEjfZpEP9WqxHA+r38xcUSnmQgiS6grB/5PQy1OQCUsdvFksUmqTldR7ACd+3Zp0TYlOU/gm2MnkCv5Gjh2TyvFQT6n5FlJi2pTapLZUACQY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785946898; c=relaxed/simple; bh=7AzRge3MAx/ljNGPFxwmXz6jrJwbMYw0OdT9ysR7NAU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WcNeztBZjyAE5YBEhLen19vnJUKCfQhKLK3Eh/JR5fjU3k3uA3aAAYfM2a8xhL49h1Hw4GivgREXWT3c9qSZ/KuV9pIJ1imcI7zRYlNA40Jhr87UMnPWoB3r/AALxMlvp+lMIHpO+T2Ka1YiTL7YL1PsKbK/7JZnxwSNZ5NP7fs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hfIc9tnE; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=LE4RiWKF; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hfIc9tnE"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="LE4RiWKF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785946895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tizkSZxM4VvXKVuN9JfoqQPAahmETDYIePK/2g8gg9U=; b=hfIc9tnE51FNL6WChRV+CofyU3u6Ho2y0ZqVoYDu6pU9dIdnQOEMzv30hGTvKy5ISgbAqJ gWgP2kE9TQhiakorV4rboX4Shb83IMGdyb8Pt8lLlxkqx5cX/8ZKROLj9ZDgYnsFV5L3RI 4t8jeQKzii5Qt1B4dnYLUby2G6MHcW8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-35-MADNe82JPLmjWUXe9WGWCA-1; Wed, 05 Aug 2026 12:21:34 -0400 X-MC-Unique: MADNe82JPLmjWUXe9WGWCA-1 X-Mimecast-MFC-AGG-ID: MADNe82JPLmjWUXe9WGWCA_1785946893 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-47fe23b5acdso1062117f8f.0 for ; Wed, 05 Aug 2026 09:21:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785946893; x=1786551693; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to:content-type; bh=tizkSZxM4VvXKVuN9JfoqQPAahmETDYIePK/2g8gg9U=; b=LE4RiWKFrax73NOg8TKqoqyEQLFb7i/9YH5UvdusIGCoGNvOBpNJSuOXQmOHa3VeJs lRZF6DvM82cH88nLq4z64EbeFW1gcTjwBd6tWiE5oYAAOh6zBMetYgvQJp7SbKYsu5np /JcPSs9FN5Jv6lk93dupILu/DdzjUAm+j9dfMhDU50x4pCjSTACHtTPKusz5kzFc4txl jD9yKVh3+ZjGoiZvQKFQEJtpVPqPlgGgO2NoXoLP5A1418T/Zne5qOcqNxbh2NW/7klF ifbSl9GZ/mEslilC3iSrFCXxxJ/Fxj/sv6Xeyaj0ROsqGkoTYIRDX4rpFyImPErEjfan je+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785946893; x=1786551693; h=content-transfer-encoding:content-type:in-reply-to:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=tizkSZxM4VvXKVuN9JfoqQPAahmETDYIePK/2g8gg9U=; b=YD1WmKJIP9MI0H6jmaddMXViKZKxgH96vYaWZUc3qUGR/UO1FyMOUu9q0NlaT1lwM3 tY1VMPU3Mgm6xd76td5QNDi+E1SszVXxMdA+sB/zbSgwR4jtRrVLEIG+Nl0auh+v4VnF dfOUsX9a5F7IBPry01+dwSm/WpPI2BFZl13ejsWWl7NdCu3qF1cB8tehZ90p7xcJpVst 69MJtCVQS5ufoIy1KB69Ua9VKpfzADr8jPPUvC6gnxVUAkKj2mXYG0TZIwOU+Wqqw7/y pB7TaAFXPS55bxxBhRVFWTp4OKEi75cnqEnwTmkn5sNxw8xlg+GTjGat1pCv++Rb3PHW sdeQ== X-Forwarded-Encrypted: i=1; AHgh+RpR77HsIi7oa20KCgUcGeHrbNp/Y37SyWOkL7xvE01Y94VpOM1Oh9sDWCcgcmt15i3+PrU7uXYwF2UU7DI=@vger.kernel.org X-Gm-Message-State: AOJu0YxncKFNn0vlub4y9v2grt6s5WTn2Tfw/aOKUywmWnCOZ0rz5Xgr z9dvHm85fsdgJ0aRjoz5gmEipkB4kooOJ0ulYZqEcd7UkoxPn4XRxqiSMoFVfqw4IlkYLM/CMVf kYC+QsgY6Gzs+mW7EJkyXDSY24X8Ol5PbjZH2cdGnOwPJuaLZFfognPfmg92v/wsj/Q== X-Gm-Gg: AR+sD10FllHtct38yUiFfAdldBNnMXH+T0yPrXOZMXOK+vnQSiUYZ5jMkAeyYWFr8qT 8gPOQncqoSgRCRO2aJ644t7zesLsTXvdwn/aRAtS1XrzVnzBrf78KN1R/l1+cJRGGPnaCiVuWv9 Ie61y2xXzig9u7t4eE1wFGFt9I0JJuGGWOzdrhoCS8ywa6irP1qtbzGHSpbcIRFvr5arA8mW02D 4vaaP3lTupnHXNHvk5/XCpjpZ5cPFONygvv0DAIvKvpCGzjGo4QqUbrKMu0mciAdhOqLlTnGN26 0pzRQ+QgItRvg0xELUA4dO3Y8upNklv27pL8f90WIfxKcVqa9tznxU5e1IkQ/tJxu6EO8JmrDK6 mOUQZOXMRqbQXadHdJLKhoclpyT7JxtCl8S8EfRw= X-Received: by 2002:a05:6000:2486:b0:47f:80df:3ba4 with SMTP id ffacd0b85a97d-47fec62aec8mr13193510f8f.28.1785946892827; Wed, 05 Aug 2026 09:21:32 -0700 (PDT) X-Received: by 2002:a05:6000:2486:b0:47f:80df:3ba4 with SMTP id ffacd0b85a97d-47fec62aec8mr13193399f8f.28.1785946892352; Wed, 05 Aug 2026 09:21:32 -0700 (PDT) Received: from ?IPV6:2a01:e0a:280:24f0:576b:abc6:6396:ed4a? ([2a01:e0a:280:24f0:576b:abc6:6396:ed4a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fec231f5csm10142282f8f.23.2026.08.05.09.21.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Aug 2026 09:21:31 -0700 (PDT) Message-ID: <4ddc95f2-8868-4be3-9839-e2d14cf35fef@redhat.com> Date: Wed, 5 Aug 2026 18:21:30 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/huge_memory: let special huge VMAs bypass the THP policy check To: "Lorenzo Stoakes (ARM)" Cc: Andrew Morton , linux-mm@kvack.org, Peter Xu , David Hildenbrand , Alex Williamson , Jason Gunthorpe , Zi Yan , stable@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260805055544.1568534-1-clg@redhat.com> From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= Content-Language: en-US, fr Autocrypt: addr=clg@redhat.com; keydata= xsFNBFu8o3UBEADP+oJVJaWm5vzZa/iLgpBAuzxSmNYhURZH+guITvSySk30YWfLYGBWQgeo 8NzNXBY3cH7JX3/a0jzmhDc0U61qFxVgrPqs1PQOjp7yRSFuDAnjtRqNvWkvlnRWLFq4+U5t yzYe4SFMjFb6Oc0xkQmaK2flmiJNnnxPttYwKBPd98WfXMmjwAv7QfwW+OL3VlTPADgzkcqj 53bfZ4VblAQrq6Ctbtu7JuUGAxSIL3XqeQlAwwLTfFGrmpY7MroE7n9Rl+hy/kuIrb/TO8n0 ZxYXvvhT7OmRKvbYuc5Jze6o7op/bJHlufY+AquYQ4dPxjPPVUT/DLiUYJ3oVBWFYNbzfOrV RxEwNuRbycttMiZWxgflsQoHF06q/2l4ttS3zsV4TDZudMq0TbCH/uJFPFsbHUN91qwwaN/+ gy1j7o6aWMz+Ib3O9dK2M/j/O/Ube95mdCqN4N/uSnDlca3YDEWrV9jO1mUS/ndOkjxa34ia 70FjwiSQAsyIwqbRO3CGmiOJqDa9qNvd2TJgAaS2WCw/TlBALjVQ7AyoPEoBPj31K74Wc4GS Rm+FSch32ei61yFu6ACdZ12i5Edt+To+hkElzjt6db/UgRUeKfzlMB7PodK7o8NBD8outJGS tsL2GRX24QvvBuusJdMiLGpNz3uqyqwzC5w0Fd34E6G94806fwARAQABzSJDw6lkcmljIExl IEdvYXRlciA8Y2xnQHJlZGhhdC5jb20+wsGRBBMBCAA7FiEEoPZlSPBIlev+awtgUaNDx8/7 7KEFAmTLlVECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQUaNDx8/77KG0eg// S0zIzTcxkrwJ/9XgdcvVTnXLVF9V4/tZPfB7sCp8rpDCEseU6O0TkOVFoGWM39sEMiQBSvyY lHrP7p7E/JYQNNLh441MfaX8RJ5Ul3btluLapm8oHp/vbHKV2IhLcpNCfAqaQKdfk8yazYhh EdxTBlzxPcu+78uE5fF4wusmtutK0JG0sAgq0mHFZX7qKG6LIbdLdaQalZ8CCFMKUhLptW71 xe+aNrn7hScBoOj2kTDRgf9CE7svmjGToJzUxgeh9mIkxAxTu7XU+8lmL28j2L5uNuDOq9vl hM30OT+pfHmyPLtLK8+GXfFDxjea5hZLF+2yolE/ATQFt9AmOmXC+YayrcO2ZvdnKExZS1o8 VUKpZgRnkwMUUReaF/mTauRQGLuS4lDcI4DrARPyLGNbvYlpmJWnGRWCDguQ/LBPpbG7djoy k3NlvoeA757c4DgCzggViqLm0Bae320qEc6z9o0X0ePqSU2f7vcuWN49Uhox5kM5L86DzjEQ RHXndoJkeL8LmHx8DM+kx4aZt0zVfCHwmKTkSTQoAQakLpLte7tWXIio9ZKhUGPv/eHxXEoS 0rOOAZ6np1U/xNR82QbF9qr9TrTVI3GtVe7Vxmff+qoSAxJiZQCo5kt0YlWwti2fFI4xvkOi V7lyhOA3+/3oRKpZYQ86Frlo61HU3r6d9wzOwU0EW7yjdQEQALyDNNMw/08/fsyWEWjfqVhW pOOrX2h+z4q0lOHkjxi/FRIRLfXeZjFfNQNLSoL8j1y2rQOs1j1g+NV3K5hrZYYcMs0xhmrZ KXAHjjDx7FW3sG3jcGjFW5Xk4olTrZwFsZVUcP8XZlArLmkAX3UyrrXEWPSBJCXxDIW1hzwp bV/nVbo/K9XBptT/wPd+RPiOTIIRptjypGY+S23HYBDND3mtfTz/uY0Jytaio9GETj+fFis6 TxFjjbZNUxKpwftu/4RimZ7qL+uM1rG1lLWc9SPtFxRQ8uLvLOUFB1AqHixBcx7LIXSKZEFU CSLB2AE4wXQkJbApye48qnZ09zc929df5gU6hjgqV9Gk1rIfHxvTsYltA1jWalySEScmr0iS YBZjw8Nbd7SxeomAxzBv2l1Fk8fPzR7M616dtb3Z3HLjyvwAwxtfGD7VnvINPbzyibbe9c6g LxYCr23c2Ry0UfFXh6UKD83d5ybqnXrEJ5n/t1+TLGCYGzF2erVYGkQrReJe8Mld3iGVldB7 JhuAU1+d88NS3aBpNF6TbGXqlXGF6Yua6n1cOY2Yb4lO/mDKgjXd3aviqlwVlodC8AwI0Sdu jWryzL5/AGEU2sIDQCHuv1QgzmKwhE58d475KdVX/3Vt5I9kTXpvEpfW18TjlFkdHGESM/Jx IqVsqvhAJkalABEBAAHCwV8EGAECAAkFAlu8o3UCGwwACgkQUaNDx8/77KEhwg//WqVopd5k 8hQb9VVdk6RQOCTfo6wHhEqgjbXQGlaxKHoXywEQBi8eULbeMQf5l4+tHJWBxswQ93IHBQjK yKyNr4FXseUI5O20XVNYDJZUrhA4yn0e/Af0IX25d94HXQ5sMTWr1qlSK6Zu79lbH3R57w9j hQm9emQEp785ui3A5U2Lqp6nWYWXz0eUZ0Tad2zC71Gg9VazU9MXyWn749s0nXbVLcLS0yop s302Gf3ZmtgfXTX/W+M25hiVRRKCH88yr6it+OMJBUndQVAA/fE9hYom6t/zqA248j0QAV/p LHH3hSirE1mv+7jpQnhMvatrwUpeXrOiEw1nHzWCqOJUZ4SY+HmGFW0YirWV2mYKoaGO2YBU wYF7O9TI3GEEgRMBIRT98fHa0NPwtlTktVISl73LpgVscdW8yg9Gc82oe8FzU1uHjU8b10lU XOMHpqDDEV9//r4ZhkKZ9C4O+YZcTFu+mvAY3GlqivBNkmYsHYSlFsbxc37E1HpTEaSWsGfA HQoPn9qrDJgsgcbBVc1gkUT6hnxShKPp4PlsZVMNjvPAnr5TEBgHkk54HQRhhwcYv1T2QumQ izDiU6iOrUzBThaMhZO3i927SG2DwWDVzZltKrCMD1aMPvb3NU8FOYRhNmIFR3fcalYr+9gD uVKe8BVz4atMOoktmt0GWTOC8P4= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for the quick feedback Lorenzo ! > So I think it should be something more like the attached. > > That way all the handling remains the same and the override is applied in > the right place plus smaps keeps working. LGTM, do you want me to respin a v2 with what's below ? or you'd rather send it yourself. C. > ----8<---- > From d6537260722c8741586e6295c8eea68d06087efa Mon Sep 17 00:00:00 2001 > From: "Lorenzo Stoakes (ARM)" > Date: Wed, 5 Aug 2026 11:35:13 +0100 > Subject: [PATCH] ideas > > --- > mm/huge_memory.c | 32 +++++++++++++++++++++++++++++--- > 1 file changed, 29 insertions(+), 3 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index abc65d608c23..5fa01364f089 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -111,6 +111,34 @@ static bool vma_is_special_huge(const struct vm_area_struct *vma) > return vma_test_any(vma, VMA_PFNMAP_BIT, VMA_MIXEDMAP_BIT); > } > > +static bool should_obey_thp_file_tunables(const struct vm_area_struct *vma, > + bool forced_collapse) > +{ > + if (forced_collapse) > + return false; > + VM_WARN_ON_ONCE(vma_is_anonymous(vma)); > + /* Huge PFN mappings allocate no folios so the policy doesn't apply. */ > + if (vma_test(vma, VMA_PFNMAP_BIT) && vma->vm_ops->huge_fault) > + return false; > + return true; > +} > + > +static bool can_thp_collapse_file(const struct vm_area_struct *vma, > + vm_flags_t vm_flags, bool forced_collapse) > +{ > + /* Override THP tunables? */ > + if (!should_obey_thp_file_tunables(vma, forced_collapse)) > + return true; > + /* THP=always? */ > + if (hugepage_global_always()) > + return true; > + /* THP=madvise? */ > + if (!hugepage_global_enabled()) > + return false; > + /* Has VMA had madvise(..., MADV_HUGEPAGE) applied to it? */ > + return vm_flags & VM_HUGEPAGE; > +} > + > unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma, > vm_flags_t vm_flags, > enum tva_type type, > @@ -188,9 +216,7 @@ unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma, > * Enforce THP collapse requirements as necessary. Anonymous vmas > * were already handled in thp_vma_allowable_orders(). > */ > - if (!forced_collapse && > - (!hugepage_global_enabled() || (!(vm_flags & VM_HUGEPAGE) && > - !hugepage_global_always()))) > + if (!can_thp_collapse_file(vma, vm_flags, forced_collapse)) > return 0; > > /* > -- > 2.55.0 >