RE: [PATCH 5/6] dt-bindings: crypto: Add bindings for Starfive crypto driver

JiaJie Ho
2022-12-06T08:36:06Z

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Thursday, December 1, 2022 5:27 PM
> To: JiaJie Ho <jiajie.ho@starfivetech.com>; Herbert Xu
> <herbert@gondor.apana.org.au>; David S . Miller <davem@davemloft.net>;
> Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>
> Cc: linux-crypto@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-riscv@lists.infradead.org
> Subject: Re: [PATCH 5/6] dt-bindings: crypto: Add bindings for Starfive crypto
> driver
>
> On 01/12/2022 10:01, JiaJie Ho wrote:
>
> >>> +
> >>> + enable-side-channel-mitigation:
> >>> + description: Enable side-channel-mitigation feature for AES module.
> >>> + Enabling this feature will affect the speed performance of
> >>> + crypto engine.
> >>> + type: boolean
> >>
> >> Why exactly this is a hardware (DT) property, not runtime?
> >>
> >
> > This is a hardware setting provided in StarFive crypto engine only.
> > The crypto API doesn't control this setting during runtime and leaving this
> always on will impact speed performance.
> > So, I added this property to allow user to control this in dtb.
>
> Devicetree should not describe policies, so without justification it does not
> look like hardware property. Drop.
>
I'll remove this in v2 and set the value using module param instead.
Thanks.

Best regards,
Jia Jie