Re: [PATCH 08/10] NOTIFIER: Take over TIF_MCE_NOTIFY and implement task return notifier

Avi Kivity
2011-06-14T11:41:22Z

On 06/13/2011 08:13 PM, Tony Luck wrote:
> On Mon, Jun 13, 2011 at 9:31 AM, Avi Kivity<avi@redhat.com> wrote:
> > I don't think a user_return_notifier is needed here. You don't just want to
> > do things before a userspace return, you also want to do them soon. A user
> > return notifier might take a very long time to run, if a context switch
> > occurs to a thread that spends a lot of time in the kernel (perhaps a
> > realtime thread).
> >
> > So I think the best choice here is MCE -> irq_work -> realtime kernel thread
> > (or work queue)
>
> In the AO (action optional case (e.g. patrol scrubber) - there isn't much rush.
> We'd like to process things "soon" (before someone hits the corrupt location)
> but we don't need to take extraordinary efforts to make "soon" happen.
>
> In the AR (action required - instruction or data fetch from a corrupted
> memory location) our main priority is making sure that we don't continue
> the task that hit the error - because we don't want to hit it again (as Boris
> said, on Intel cpus this is very disruptive to the system as every cpu is
> sent the machine check signal - and the code has to read a large number
> of slow "msr" registers to figure out what happened. If we can guarantee
> that we won't run this task - then the time pressure is greatly reduced.

Aren't these events extraordinarily rare? I think we can afford a
little inefficiency there.

Even with mce -> irq_work -> rt thread, we're unlikely to return to the
task as the rt thread will displace the task. It may be migrated to an
idle cpu, but even then we may be able to drop the page before it gets
back to userspace.

> So if we can do:
>
> MCE -> irq_work -> make-task-not-runnable -> thread-or-work-queue
>
> in a reliable way, then that would meet the needs. PeterZ didn't like the
> idea of setting TASK_STOPPED or _UNINTERRUPTIBLE in NMI
> context in the MC handler - but I think he was okay with it inside the
> irq_work handler.

How about signalling it with a kernel-internal signal?

I don't think that doing anything to the task is correct, though, as the
problem is with the page, not the task itself. In fact if the task is
executing a vgather instruction, or if another thread munmap()s the
page, it may not hit the same page again when re-executed.

--
error compiling committee.c: too many arguments to function