Re: [PATCH 05/10] MCE: Mask out address mask bits below address granuality

Andi Kleen
2011-06-11T00:14:10Z

Tony Luck <tony.luck@gmail.com> writes:

> 2011/6/10 Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>:
>> Why do you have to mask it out in kernel, why not in user/logger?
>>
>> One possible story is:
>>  "... the brand-new Xeon XXXX has new MCx_***_VALID bit in ****
>>  register, if it is set the lower bits of MCx_ADDR indicates
>>  ****, otherwise the bits are undefined ..."
>>
>> So I think that kernel should convey the raw value from hardware to
>> userland.  Even if it contains some noise on it, user can determine
>> whether it is useful or not.  And more, since this is an error record,
>> there will be no second chance to retrieve the data afterward.
>
> This is a good point - we should log the original untouched bits someplace.

These bits are undefined. It doesn't make sense to log undefined bits.
They can contain random values. Showing random values just confuses
people.

How would the user even know it's undefined? They normally don't read
the specs. Really programs have to handle that for the user. And there
the only sane way is to just mask them off.

-Andi
--
ak@linux.intel.com -- Speaking for myself only