From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D67FC7EE29 for ; Thu, 1 Jun 2023 07:59:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231803AbjFAH7s (ORCPT ); Thu, 1 Jun 2023 03:59:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231641AbjFAH7X (ORCPT ); Thu, 1 Jun 2023 03:59:23 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E99791981 for ; Thu, 1 Jun 2023 00:52:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685605927; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UGN0oJNZes7Qo6ZcpteciDRTsS0uKCd+DRQnkDayhbo=; b=Ym2XfrjPng9LE4kAD1nGewVUpZE5uc+D+H2KD2kFHs/htRA7fyTFD1+XQsrK/0vbLva4JC x/XfzBDSbdvAj/nKbdWBYTShI62PefBNLDvEMI6ItdHBlXSOq+DFCW4vfeCUd+SqgdCJ5m UABrlYMt8kppkZ0b08jNX9HpDpQOGRs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-369-KdfeT4rmMJuW_7-bC6FadA-1; Thu, 01 Jun 2023 03:52:03 -0400 X-MC-Unique: KdfeT4rmMJuW_7-bC6FadA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3f41a04a297so3708465e9.3 for ; Thu, 01 Jun 2023 00:52:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685605923; x=1688197923; h=content-transfer-encoding:in-reply-to:subject:organization:from :content-language:references:cc:to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UGN0oJNZes7Qo6ZcpteciDRTsS0uKCd+DRQnkDayhbo=; b=e/pLkxqd3cDour9Ic4kA1/9YHNrmmUQf6/PUPc9jSV+Uzbd2SQ272nStngxJS0pbg9 D4XzlDo1ZgvbcPiU3KF5wUXlHnc/PJobpKiWHHElIhSCHtA6HILw1s1DnIsR7CymCBEO COqYDsE2iXcsb33IF9vrM+rqIadP9ck30/YR84ArJSx/cuD4yE0aLNlZKa2o+K+oxbuP yXNrizyUbTFkGDcaWt8C93byLtc2I3oHhTEOyiHDaO/AGyP86qJWhcvIeRvu1t0lb7pF kOYPBZjjNzfivX+C3ataJcv7EIAcjZu9BBRYXf54D8q9yUPHxiopYq/10GfzpSGBZSfQ Bz5w== X-Gm-Message-State: AC+VfDyh+k/5tfJ5CcyfiLWrVLc7q9ZJ1JUty9ZVrq14vBQgNX0tMD1t MZGkI3SoUPGbTSWcUcz8Ip44FrtwsnrGevBAy3v47mYp8Az9rdcAMBRxCC7YiZqE7Pnoh37QjEh 1MfF5HVC5Y89gBqdxU5mQ5P+y X-Received: by 2002:a05:600c:2252:b0:3f6:f29:7b41 with SMTP id a18-20020a05600c225200b003f60f297b41mr1285387wmm.7.1685605922820; Thu, 01 Jun 2023 00:52:02 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6pqppsA7O9z8geVps55kh02RQkezTsYAVSQPRyQwzdBB9ynfyxZUJOB68G0Jnr3KhTLwFlsg== X-Received: by 2002:a05:600c:2252:b0:3f6:f29:7b41 with SMTP id a18-20020a05600c225200b003f60f297b41mr1285375wmm.7.1685605922505; Thu, 01 Jun 2023 00:52:02 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id w8-20020a1cf608000000b003f603b8eb5asm1338590wmc.7.2023.06.01.00.52.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Jun 2023 00:52:02 -0700 (PDT) Message-ID: <4dfd0f47-e1f7-1e9f-65e0-ee4881495be3@redhat.com> Date: Thu, 1 Jun 2023 09:52:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Andrew Morton , Shuah Khan , Jens Axboe , Peter Xu , Jason Gunthorpe , John Hubbard , Jan Kara References: <20230519102723.185721-1-david@redhat.com> <20230519102723.185721-2-david@redhat.com> Content-Language: en-US From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v1 1/3] selftests/mm: factor out detection of hugetlb page sizes into vm_util In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.05.23 16:49, Lorenzo Stoakes wrote: > On Fri, May 19, 2023 at 12:27:21PM +0200, David Hildenbrand wrote: >> Let's factor detection out into vm_util, to be reused by a new test. >> > > Bit of a nit as it's hardly vitally important, but perhaps worth mentioning > that you also refactor the function to accept any array (this is a > requirement rather than simply refactoring a thing but still :) Well, the function used to, and still does accept an array. It's just a more human-friendly way of expressing that. If I have to resend the whole patchset, I can add a note "While at it, make the function accept an array instead of a raw pointer.". [...] > > Looks good to me, > > Reviewed-by: Lorenzo Stoakes > Thanks! -- Thanks, David / dhildenb