From: Judith Mendez <jm@ti.com>
To: Sukrut Bellary <sbellary@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>, Nishanth Menon <nm@ti.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
Andreas Kemnade <andreas@kemnade.info>,
Roger Quadros <rogerq@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Bajjuri Praneeth <praneeth@ti.com>,
Raghavendra Vignesh <vigneshr@ti.com>, Bin Liu <b-liu@ti.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-pm@vger.kernel.org>, Russell King <linux@armlinux.org.uk>,
Rob Herring <robh@kernel.org>, Tony Lindgren <tony@atomide.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Subject: Re: [PATCH 0/4] PM: TI: AM335x: PM STANDBY fixes
Date: Tue, 6 May 2025 15:01:41 -0500 [thread overview]
Message-ID: <4e014361-65ec-4b6e-839d-bfeb995262c6@ti.com> (raw)
In-Reply-To: <20250318230042.3138542-1-sbellary@baylibre.com>
Hello Sukrut, Keven, Ulf,
On 3/18/25 6:00 PM, Sukrut Bellary wrote:
> This patch series fixes the Power management issues on TI's am335x soc.
>
> on AM335x, the wakeup doesn't work in the case of STANDBY.
>
> 1. Since CM3 PM FW [1](ti-v4.1.y) doesn't enable l4ls clockdomain upon
> wakeup, it fails to wakeup the MPU.
> To fix this, don't turn off the l4ls clk domain in the STANDBY transition
> in MPU.
>
> 2. Also Per AM335x TRM [2](section 8.1.4.3 Power mode), in case of STANDBY,
> PER domain should be ON. So fix PER power domain handling for
> standby. l4ls is a part of the PER domain.
>
> Since we are not turning off the l4ls clockdomain on STANDBY in MPU,
> PER power domain would remain ON. But still, explicitly handle this
> to be in sync with the STANDBY requirement.
>
> 3. On am335x evm[1], UART0 - (UART1-HW) has a wakeup capability.
> Set the wakeup-source property in DT for AM335x.
>
> 4. Enable PM configs for AM335x.
>
> [1] https://git.ti.com/cgit/processor-firmware/ti-amx3-cm3-pm-firmware/
> [2] https://www.ti.com/lit/ug/spruh73q/spruh73q.pdf
> [3] https://www.ti.com/tool/TMDXEVM3358
>
> Test log:
> https://gist.github.com/sukrutb/bdbfd1220fe8578a9decf87d0bac6796
>
Thanks for the patches, Sukrut.
I was able to test this series on am335x EVM, baseline being rc5 next
branch: https://gist.github.com/jmenti/cda1675b5fc5844b6f065376e98026f5
Tested-by: Judith Mendez <jm@ti.com>
regards,
~ Judith
prev parent reply other threads:[~2025-05-06 20:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 23:00 [PATCH 0/4] PM: TI: AM335x: PM STANDBY fixes Sukrut Bellary
2025-03-18 23:00 ` [PATCH 1/4] ARM: OMAP2+: Fix l4ls clk domain handling in STANDBY Sukrut Bellary
2025-03-18 23:00 ` [PATCH 2/4] pmdomain: ti: Fix STANDBY handling of PER power domain Sukrut Bellary
2025-05-08 13:14 ` Kevin Hilman
2025-05-19 14:19 ` Ulf Hansson
2025-03-18 23:00 ` [PATCH 3/4] ARM: dts: am335x: Set wakeup-source for UART0 Sukrut Bellary
2025-03-18 23:00 ` [PATCH 4/4] ARM: multi_v7_defconfig: Enable am335x PM configs Sukrut Bellary
2025-05-08 13:20 ` Kevin Hilman
2025-05-29 17:21 ` Kevin Hilman
2025-04-11 0:30 ` [PATCH 0/4] PM: TI: AM335x: PM STANDBY fixes Kevin Hilman
2025-04-24 10:04 ` Ulf Hansson
2025-05-02 16:52 ` Kevin Hilman
2025-05-06 20:01 ` Judith Mendez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e014361-65ec-4b6e-839d-bfeb995262c6@ti.com \
--to=jm@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=andreas@kemnade.info \
--cc=b-liu@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nm@ti.com \
--cc=praneeth@ti.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=sbellary@baylibre.com \
--cc=ssantosh@kernel.org \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox