From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FEA9C433E0 for ; Wed, 3 Jun 2020 10:07:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B0A62067B for ; Wed, 3 Jun 2020 10:07:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="nhVTSB5y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726785AbgFCKH3 (ORCPT ); Wed, 3 Jun 2020 06:07:29 -0400 Received: from mail27.static.mailgun.info ([104.130.122.27]:43406 "EHLO mail27.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725854AbgFCKH3 (ORCPT ); Wed, 3 Jun 2020 06:07:29 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1591178848; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=uyzsI0JW6ZqWgRjfRioirvwF2C7h2JnRAHdFXXPljts=; b=nhVTSB5ybpO8RoJvH6Vwv2fEnQSzpCs+jXlDfuDB4IJzdTs87+7MTqls/dnq6rnv0vnNcFwo Z5HT6r1LUmMh2tBGS3S2uM9TFE9iQ2xm6kiy0qhrc7X/UZX5ovnugnCWYcUVdX9oEKq2VJeh gzg36FXRcqVXnVEo8sj5jUeIBSg= X-Mailgun-Sending-Ip: 104.130.122.27 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n12.prod.us-west-2.postgun.com with SMTP id 5ed7764f09c3530d1278f8ad (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 03 Jun 2020 10:07:11 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id AD5D4C4339C; Wed, 3 Jun 2020 10:07:11 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: govinds) by smtp.codeaurora.org (Postfix) with ESMTPSA id EB560C433CA; Wed, 3 Jun 2020 10:07:10 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 03 Jun 2020 15:37:10 +0530 From: govinds@codeaurora.org To: Manivannan Sadhasivam Cc: Brian Norris , John Stultz , lkml , Rakesh Pillai , Bjorn Andersson , Niklas Cassel , Amit Pundir , Kalle Valo , ath10k , Sibi Sankar Subject: Re: [PATCH] wireless: ath10k: Return early in ath10k_qmi_event_server_exit() to avoid hard crash on reboot In-Reply-To: <20200603002715.GA5349@Mani-XPS-13-9360> References: <20200602052533.15048-1-john.stultz@linaro.org> <20200603002715.GA5349@Mani-XPS-13-9360> Message-ID: <4e0642b9882c41f4c10963b265bf6d9f@codeaurora.org> X-Sender: govinds@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mani, On 2020-06-03 05:57, Manivannan Sadhasivam wrote: > On Tue, Jun 02, 2020 at 01:04:26PM -0700, Brian Norris wrote: >> On Tue, Jun 2, 2020 at 12:40 PM John Stultz >> wrote: >> > On Tue, Jun 2, 2020 at 12:16 PM Brian Norris wrote: >> > > On Mon, Jun 1, 2020 at 10:25 PM John Stultz wrote: >> > > > >> > > > Ever since 5.7-rc1, if we call >> > > > ath10k_qmi_remove_msa_permission(), the db845c hard crashes on >> > > > reboot, resulting in the device getting stuck in the usb crash >> > > > debug mode and not coming back up wihthout a hard power off. >> > > > >> > > > This hack avoids the issue by returning early in >> > > > ath10k_qmi_event_server_exit(). >> > > > >> > > > A better solution is very much desired! >> > > >> > > Any chance you can bisect what caused this? There are a lot of >> > > non-ath10k pieces involved in this stuff. >> > >> > Amit had spent some work on chasing it down to the in kernel qrtr-ns >> > work, and reported it here: >> > https://lists.infradead.org/pipermail/ath10k/2020-April/014970.html >> > >> > But that discussion seemingly stalled out, so I came up with this hack >> > to workaround it for us. >> >> If I'm reading it right, then that means we should revert this stuff >> from v5.7-rc1: >> >> 0c2204a4ad71 net: qrtr: Migrate nameservice to kernel from userspace >> >> At least, until people can resolve the tail end of that thread. New >> features (ath11k, etc.) are not a reason to break existing features >> (ath10k/wcn3990). > > I don't agree with this. If you read through the replies to the bug > report, > it is clear that NS migration uncovered a corner case or even a bug. So > we > should try to fix that indeed. > > Govind: Did you get chance to work on fixing this issue? > I have done basic testing by moving msa map/unmap from qmi service callbacks to init/de-init path. I will send patch for review. Reason for del_server needs to investigated from rproc side. > Thanks, > Mani > >> >> Brian Thanks, Govind