Re: [PATCH 1/2] huge_mm.h: is_huge_zero_folio(NULL) should return false

[David Hildenbrand <david@redhat.com>]

On 27.08.25 03:55, Andrew Morton wrote:
> On Wed, 27 Aug 2025 01:16:24 +0200 Max Kellermann <max.kellermann@ionos.com> wrote:
> 
>> Calling is_huge_zero_folio(NULL) should not be legal - it makes no
>> sense, and a different (theoretical) implementation may dereference
>> the pointer.  But currently, lacking any explicit documentation, this
>> call is legal.
>>
>> But if somebody really passes NULL, the function should not return
>> true - this isn't the huge zero folio after all!  However, if the
>> `huge_zero_folio` hasn't been allocated yet, it's NULL, and
>> is_huge_zero_folio(NULL) just happens to return true, which is a lie.
> 
> Isn't it a bug to call is_huge_zero_folio() before the huge_zero_folio
> has been created?

It's a bug to call a function that expects a folio without a folio.

> 
> Being a simple soul, I'm thinking
> 
> 	VM_BUG_ON(!huge_zero_folio);
> 	VM_BUG_ON(!folio);

We should just do VM_WARN_ON(!folio);

-- 
Cheers

David / dhildenb