* [PATCH] Fixed coding style in drivers/acpi/ac.c
@ 2011-07-18 17:14 Angus Hammond
2011-07-18 17:52 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Angus Hammond @ 2011-07-18 17:14 UTC (permalink / raw)
Changed lines causing errors from scrips/checkpatch.pl.
---
drivers/acpi/ac.c | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
index 58c3f74..e510828 100644
--- a/drivers/acpi/ac.c
+++ b/drivers/acpi/ac.c
@@ -1,5 +1,5 @@
/*
- * acpi_ac.c - ACPI AC Adapter Driver ($Revision: 27 $)
+ * acpi_ac.c - ACPI AC Adapter Driver
*
* Copyright (C) 2001, 2002 Andy Grover <andrew.grover@intel.com>
* Copyright (C) 2001, 2002 Paul Diefenbaugh <paul.s.diefenbaugh@intel.com>
@@ -54,8 +54,8 @@ MODULE_DESCRIPTION("ACPI AC Adapter Driver");
MODULE_LICENSE("GPL");
#ifdef CONFIG_ACPI_PROCFS_POWER
-extern struct proc_dir_entry *acpi_lock_ac_dir(void);
-extern void *acpi_unlock_ac_dir(struct proc_dir_entry *acpi_ac_dir);
+struct proc_dir_entry *acpi_lock_ac_dir(void);
+void *acpi_unlock_ac_dir(struct proc_dir_entry *acpi_ac_dir);
static int acpi_ac_open_fs(struct inode *inode, struct file *file);
#endif
@@ -85,7 +85,7 @@ static struct acpi_driver acpi_ac_driver = {
struct acpi_ac {
struct power_supply charger;
- struct acpi_device * device;
+ struct acpi_device *device;
unsigned long long state;
};
@@ -102,7 +102,7 @@ static const struct file_operations acpi_ac_fops = {
#endif
/* --------------------------------------------------------------------------
- AC Adapter Management
+ AC Adapter Management
-------------------------------------------------------------------------- */
static int acpi_ac_get_state(struct acpi_ac *ac)
@@ -124,7 +124,7 @@ static int acpi_ac_get_state(struct acpi_ac *ac)
}
/* --------------------------------------------------------------------------
- sysfs I/F
+ sysfs I/F
-------------------------------------------------------------------------- */
static int get_ac_property(struct power_supply *psy,
enum power_supply_property psp,
@@ -154,7 +154,7 @@ static enum power_supply_property ac_props[] = {
#ifdef CONFIG_ACPI_PROCFS_POWER
/* --------------------------------------------------------------------------
- FS Interface (/proc)
+ FS Interface (/proc)
-------------------------------------------------------------------------- */
static struct proc_dir_entry *acpi_ac_dir;
@@ -230,7 +230,7 @@ static int acpi_ac_remove_fs(struct acpi_device *device)
#endif
/* --------------------------------------------------------------------------
- Driver Model
+ Driver Model
-------------------------------------------------------------------------- */
static void acpi_ac_notify(struct acpi_device *device, u32 event)
@@ -298,7 +298,7 @@ static int acpi_ac_add(struct acpi_device *device)
acpi_device_name(device), acpi_device_bid(device),
ac->state ? "on-line" : "off-line");
- end:
+end:
if (result) {
#ifdef CONFIG_ACPI_PROCFS_POWER
acpi_ac_remove_fs(device);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Fixed coding style in drivers/acpi/ac.c
2011-07-18 17:14 [PATCH] Fixed coding style in drivers/acpi/ac.c Angus Hammond
@ 2011-07-18 17:52 ` Joe Perches
0 siblings, 0 replies; 3+ messages in thread
From: Joe Perches @ 2011-07-18 17:52 UTC (permalink / raw)
To: Angus Hammond; +Cc: LKML, Len Brown, linux-acpi
On Mon, 2011-07-18 at 18:14 +0100, Angus Hammond wrote:
> Changed lines causing errors from scrips/checkpatch.pl.
Please don't send emails with only bcc's.
It makes following up / reply-all difficult.
Use ./scripts/get_maintainer.pl <patch> as a guide
to determine the best recipients for a patch.
> ---
> drivers/acpi/ac.c | 18 +++++++++---------
> 1 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
> index 58c3f74..e510828 100644
> --- a/drivers/acpi/ac.c
> +++ b/drivers/acpi/ac.c
> @@ -1,5 +1,5 @@
> /*
> - * acpi_ac.c - ACPI AC Adapter Driver ($Revision: 27 $)
> + * acpi_ac.c - ACPI AC Adapter Driver
> *
> * Copyright (C) 2001, 2002 Andy Grover <andrew.grover@intel.com>
> * Copyright (C) 2001, 2002 Paul Diefenbaugh <paul.s.diefenbaugh@intel.com>
> @@ -54,8 +54,8 @@ MODULE_DESCRIPTION("ACPI AC Adapter Driver");
> MODULE_LICENSE("GPL");
>
> #ifdef CONFIG_ACPI_PROCFS_POWER
> -extern struct proc_dir_entry *acpi_lock_ac_dir(void);
> -extern void *acpi_unlock_ac_dir(struct proc_dir_entry *acpi_ac_dir);
> +struct proc_dir_entry *acpi_lock_ac_dir(void);
> +void *acpi_unlock_ac_dir(struct proc_dir_entry *acpi_ac_dir);
> static int acpi_ac_open_fs(struct inode *inode, struct file *file);
> #endif
>
> @@ -85,7 +85,7 @@ static struct acpi_driver acpi_ac_driver = {
>
> struct acpi_ac {
> struct power_supply charger;
> - struct acpi_device * device;
> + struct acpi_device *device;
> unsigned long long state;
> };
>
> @@ -102,7 +102,7 @@ static const struct file_operations acpi_ac_fops = {
> #endif
>
> /* --------------------------------------------------------------------------
> - AC Adapter Management
> + AC Adapter Management
> -------------------------------------------------------------------------- */
>
> static int acpi_ac_get_state(struct acpi_ac *ac)
> @@ -124,7 +124,7 @@ static int acpi_ac_get_state(struct acpi_ac *ac)
> }
>
> /* --------------------------------------------------------------------------
> - sysfs I/F
> + sysfs I/F
> -------------------------------------------------------------------------- */
> static int get_ac_property(struct power_supply *psy,
> enum power_supply_property psp,
> @@ -154,7 +154,7 @@ static enum power_supply_property ac_props[] = {
>
> #ifdef CONFIG_ACPI_PROCFS_POWER
> /* --------------------------------------------------------------------------
> - FS Interface (/proc)
> + FS Interface (/proc)
> -------------------------------------------------------------------------- */
>
> static struct proc_dir_entry *acpi_ac_dir;
> @@ -230,7 +230,7 @@ static int acpi_ac_remove_fs(struct acpi_device *device)
> #endif
>
> /* --------------------------------------------------------------------------
> - Driver Model
> + Driver Model
> -------------------------------------------------------------------------- */
>
> static void acpi_ac_notify(struct acpi_device *device, u32 event)
> @@ -298,7 +298,7 @@ static int acpi_ac_add(struct acpi_device *device)
> acpi_device_name(device), acpi_device_bid(device),
> ac->state ? "on-line" : "off-line");
>
> - end:
> +end:
> if (result) {
> #ifdef CONFIG_ACPI_PROCFS_POWER
> acpi_ac_remove_fs(device);
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] Fixed coding style in drivers/acpi/ac.c
@ 2011-06-22 21:14 Angus Hammond
0 siblings, 0 replies; 3+ messages in thread
From: Angus Hammond @ 2011-06-22 21:14 UTC (permalink / raw)
To: Linux Kernel; +Cc: linux-acpi
Changed lines causing errors from scrips/checkpatch.pl.
Signed-off-by: Angus Hammond <angusgh@gmail.com>
---
drivers/acpi/ac.c | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
index 58c3f74..e510828 100644
--- a/drivers/acpi/ac.c
+++ b/drivers/acpi/ac.c
@@ -1,5 +1,5 @@
/*
- * acpi_ac.c - ACPI AC Adapter Driver ($Revision: 27 $)
+ * acpi_ac.c - ACPI AC Adapter Driver
*
* Copyright (C) 2001, 2002 Andy Grover <andrew.grover@intel.com>
* Copyright (C) 2001, 2002 Paul Diefenbaugh <paul.s.diefenbaugh@intel.com>
@@ -54,8 +54,8 @@ MODULE_DESCRIPTION("ACPI AC Adapter Driver");
MODULE_LICENSE("GPL");
#ifdef CONFIG_ACPI_PROCFS_POWER
-extern struct proc_dir_entry *acpi_lock_ac_dir(void);
-extern void *acpi_unlock_ac_dir(struct proc_dir_entry *acpi_ac_dir);
+struct proc_dir_entry *acpi_lock_ac_dir(void);
+void *acpi_unlock_ac_dir(struct proc_dir_entry *acpi_ac_dir);
static int acpi_ac_open_fs(struct inode *inode, struct file *file);
#endif
@@ -85,7 +85,7 @@ static struct acpi_driver acpi_ac_driver = {
struct acpi_ac {
struct power_supply charger;
- struct acpi_device * device;
+ struct acpi_device *device;
unsigned long long state;
};
@@ -102,7 +102,7 @@ static const struct file_operations acpi_ac_fops = {
#endif
/* --------------------------------------------------------------------------
- AC Adapter Management
+ AC Adapter Management
-------------------------------------------------------------------------- */
static int acpi_ac_get_state(struct acpi_ac *ac)
@@ -124,7 +124,7 @@ static int acpi_ac_get_state(struct acpi_ac *ac)
}
/* --------------------------------------------------------------------------
- sysfs I/F
+ sysfs I/F
-------------------------------------------------------------------------- */
static int get_ac_property(struct power_supply *psy,
enum power_supply_property psp,
@@ -154,7 +154,7 @@ static enum power_supply_property ac_props[] = {
#ifdef CONFIG_ACPI_PROCFS_POWER
/* --------------------------------------------------------------------------
- FS Interface (/proc)
+ FS Interface (/proc)
-------------------------------------------------------------------------- */
static struct proc_dir_entry *acpi_ac_dir;
@@ -230,7 +230,7 @@ static int acpi_ac_remove_fs(struct acpi_device *device)
#endif
/* --------------------------------------------------------------------------
- Driver Model
+ Driver Model
-------------------------------------------------------------------------- */
static void acpi_ac_notify(struct acpi_device *device, u32 event)
@@ -298,7 +298,7 @@ static int acpi_ac_add(struct acpi_device *device)
acpi_device_name(device), acpi_device_bid(device),
ac->state ? "on-line" : "off-line");
- end:
+end:
if (result) {
#ifdef CONFIG_ACPI_PROCFS_POWER
acpi_ac_remove_fs(device);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-18 17:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-18 17:14 [PATCH] Fixed coding style in drivers/acpi/ac.c Angus Hammond
2011-07-18 17:52 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2011-06-22 21:14 Angus Hammond
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox