From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED4133A6400 for ; Mon, 27 Apr 2026 08:53:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777280037; cv=none; b=ADprmuHdIhPziSmvHVlX6fCwcES8bD0gZE9PukIMhtzukrcu6OFn7mlkImfA/Lcwpa7L2//i9N4gGQHVjUW3oOjvu9dBVqzTnDHc06WXpTaUYJa4HSTXg4SMio/qEj5rxJ8ShBQCF3Fy09mfkPa9DWBSDuV1X9Z3f8y10swfwdE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777280037; c=relaxed/simple; bh=QHXOWtnq9cgmubmDixNzL0+Z3UtjTagU1DyYkog4n7M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N6TxkN9IDj3TKfOMJPdtVK45eCCfTBAxHk1UzgfzcZQNYrGv9qoTaKTLE1g94VWLjW9RJ4mW6yyL7DRB/aDP3d4KL+xc6AxMsQ8jvZpgTg0Phk2YS1VPSTBlybbzfOXmFsiOXhSujgwrUGaVP5Q4hwBVDidRKKEoHLI+pnZ0zxI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=ApjETRDO; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="ApjETRDO" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-44369c9c6c2so51133f8f.1 for ; Mon, 27 Apr 2026 01:53:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1777280034; x=1777884834; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Nn2wJIGRY+crFZKAPwjDcRgbUW7V+wi7su4exIbXb2M=; b=ApjETRDOELRnun+RklZhOlNVaSEQ+38oeimzncxLqfzh0kqaGAIyVCy5pSqFtjtHq4 1KIXEzrnwIJMzg2fxIlLsrk6spIGl2mjGU/VFqp5qx4cHARUQRXo6KJxj+V9pNYBkqgr t/HA2aPsvFwtXU4v+21GFfnjwdaXANQU0X5WEXM4evSaj8UgR3EaoWgvb54wm3vfK9hZ JOy2KkItnD170DhYPJdzd7iIOey/AynwA0f7Z9fsHFyJPUnZxO84fjhmi9DNhBULbaN5 jhIMvVcuqk+tBgEpk3vlMS1HBYogJu8r15gi713T99W8nibWEopgVPnuEuQcS7ODEpuo lRKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777280034; x=1777884834; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Nn2wJIGRY+crFZKAPwjDcRgbUW7V+wi7su4exIbXb2M=; b=PqXrvwQZjpnHPSMtTYpIEDI8h/UTqwGG30G3fyHoSNQI37iluK+zOFNq8GbRyzKLEw xBiLqxrrvIrLUIYA0h7qilgyB4m3LgP71JCBjHVKIhWs7NjRhYPjAjF8iCNTg15aVx7V GkkQ/C7EzE6f4qf0SpToDwSADCCqSy5vY9QXcM5nviaYpXCiacchuKBz1f6bPzco2CvA ENHG40t2ES/aREUpsTcL6L1Aq/7fpAQVqdMM+Eg0kELL00Cq6YM0Tm2YG94GxZdYF3Zs v1O6Acqxcb1b1XnDaqK8zIEHyitOW/JdgmlajmI8likROsFKGYaka+y7ejUL2JEsdKou vebw== X-Forwarded-Encrypted: i=1; AFNElJ9SOO+aCbh9LzzqcY0syoEN9Cqan/ui0hY/HiqIfyKjAHSNEKjgeMzdc8JlFxTTaq8okMsh+X396w+qYEI=@vger.kernel.org X-Gm-Message-State: AOJu0YwPetFl3r6HPqEQujSBxJaeA9TAK2UGUJBz4PvDLobVuq/J+/QT QXr83oSwS14Gua9/ERLSKttPT/nm4i0KbtJwytrz2N4kzWGS1pAYQUhUypv47SrGDYRXod7OdlF 0n8Jp5A0= X-Gm-Gg: AeBDiev7FkDaUwDjuhSnIbEp978SizUoZzYIQ9f2WedYSKPTnpM11QIUJfDbnjeWh3j uw8I1GRh+t2ulkyDDem2BxczourjBux/ZThE6C7Q8LDzzDPeV0AM7P7PiODWRxJgWtC3arXLjNv Y/etaSNRzONrXyBDPqk6BrHNwXGWuOjaFiw/WYyq0Sn5gwDV3M5VOxlztrXb/V57GwrqVCaIWdU KTFyMPyILwQgvkF+GrzN8xRYeYqn7JmpG/c188/Ob+APWtnJGrHcN6bUvrhThnLPo64HdS8gdFm IS4HqI+sggwkydxgxwOPFFJBajRdGRzE36L6/gU8wDR4EG1JBBW7S+kLoPu/pfF5cUWHqFwqlO4 UyEa/NUiyFAakG92VSHkdcGjloe1dGBxk1RlYY0a8RcCKPEVMzHhLTmn2XKjenDPskDc4xxqiDH ziSFgSPs2ORKDprEPizTW5mnzPUDtePNpJnmdCPlZpeIAfPx9hfPIK9H+pjia5zyo/PEtq X-Received: by 2002:a05:600c:154e:b0:487:17d:d0bf with SMTP id 5b1f17b1804b1-488fb769fb4mr267995825e9.6.1777280034268; Mon, 27 Apr 2026 01:53:54 -0700 (PDT) Received: from ?IPV6:2001:1a48:8:903:1ed6:4f73:ce38:f9d4? ([2001:1a48:8:903:1ed6:4f73:ce38:f9d4]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb7b2716sm248233245e9.30.2026.04.27.01.53.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2026 01:53:53 -0700 (PDT) Message-ID: <4e269fb1-cd6c-46ca-ac2a-168ce9fd06fe@suse.com> Date: Mon, 27 Apr 2026 10:53:52 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linus:master] [mm] c6307674ed: BUG:sleeping_function_called_from_invalid_context_at_mm/vmalloc.c Content-Language: en-US To: Herbert Xu , Uladzislau Rezki , Harry Yoo , Hao Li Cc: Thomas Graf , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Michal Hocko , Baoquan He , Alexander Potapenko , Andrey Ryabinin , Marco Elver , Michal Hocko , linux-mm@kvack.org References: <202604211323.fac1b29e-lkp@intel.com> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/23/26 05:34, Herbert Xu wrote: > On Wed, Apr 22, 2026 at 10:32:16AM +0200, Uladzislau Rezki wrote: >> >> We have added non-sleeping flags for vmalloc() to extend kvmalloc() >> functionality as folk need those. >> >> Another option, would be: always use vfree_atomic() from the kvfree() >> path. >> >> Any thoughts? > > Perhaps add a kvfree_atomic that just calls vfree_atomic? kvfree()'s comment says " * Context: Either preemptible task context or not-NMI interrupt." so this is neither. It might be ok then to create kvfree_atomic(). Always using vfree_atomic() from kvfree() might be wasteful. > For rhashtable it really makes no difference either way. But it > would eliminate the unsightly call to is_vmalloc_addr in rhashtable. > > Thanks,