From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AE91C7EE23 for ; Mon, 12 Jun 2023 07:54:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235696AbjFLHy1 (ORCPT ); Mon, 12 Jun 2023 03:54:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235986AbjFLHx5 (ORCPT ); Mon, 12 Jun 2023 03:53:57 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C00AC1700 for ; Mon, 12 Jun 2023 00:53:07 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5162d2373cdso7259641a12.3 for ; Mon, 12 Jun 2023 00:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686556330; x=1689148330; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2OO0dwo12B/hkpE0cRnOkjAE+WFoL2CLbbQ1Uo/g99Y=; b=G3mDIWBcQkegVPWJp21E+OZ/L7WfFTePQqQQEIn6Xucze198hfwtMq7vMPmaEM+wZt fvjQEwrvqdajUNcC4OKDxBwJGII1PJmsds4XocJ9k8lYopr/kg6lXjgnOuK8qBg970nC TZ8BOzWtHbi5M9dHSwlF4WkFqa/VPiihZ7Atm36CbM/aGdDDrQ6Khf9zmesJPFi2OoVM D3R5qtJ0Mnknfq1wMGA5PvsQAbFzCCxg61XNMOT65uNxIvj+FlU/DaEJwAyi2OIO9e3X A8D6pOn3ESvTwoaOtl2hi6GBaEb7yOKAMk+HOWQXeyACs17lP4ldWU7EsihNeXP8Cby/ jNAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686556330; x=1689148330; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2OO0dwo12B/hkpE0cRnOkjAE+WFoL2CLbbQ1Uo/g99Y=; b=Tu/tTaIPNnlkOfuucvL9j/+EXxsDD2OU4qe9yYP3b55tsmQCn5XfwrTwrh/o5rqIhv fcN2rOgg0HCoXt9WxzvV2PyfG1bMx/9kIOwKsRipKZWkFuPpMT65DD9H5KyEoCzoodow 5CBYqsKAjilTq55w72v9mb3If6lJhaEIUojcuY/fmk9j+CGpbDlt3ZTm/bvA7frY+0b+ xmhTUyEXATmBjd6nTQRuDUz6ZJmImkXiObhjW05Um4Q2cr8XTsAEy8W0RXxurZW5cwRZ zTwZSNwemTvmzpdql3Z8/32qDG2UxpSM3+UXBYD/1rteGv3JCS4M3xAMlhlxxk/8llAQ 4ZYg== X-Gm-Message-State: AC+VfDxqz03Q17xiIEthlbcPOKLhVsGMpWShsiWpwK2gLOg6v9gak+L5 SNFVLvpo1a4PZfSynkMKKhdRp1gtO8wnc/d53o8= X-Google-Smtp-Source: ACHHUZ55O0TXsN7bgfQJqIq0U5Dm5VBwoIPhqV2RZ3vfaQwQz9KqPsdfyERsHjYYwJawx4fMJJop+Q== X-Received: by 2002:a17:906:fe0a:b0:973:fe5d:ef71 with SMTP id wy10-20020a170906fe0a00b00973fe5def71mr8821085ejb.14.1686554255496; Mon, 12 Jun 2023 00:17:35 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id lj20-20020a170906f9d400b0094f23480619sm4828553ejb.172.2023.06.12.00.17.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jun 2023 00:17:35 -0700 (PDT) Message-ID: <4e30870d-86e2-8536-8e0d-aab4ce5027d2@linaro.org> Date: Mon, 12 Jun 2023 09:17:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v12 1/2] spi: add loongson spi bindings Content-Language: en-US To: zhuyinbo , Mark Brown , Rob Herring , Krzysztof Kozlowski , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jianmin Lv , wanghongliang@loongson.cn, Liu Peibao , loongson-kernel@lists.loongnix.cn References: <20230608072819.25930-1-zhuyinbo@loongson.cn> <20230608072819.25930-2-zhuyinbo@loongson.cn> <6ebed84c-2b42-c981-7b3f-e71cc88e4c2c@linaro.org> <4bf747c4-b767-b20c-e00f-724b50f44edb@loongson.cn> <6bfc2a22-6901-0858-7b90-bc4c52c66810@linaro.org> <11ca2b90-544d-18c2-fb15-7909ca60507f@linaro.org> <9c94397d-1e31-02fa-bdbe-af888c72eac4@loongson.cn> <657f8d19-de83-8be6-4a9d-5f13b1df7383@linaro.org> <84ccf4cc-072d-adbf-0361-95ceae13f333@linaro.org> <5d060cac-ff28-60e9-98a8-f2bd4d378455@loongson.cn> From: Krzysztof Kozlowski In-Reply-To: <5d060cac-ff28-60e9-98a8-f2bd4d378455@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/06/2023 09:13, zhuyinbo wrote: > > > 在 2023/6/10 上午12:45, Krzysztof Kozlowski 写道: >> On 09/06/2023 05:13, zhuyinbo wrote: >>> >>> >>> 在 2023/6/8 下午9:26, Krzysztof Kozlowski 写道: >>>> On 08/06/2023 14:10, zhuyinbo wrote: >>>>> >>>>> >>>>> 在 2023/6/8 下午7:45, Krzysztof Kozlowski 写道: >>>>>> On 08/06/2023 13:42, zhuyinbo wrote: >>>>>>> --- a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml >>>>>>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml >>>>>>> @@ -16,6 +16,7 @@ properties: >>>>>>> compatible: >>>>>>> enum: >>>>>>> - loongson,ls2k1000-spi >>>>>>> + - loongson,ls2k0500-spi >>>>>> >>>>>> Aren't they compatible? >>>>>> >>>>> >>>>> >>>>> Are you saying that the spi driver is compatible with 2k0500 ? >>>> >>>> Didn't you say this through 11 previous revisions? >>> >>> >>> Yes, did I understand your meaning incorrectly ? >> >> If they are compatible, then they are not part of one enum. They could >> not be as this would easily fail in testing of your DTS. >> > > > The "loongson,ls2k0500-spi" wasn't a compatible in previous version and > I will add "loongson,ls2k0500-spi" as a compatible in spi driver and > added it as a part of the one enum in dt-binding. No, because you claimed - if I understood correctly - that they are compatible. Don't add fake entries to the driver. Best regards, Krzysztof