Re: [PATCH v5 2/2] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board

[Tessolve Upstream <tessolveupstream@gmail.com>]

On 04/11/25 19:57, Konrad Dybcio wrote:
> On 11/4/25 1:51 PM, Sudarshan Shetty wrote:
>> Introduce the device tree support for the QCS615-based talos-evk
>> platform, which follows the SMARC (Smart Mobility ARChitecture)
>> standard. The platform is composed of two main hardware
>> components: the talos-evk-som and the talos-evk carrier board.
> 
> How is the carrier board a separate entity from the "talos-evk.dts"?

The talos-evk platform follows a modular SoM + carrier design.
In our current implementation:
talos-evk-som.dtsi — describes SoM-specific components.
talos-evk-cb.dtsi — represents the carrier board and includes the
SoM file, adding carrier-specific interfaces (micro SD, power button etc.).
talos-evk.dts — includes both the SoM and CB DTSIs and enables HDMI 
display configuration.
talos-evk-lvds.dts — also includes both the SoM and CB DTSIs but enables 
LVDS instead of HDMI.

HDMI and LVDS share the same DSI output and cannot be used simultaneously.
Therefore, we provide separate top-level DTS files (talos-evk.dts for HDMI
and talos-evk-lvds.dts for LVDS), while keeping common board
logic in talos-evk-cb.dtsi.

Hence, layer looks as below:

talos-evk-som.dtsi
├── talos-evk-cb.dtsi (includes som)
│    ├── talos-evk.dts (HDMI)
│    └── talos-evk-lvds.dts (LVDS)

This ensures modularity, and properly models mutually exclusive display
configurations.
> 
> [...]
> 
>> +&mdss_dp_phy {
>> +	vdda-phy-supply = <&vreg_l11a>;
>> +	vdda-pll-supply = <&vreg_l5a>;
>> +	status = "okay";
> 
> Please apply a consistent \n before status

okay, will update in v6 patch.
> 
> [...]
> 
>> +		ports {
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +
>> +			port@0 {
>> +				reg = <0>;
>> +				adv7535_in: endpoint {
> 
> and between the last property and the following subnode
> 
okay, will update in v6 patch.
> Konrad
> 
>> +					remote-endpoint = <&mdss_dsi0_out>;
>> +				};
>> +			};
>> +
>> +			port@1 {
>> +				reg = <1>;
>> +				adv7535_out: endpoint {
>> +					remote-endpoint = <&hdmi_con_out>;
>> +				};
>> +			};
>> +		};
>> +	};
>> +};