From: Hans de Goede <hdegoede@redhat.com>
To: "Limonciello, Mario" <Mario.Limonciello@dell.com>,
Divya Bharathi <divya27392@gmail.com>,
"dvhart@infradead.org" <dvhart@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"Bharathi, Divya" <Divya.Bharathi@Dell.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
mark gross <mgross@linux.intel.com>,
"Ksr, Prasanth" <Prasanth.Ksr@dell.com>
Subject: Re: [PATCH v6] Introduce support for Systems Management Driver over WMI for Dell Systems
Date: Mon, 26 Oct 2020 16:36:13 +0100 [thread overview]
Message-ID: <4e415aea-d855-e8a5-0b61-785b67efeb59@redhat.com> (raw)
In-Reply-To: <DM6PR19MB2636A7CAF82D8CB7DEEF7B2DFA190@DM6PR19MB2636.namprd19.prod.outlook.com>
Hi,
On 10/26/20 4:25 PM, Limonciello, Mario wrote:
>>> +
>>> + print_hex_dump_bytes("set attribute data: ", DUMP_PREFIX_NONE, buffer,
>> buffer_size);
>>
>> This seems to be a debugging left-over?
>
> Yes it was for debugging, but its configurable to turn on by dynamic
> debug as I can tell. Is that not correct?
Since it does not have debug in its name I sorta assumed it would
always do the print. But you are right, this is a shorthand macro
for print_hex_dump_debug() (which takes a few more arguments), so
this only dumps the buffer when debugging is enabled.
IOW keeping this "as is" is fine, sorry for the noise.
Regards,
Has
next prev parent reply other threads:[~2020-10-26 15:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 8:26 [PATCH v6] Introduce support for Systems Management Driver over WMI for Dell Systems Divya Bharathi
2020-10-26 14:37 ` Hans de Goede
2020-10-26 15:25 ` Limonciello, Mario
2020-10-26 15:36 ` Hans de Goede [this message]
2020-10-26 15:39 ` Limonciello, Mario
2020-10-26 15:41 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e415aea-d855-e8a5-0b61-785b67efeb59@redhat.com \
--to=hdegoede@redhat.com \
--cc=Divya.Bharathi@Dell.com \
--cc=Mario.Limonciello@dell.com \
--cc=Prasanth.Ksr@dell.com \
--cc=andy.shevchenko@gmail.com \
--cc=divya27392@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox