From: Marc Zyngier <maz@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
tglx@linutronix.de
Subject: Re: [PATCH] irqdomain: remove debugfs_file from struct irq_domain
Date: Wed, 17 Feb 2021 20:02:24 +0000 [thread overview]
Message-ID: <4e4d0479b935e60a53f75ef534086476@kernel.org> (raw)
In-Reply-To: <20210217195717.13727-1-michael@walle.cc>
On 2021-02-17 19:57, Michael Walle wrote:
> Hi Greg,
>
>> There's no need to keep around a dentry pointer to a simple file that
>> debugfs itself can look up when we need to remove it from the system.
>> So simplify the code by deleting the variable and cleaning up the
>> logic
>> around the debugfs file.
>
> This will generate the following oops on my board (arm64,
> freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts). In debugfs_lookup()
> debugfs_mount is NULL.
That's odd. I gave it a go yesterday, and nothing blew up.
Which makes me wonder whether I had the debug stuff enabled
the first place...
I've dropped the patch from -next for now until I figure it out
(probably tomorrow).
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2021-02-17 20:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 14:36 [PATCH] irqdomain: remove debugfs_file from struct irq_domain Greg Kroah-Hartman
2021-02-16 15:36 ` [irqchip: irq/irqchip-next] irqdomain: Remove " irqchip-bot for Greg Kroah-Hartman
2021-02-17 19:57 ` [PATCH] irqdomain: remove " Michael Walle
2021-02-17 20:02 ` Marc Zyngier [this message]
2021-02-17 20:10 ` Michael Walle
2021-02-17 21:50 ` Marc Zyngier
2021-02-17 22:21 ` Michael Walle
2021-02-18 7:16 ` Greg KH
2021-02-18 7:31 ` Greg KH
2021-02-18 8:27 ` Michael Walle
2021-02-18 8:38 ` Greg KH
2021-02-18 8:47 ` Marc Zyngier
2021-02-18 8:54 ` Greg KH
2021-02-18 9:04 ` Marc Zyngier
2021-02-18 9:38 ` Greg KH
2021-02-18 10:39 ` Marc Zyngier
2021-02-18 8:52 ` Greg KH
2021-02-18 9:04 ` Michael Walle
2021-02-18 9:08 ` Marc Zyngier
2021-02-18 8:40 ` Greg KH
2021-02-18 8:46 ` Michael Walle
2021-02-18 11:43 ` [irqchip: irq/irqchip-next] irqdomain: Remove " irqchip-bot for Greg Kroah-Hartman
2021-03-08 20:25 ` irqchip-bot for Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e4d0479b935e60a53f75ef534086476@kernel.org \
--to=maz@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox