* Re: [PATCH v1] platform/x86: intel/pmc: Add Alder Lake N support to PMC core driver [not found] <20220615002751.3371730-1-gayatri.kammela@linux.intel.com> @ 2022-06-15 1:42 ` Rajneesh Bhardwaj 2022-06-22 17:55 ` Kammela, Gayatri 2022-06-22 10:23 ` Hans de Goede 1 sibling, 1 reply; 5+ messages in thread From: Rajneesh Bhardwaj @ 2022-06-15 1:42 UTC (permalink / raw) To: Gayatri Kammela Cc: Hans de Goede, markgross, platform-driver-x86, linux-kernel, Srinivas Pandruvada, Andy Shevchenko, David E . Box Is RocketLake the same as Alder Lake N? Otherwise, it looks pretty straight forward. Reviewed-by: Rajneesh Bhardwaj <irenic.rajneesh@gmail.com> On Tue, Jun 14, 2022 at 8:28 PM Gayatri Kammela <gayatri.kammela@linux.intel.com> wrote: > > Add Alder Lake N (ADL-N) to the list of the platforms that Intel's > PMC core driver supports. RocketLake reuses all the TigerLake PCH IPs. > > Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: David E. Box <david.e.box@linux.intel.com> > Signed-off-by: Gayatri Kammela <gayatri.kammela@linux.intel.com> > --- > drivers/platform/x86/intel/pmc/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/intel/pmc/core.c > index 40183bda7894..a1fe1e0dcf4a 100644 > --- a/drivers/platform/x86/intel/pmc/core.c > +++ b/drivers/platform/x86/intel/pmc/core.c > @@ -1911,6 +1911,7 @@ static const struct x86_cpu_id intel_pmc_core_ids[] = { > X86_MATCH_INTEL_FAM6_MODEL(ATOM_TREMONT_L, &icl_reg_map), > X86_MATCH_INTEL_FAM6_MODEL(ROCKETLAKE, &tgl_reg_map), > X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_L, &tgl_reg_map), > + X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_N, &tgl_reg_map), > X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE, &adl_reg_map), > X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE_P, &tgl_reg_map), > {} > > base-commit: b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3 > -- > 2.25.1 > -- Thanks, Rajneesh ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] platform/x86: intel/pmc: Add Alder Lake N support to PMC core driver 2022-06-15 1:42 ` [PATCH v1] platform/x86: intel/pmc: Add Alder Lake N support to PMC core driver Rajneesh Bhardwaj @ 2022-06-22 17:55 ` Kammela, Gayatri 0 siblings, 0 replies; 5+ messages in thread From: Kammela, Gayatri @ 2022-06-22 17:55 UTC (permalink / raw) To: Rajneesh Bhardwaj Cc: Hans de Goede, markgross, platform-driver-x86, linux-kernel, Srinivas Pandruvada, Andy Shevchenko, David E . Box On 6/14/2022 6:42 PM, Rajneesh Bhardwaj wrote: > Is RocketLake the same as Alder Lake N? Otherwise, it looks pretty > straight forward. > > Reviewed-by: Rajneesh Bhardwaj <irenic.rajneesh@gmail.com> Thank you Rajneesh! I fixed the typo and posted v2. > > > On Tue, Jun 14, 2022 at 8:28 PM Gayatri Kammela > <gayatri.kammela@linux.intel.com> wrote: >> Add Alder Lake N (ADL-N) to the list of the platforms that Intel's >> PMC core driver supports. RocketLake reuses all the TigerLake PCH IPs. >> >> Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com> >> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> Cc: David E. Box <david.e.box@linux.intel.com> >> Signed-off-by: Gayatri Kammela <gayatri.kammela@linux.intel.com> >> --- >> drivers/platform/x86/intel/pmc/core.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/intel/pmc/core.c >> index 40183bda7894..a1fe1e0dcf4a 100644 >> --- a/drivers/platform/x86/intel/pmc/core.c >> +++ b/drivers/platform/x86/intel/pmc/core.c >> @@ -1911,6 +1911,7 @@ static const struct x86_cpu_id intel_pmc_core_ids[] = { >> X86_MATCH_INTEL_FAM6_MODEL(ATOM_TREMONT_L, &icl_reg_map), >> X86_MATCH_INTEL_FAM6_MODEL(ROCKETLAKE, &tgl_reg_map), >> X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_L, &tgl_reg_map), >> + X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_N, &tgl_reg_map), >> X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE, &adl_reg_map), >> X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE_P, &tgl_reg_map), >> {} >> >> base-commit: b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3 >> -- >> 2.25.1 >> > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] platform/x86: intel/pmc: Add Alder Lake N support to PMC core driver [not found] <20220615002751.3371730-1-gayatri.kammela@linux.intel.com> 2022-06-15 1:42 ` [PATCH v1] platform/x86: intel/pmc: Add Alder Lake N support to PMC core driver Rajneesh Bhardwaj @ 2022-06-22 10:23 ` Hans de Goede 2022-06-22 17:56 ` Kammela, Gayatri 1 sibling, 1 reply; 5+ messages in thread From: Hans de Goede @ 2022-06-22 10:23 UTC (permalink / raw) To: Gayatri Kammela Cc: irenic.rajneesh, markgross, platform-driver-x86, linux-kernel, Srinivas Pandruvada, Andy Shevchenko, David E . Box Hi, On 6/15/22 02:27, Gayatri Kammela wrote: > Add Alder Lake N (ADL-N) to the list of the platforms that Intel's > PMC core driver supports. RocketLake reuses all the TigerLake PCH IPs. > > Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: David E. Box <david.e.box@linux.intel.com> > Signed-off-by: Gayatri Kammela <gayatri.kammela@linux.intel.com> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/intel/pmc/core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/intel/pmc/core.c > index 40183bda7894..a1fe1e0dcf4a 100644 > --- a/drivers/platform/x86/intel/pmc/core.c > +++ b/drivers/platform/x86/intel/pmc/core.c > @@ -1911,6 +1911,7 @@ static const struct x86_cpu_id intel_pmc_core_ids[] = { > X86_MATCH_INTEL_FAM6_MODEL(ATOM_TREMONT_L, &icl_reg_map), > X86_MATCH_INTEL_FAM6_MODEL(ROCKETLAKE, &tgl_reg_map), > X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_L, &tgl_reg_map), > + X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_N, &tgl_reg_map), > X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE, &adl_reg_map), > X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE_P, &tgl_reg_map), > {} > > base-commit: b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] platform/x86: intel/pmc: Add Alder Lake N support to PMC core driver 2022-06-22 10:23 ` Hans de Goede @ 2022-06-22 17:56 ` Kammela, Gayatri 2022-06-27 7:46 ` Hans de Goede 0 siblings, 1 reply; 5+ messages in thread From: Kammela, Gayatri @ 2022-06-22 17:56 UTC (permalink / raw) To: Hans de Goede Cc: irenic.rajneesh, markgross, platform-driver-x86, linux-kernel, Srinivas Pandruvada, Andy Shevchenko, David E . Box On 6/22/2022 3:23 AM, Hans de Goede wrote: > Hi, > > On 6/15/22 02:27, Gayatri Kammela wrote: >> Add Alder Lake N (ADL-N) to the list of the platforms that Intel's >> PMC core driver supports. RocketLake reuses all the TigerLake PCH IPs. >> >> Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com> >> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> Cc: David E. Box <david.e.box@linux.intel.com> >> Signed-off-by: Gayatri Kammela <gayatri.kammela@linux.intel.com> > Thank you for your patch, I've applied this patch to my review-hans > branch: > https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans > > Note it will show up in my review-hans branch once I've pushed my > local branch there, which might take a while. > > Once I've run some tests on this branch the patches there will be > added to the platform-drivers-x86/for-next branch and eventually > will be included in the pdx86 pull-request to Linus for the next > merge-window. > > Regards, > > Hans Thank you Hans! I have sent v2 fixing the typo. > >> --- >> drivers/platform/x86/intel/pmc/core.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/intel/pmc/core.c >> index 40183bda7894..a1fe1e0dcf4a 100644 >> --- a/drivers/platform/x86/intel/pmc/core.c >> +++ b/drivers/platform/x86/intel/pmc/core.c >> @@ -1911,6 +1911,7 @@ static const struct x86_cpu_id intel_pmc_core_ids[] = { >> X86_MATCH_INTEL_FAM6_MODEL(ATOM_TREMONT_L, &icl_reg_map), >> X86_MATCH_INTEL_FAM6_MODEL(ROCKETLAKE, &tgl_reg_map), >> X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_L, &tgl_reg_map), >> + X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_N, &tgl_reg_map), >> X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE, &adl_reg_map), >> X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE_P, &tgl_reg_map), >> {} >> >> base-commit: b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] platform/x86: intel/pmc: Add Alder Lake N support to PMC core driver 2022-06-22 17:56 ` Kammela, Gayatri @ 2022-06-27 7:46 ` Hans de Goede 0 siblings, 0 replies; 5+ messages in thread From: Hans de Goede @ 2022-06-27 7:46 UTC (permalink / raw) To: Kammela, Gayatri Cc: irenic.rajneesh, markgross, platform-driver-x86, linux-kernel, Srinivas Pandruvada, Andy Shevchenko, David E . Box Hi, On 6/22/22 19:56, Kammela, Gayatri wrote: > On 6/22/2022 3:23 AM, Hans de Goede wrote: > >> Hi, >> >> On 6/15/22 02:27, Gayatri Kammela wrote: >>> Add Alder Lake N (ADL-N) to the list of the platforms that Intel's >>> PMC core driver supports. RocketLake reuses all the TigerLake PCH IPs. >>> >>> Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com> >>> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >>> Cc: David E. Box <david.e.box@linux.intel.com> >>> Signed-off-by: Gayatri Kammela <gayatri.kammela@linux.intel.com> >> Thank you for your patch, I've applied this patch to my review-hans >> branch: >> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans >> >> Note it will show up in my review-hans branch once I've pushed my >> local branch there, which might take a while. >> >> Once I've run some tests on this branch the patches there will be >> added to the platform-drivers-x86/for-next branch and eventually >> will be included in the pdx86 pull-request to Linus for the next >> merge-window. >> >> Regards, >> >> Hans > Thank you Hans! I have sent v2 fixing the typo. Next time please send newer versions before I apply them. I've updated the version in my review-hans and fixes branches now and done a forced push of those branches. Regards, Hans >> >>> --- >>> drivers/platform/x86/intel/pmc/core.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/intel/pmc/core.c >>> index 40183bda7894..a1fe1e0dcf4a 100644 >>> --- a/drivers/platform/x86/intel/pmc/core.c >>> +++ b/drivers/platform/x86/intel/pmc/core.c >>> @@ -1911,6 +1911,7 @@ static const struct x86_cpu_id intel_pmc_core_ids[] = { >>> X86_MATCH_INTEL_FAM6_MODEL(ATOM_TREMONT_L, &icl_reg_map), >>> X86_MATCH_INTEL_FAM6_MODEL(ROCKETLAKE, &tgl_reg_map), >>> X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_L, &tgl_reg_map), >>> + X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE_N, &tgl_reg_map), >>> X86_MATCH_INTEL_FAM6_MODEL(ALDERLAKE, &adl_reg_map), >>> X86_MATCH_INTEL_FAM6_MODEL(RAPTORLAKE_P, &tgl_reg_map), >>> {} >>> >>> base-commit: b13baccc3850ca8b8cccbf8ed9912dbaa0fdf7f3 > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-06-27 7:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220615002751.3371730-1-gayatri.kammela@linux.intel.com>
2022-06-15 1:42 ` [PATCH v1] platform/x86: intel/pmc: Add Alder Lake N support to PMC core driver Rajneesh Bhardwaj
2022-06-22 17:55 ` Kammela, Gayatri
2022-06-22 10:23 ` Hans de Goede
2022-06-22 17:56 ` Kammela, Gayatri
2022-06-27 7:46 ` Hans de Goede
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox