From: Jiri Slaby <jirislaby@kernel.org>
To: Florian Eckert <fe@dev.tdt.de>, kernel test robot <lkp@intel.com>
Cc: u.kleine-koenig@pengutronix.de, gregkh@linuxfoundation.org,
pavel@ucw.cz, lee@kernel.org, oe-kbuild-all@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
Eckert.Florian@googlemail.com
Subject: Re: [PATCH v5 2/2] trigger: ledtrig-tty: add additional modes
Date: Wed, 22 Feb 2023 08:16:04 +0100 [thread overview]
Message-ID: <4e5aeac3-2a99-8fd5-cf1d-a35870ecd807@kernel.org> (raw)
In-Reply-To: <deee30ef43e397233dd15d11b86ae91a@dev.tdt.de>
On 22. 02. 23, 7:07, Florian Eckert wrote:
>
>
> On 2023-02-22 01:02, kernel test robot wrote:
>> Hi Florian,
>>
>> Thank you for the patch! Perhaps something to improve:
>>
>> [auto build test WARNING on tty/tty-testing]
>> [also build test WARNING on tty/tty-next tty/tty-linus
>> staging/staging-testing staging/staging-next staging/staging-linus
>> pavel-leds/for-next linus/master v6.2 next-20230221]
>> [If your patch is applied to the wrong git tree, kindly drop us a note.
>> And when submitting patch, we suggest to use '--base' as documented in
>> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>>
>> url:
>> https://github.com/intel-lab-lkp/linux/commits/Florian-Eckert/tty-new-helper-function-tty_get_mget/20230221-162126
>> base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
>> tty-testing
>> patch link:
>> https://lore.kernel.org/r/20230221081901.15557-3-fe%40dev.tdt.de
>> patch subject: [PATCH v5 2/2] trigger: ledtrig-tty: add additional modes
>> reproduce:
>> #
>> https://github.com/intel-lab-lkp/linux/commit/445b7555bccd279bf106995ee42f5dbef2e97c8b
>> git remote add linux-review
>> https://github.com/intel-lab-lkp/linux
>> git fetch --no-tags linux-review
>> Florian-Eckert/tty-new-helper-function-tty_get_mget/20230221-162126
>> git checkout 445b7555bccd279bf106995ee42f5dbef2e97c8b
>> make menuconfig
>> # enable CONFIG_COMPILE_TEST, CONFIG_WARN_MISSING_DOCUMENTS,
>> CONFIG_WARN_ABI_ERRORS
>> make htmldocs
>>
>> If you fix the issue, kindly add following tag where applicable
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Link:
>> https://lore.kernel.org/oe-kbuild-all/202302220740.2RKDHnof-lkp@intel.com/
>>
>> All warnings (new ones prefixed by >>):
>>
>>>> Documentation/ABI/testing/sysfs-class-led-trigger-tty:9: WARNING:
>>>> Unexpected indentation.
>>>> Documentation/ABI/testing/sysfs-class-led-trigger-tty:9: WARNING:
>>>> Block quote ends without a blank line; unexpected unindent.
>>
>> vim +9 Documentation/ABI/testing/sysfs-class-led-trigger-tty
>>
>> > 9 Date: January 2023
>
> I apologies for the question! But I don't know what the test buildbot
> here wants from me.
> I've looked at the other files and I can't find anything that stands out.
sphinx is always misleading.
It's the indentation of all "LED on if ...".
--
js
suse labs
next prev parent reply other threads:[~2023-02-22 7:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 8:18 [PATCH v5 0/2] leds: ledtrig-tty: add tty_led_mode xtension Florian Eckert
2023-02-21 8:19 ` [PATCH v5 1/2] tty: new helper function tty_get_mget Florian Eckert
2023-02-21 8:19 ` [PATCH v5 2/2] trigger: ledtrig-tty: add additional modes Florian Eckert
2023-02-22 0:02 ` kernel test robot
2023-02-22 6:07 ` Florian Eckert
2023-02-22 7:16 ` Jiri Slaby [this message]
2023-02-22 7:21 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e5aeac3-2a99-8fd5-cf1d-a35870ecd807@kernel.org \
--to=jirislaby@kernel.org \
--cc=Eckert.Florian@googlemail.com \
--cc=fe@dev.tdt.de \
--cc=gregkh@linuxfoundation.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox