The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Falcon, Thomas" <thomas.falcon@intel.com>
To: "linux-perf-users@vger.kernel.org" <linux-perf-users@vger.kernel.org>
Cc: "james.clark@linaro.org" <james.clark@linaro.org>,
	"alexander.shishkin@linux.intel.com"
	<alexander.shishkin@linux.intel.com>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"acme@kernel.org" <acme@kernel.org>,
	"namhyung@kernel.org" <namhyung@kernel.org>,
	"jolsa@kernel.org" <jolsa@kernel.org>,
	"dapeng1.mi@linux.intel.com" <dapeng1.mi@linux.intel.com>,
	"Rogers, Ian" <irogers@google.com>,
	"Hunter, Adrian" <adrian.hunter@intel.com>
Subject: Re: [PATCH 0/2 v2] perf: Fix missing branch counter information in script and annotate
Date: Mon, 11 May 2026 18:05:22 +0000	[thread overview]
Message-ID: <4e61558361aa6d7d6a51b376109063f2aa004c67.camel@intel.com> (raw)
In-Reply-To: <20260429152917.178803-1-thomas.falcon@intel.com>

On Wed, 2026-04-29 at 10:29 -0500, Thomas Falcon wrote:
> This series fixes two issues related to branch counter (br_cntr)
> display in perf.
> 
> The first patch fixes a missing '+' indicator in 'perf script'
> output.
> The '+' suffix is used to signal that event occurrences may have been
> lost due to branch counter overflow.
> 
> The second patch fixes a regression in 'perf annotate' TUI mode where
> the Branch Count column was never displayed. The check for whether to
> enable branch counter display was performed before events were
> processed
> and the counter data was populated, so the condition was never
> satisfied.
> Moving the check to after event processing resolves this.

Ping.

Thanks,
Tom
> 
> v2: Added a cover letter and expanded commit message for patch 1/2.
>     Patch 2/2 was missing some conditional checks to enable branch
> counter
>     display, which have been added back.
>     
> 
> Dapeng Mi (1):
>   perf script: Fix missing '+' indicator when branch counter reaches
>     upper limit
> 
> Thomas Falcon (1):
>   perf annotate: Fix missing branch counter column in TUI mode
> 
>  tools/perf/builtin-annotate.c | 9 +++++----
>  tools/perf/builtin-script.c   | 8 ++++++--
>  2 files changed, 11 insertions(+), 6 deletions(-)
> 


           reply	other threads:[~2026-05-11 18:05 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20260429152917.178803-1-thomas.falcon@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e61558361aa6d7d6a51b376109063f2aa004c67.camel@intel.com \
    --to=thomas.falcon@intel.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox