The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: lumingyindetect <lumingyindetect@126.com>
To: "Markus Elfring" <Markus.Elfring@web.de>
Cc: linux-serial@vger.kernel.org, kernel-janitors@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Jiri Slaby" <jirislaby@kernel.org>
Subject: Re:Re: [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250_probe()
Date: Fri, 26 Apr 2024 21:01:52 +0800 (CST)	[thread overview]
Message-ID: <4e6966e0.a07e.18f1a7f7863.Coremail.lumingyindetect@126.com> (raw)
In-Reply-To: <42c5d1f0-d16a-483b-8bb1-4c5768aa3a8c@web.de>

Dear Markus,<br/><br/>Thank you for your patient guidance and advice! This is my first time submitting a patch, and I haven't fully understood the meaning of "add a commit subject for this tag" yet. Could you please provide some examples or guidance on how to add it? I appreciate your help!<br/><br/>Best regards,<br/>LuMingYin
At 2024-04-26 20:28:43, "Markus Elfring" <Markus.Elfring@web.de> wrote:
>…
>> In the lpss8250_probe() function, I added a label named "free_irq_vectors" to release the dynamically allocated memory region pointed to by the variable pdev, and replaced the two return statements mentioned above with goto statements to this label.
>
>* Please improve the word wrapping according to line length preferences
>  for change descriptions.
>
>* Please choose corresponding imperative wordings.
>
>
>> Fixes: e88c4cfcb7b888ac374916806f86c17d8ecaeb67
>
>Please add a commit subject for this tag.
>
>
>> Signed-off-by: LuMingYin <11570291+yin-luming@user.noreply.gitee.com>
>
>I find the author email addresses suspicious according to the Developer's Certificate of Origin.
>https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9-rc5#n398
>
>Would other email addresses be more appropriate for desired patch communication?
>
>Regards,
>Markus

  reply	other threads:[~2024-04-26 13:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-26 11:47 [PATCH] serial: 8250_lpss: Fix memory leak in lpss8250_probe() lumingyindetect
2024-04-26 12:28 ` Markus Elfring
2024-04-26 13:01   ` lumingyindetect [this message]
2024-04-26 13:51     ` Markus Elfring
2024-04-26 15:07     ` [PATCH] " Christian Heusel
2024-04-26 13:45 ` Ilpo Järvinen
2024-04-26 13:53 ` Dan Carpenter
2024-04-26 14:45   ` Andy Shevchenko
2024-04-26 15:32     ` Dan Carpenter
2024-04-26 15:37       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e6966e0.a07e.18f1a7f7863.Coremail.lumingyindetect@126.com \
    --to=lumingyindetect@126.com \
    --cc=Markus.Elfring@web.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox