From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7473C48BE8 for ; Tue, 15 Jun 2021 02:52:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86989613C2 for ; Tue, 15 Jun 2021 02:52:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230261AbhFOCyZ (ORCPT ); Mon, 14 Jun 2021 22:54:25 -0400 Received: from out30-45.freemail.mail.aliyun.com ([115.124.30.45]:36704 "EHLO out30-45.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229649AbhFOCyY (ORCPT ); Mon, 14 Jun 2021 22:54:24 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=joseph.qi@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0UcSuIj8_1623721826; Received: from B-D1K7ML85-0059.local(mailfrom:joseph.qi@linux.alibaba.com fp:SMTPD_---0UcSuIj8_1623721826) by smtp.aliyun-inc.com(127.0.0.1); Tue, 15 Jun 2021 09:50:26 +0800 Subject: Re: [PATCH] ocfs2: remove redundant initialization of variable ret To: Colin King , Mark Fasheh , Joel Becker , ocfs2-devel@oss.oracle.com Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, akpm References: <20210613135148.74658-1-colin.king@canonical.com> From: Joseph Qi Message-ID: <4e700d47-6973-4db3-a103-e3d8373ec7c2@linux.alibaba.com> Date: Tue, 15 Jun 2021 09:50:26 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210613135148.74658-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/13/21 9:51 PM, Colin King wrote: > From: Colin Ian King > > The variable ret is being initialized with a value that is never read, the > assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Acked-by: Joseph Qi > --- > fs/ocfs2/cluster/nodemanager.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ocfs2/cluster/nodemanager.c b/fs/ocfs2/cluster/nodemanager.c > index bb82e6b1ff4e..625c92521416 100644 > --- a/fs/ocfs2/cluster/nodemanager.c > +++ b/fs/ocfs2/cluster/nodemanager.c > @@ -824,7 +824,7 @@ static void __exit exit_o2nm(void) > > static int __init init_o2nm(void) > { > - int ret = -1; > + int ret; > > o2hb_init(); > >