public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ricky WU <ricky_wu@realtek.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
	Thomas Haschka <thomas.haschka@tuwien.ac.at>,
	Bart Van Assche <bvanassche@acm.org>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"James.Bottomley@hansenpartnership.com"
	<James.Bottomley@hansenpartnership.com>,
	"martin.peterson@oracle.com" <martin.peterson@oracle.com>
Subject: RE: mmc0: error -95 doing runtime resume
Date: Thu, 27 Feb 2025 03:19:51 +0000	[thread overview]
Message-ID: <4e7162dfccbe44468f6a452896110cc8@realtek.com> (raw)
In-Reply-To: <CAPDyKFpwZt9rezBhBbe9FeUX1BycD2br6RRTttvAVS_C99=TiQ@mail.gmail.com>

> + Ricky
> 
> On Fri, 21 Feb 2025 at 18:20, Bart Van Assche <bvanassche@acm.org> wrote:
> >
> >
> > On 2/21/25 7:41 AM, Thomas Haschka wrote:
> > > Bug Fix: block: Improve stability of SD cards in Microsoft Surface GO 2 and
> > >               possibly other devices.
> > >
> > >
> > > The commit 65a558f66c308
> > >      block: Improve performance for BLK_MQ_F_BLOCKING drivers
> > >
> > > basically made the use of SD cards in my Microsoft Surface GO 2
> impossible.
> > > The cards do stop functioning after about 15 minutes. Mostly at io
> > > intensive tasks.
> > >
> > > As outlined in https://bugzilla.kernel.org/show_bug.cgi?id=218821
> > > i bisected the problem that yielded an unstable operation of the
> > > cardreader on my Surface GO 2.
> > > I successfully reversed the commit 65a558f66c308 in 6.12.16 using
> > > the attached patch. As I suppose the bug introduced with this commit
> > > might hit other users of sd-cards in similar hardware I suggest this
> > > commit shall be reversed, even if the improved performance might be
> gone.
> >
> > Thank you for having bisected this issue and for having shared the
> > result of the bisection process. This is very useful information.
> >
> > Since the commit mentioned above is about 1.5 years old and has not
> > caused any issues for anyone who is not using an SD card reader, that
> > commit is probably not the root cause of the reported behavior. Are SD
> > cards controlled by the MMC driver? If so, I think the next step is to
> > take a close look at the MMC driver. I have Cc-ed the MMC driver
> maintainer.
> 
> There was another thread [1] where I tried to loop in Ricky Wu, but there was
> no response. I have added him to this tread too.
> 
Hi Ulf,
Because I was waiting for the result that revert 101bd907b424 ("misc: rtsx: judge ASPM Mode to set PETXCFG Reg")
Can fix this issue or not, but I did not see any response...

Hi Thomas,
This issue(this mail thread) and [1] are the same issue?
And this issue only can reproduce on surface go 2?
If so, I need to find correct platform to reproduce this issue on my hand


> For the record, I agree, even if reverting 65a558f66c308 solves the issue, it's
> not the correct fix.
> 
> Unless we can get some help from Ricky, we can try to drop assigning
> "MMC_CAP_AGGRESSIVE_PM" in realtek_init_host() to see if that solves the
> problem. Or if debugfs is enabled, we can disable
> MMC_CAP_AGGRESSIVE_PM for the mmc host via the "caps" debugfs-node.
> 
> Thomas can you try to drop MMC_CAP_AGGRESSIVE_PM and see if that solves
> the problem?
> 
> Kind regards
> Uffe
> 
> [1]
> https://lore.kernel.org/all/CAPDyKFq4-fL3oHeT9phThWQJqzicKeA447WBJUbtc
> KPhdZ2d1A@mail.gmail.com/

  reply	other threads:[~2025-02-27  3:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21 15:41 Patch and bugfix in block/blk-mq.c to regain stability when using various SD Cards and Card Readers Thomas Haschka
2025-02-21 17:20 ` mmc0: error -95 doing runtime resume Bart Van Assche
2025-02-26 12:41   ` Ulf Hansson
2025-02-27  3:19     ` Ricky WU [this message]
2025-02-27 11:52       ` Thomas Haschka
2025-03-12 12:29         ` Ulf Hansson
2025-03-13 10:57           ` Thomas Haschka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e7162dfccbe44468f6a452896110cc8@realtek.com \
    --to=ricky_wu@realtek.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.peterson@oracle.com \
    --cc=thomas.haschka@tuwien.ac.at \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox