Re: [PATCH v2 2/2] scsi: ufs-qcom: Keep core_clk_unipro ON while link is active

hongwus
2020-11-25T02:03:14Z

On 2020-11-24 15:28, Can Guo wrote:
> If we want to disable clocks to save power but still keep the link
> active,
> core_clk_unipro, as same as ref_clk, should not be the one being
> disabled.
>
> Signed-off-by: Can Guo <cang@codeaurora.org>
> ---
> drivers/scsi/ufs/ufs-qcom.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
> index f9d6ef3..70df357 100644
> --- a/drivers/scsi/ufs/ufs-qcom.c
> +++ b/drivers/scsi/ufs/ufs-qcom.c
> @@ -977,6 +977,7 @@ static int ufs_qcom_init(struct ufs_hba *hba)
> struct platform_device *pdev = to_platform_device(dev);
> struct ufs_qcom_host *host;
> struct resource *res;
> + struct ufs_clk_info *clki;
>
> if (strlen(android_boot_dev) && strcmp(android_boot_dev,
> dev_name(dev)))
> return -ENODEV;
> @@ -1075,6 +1076,11 @@ static int ufs_qcom_init(struct ufs_hba *hba)
> }
> }
>
> + list_for_each_entry(clki, &hba->clk_list_head, list) {
> + if (!strcmp(clki->name, "core_clk_unipro"))
> + clki->always_on_while_link_active = true;
> + }
> +
> err = ufs_qcom_init_lane_clks(host);
> if (err)
> goto out_variant_clear;

Reviewed-by: Hongwu Su<hongwus@codeaurora.org>