From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0994BC433E0 for ; Sat, 30 Jan 2021 19:05:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D9B4A64E17 for ; Sat, 30 Jan 2021 19:05:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232119AbhA3TF1 (ORCPT ); Sat, 30 Jan 2021 14:05:27 -0500 Received: from smtprelay0115.hostedemail.com ([216.40.44.115]:44630 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231923AbhA3TF0 (ORCPT ); Sat, 30 Jan 2021 14:05:26 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id BD92F180A7FF9; Sat, 30 Jan 2021 19:04:44 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: guide60_180fe2f275b3 X-Filterd-Recvd-Size: 3853 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf19.hostedemail.com (Postfix) with ESMTPA; Sat, 30 Jan 2021 19:04:43 +0000 (UTC) Message-ID: <4e90351d3b78154d451a39c1a8577b583b8467a7.camel@perches.com> Subject: Re: [PATCH 24/29] reiserfs: Avoid comma separated statements From: Joe Perches To: Jiri Kosina , linux-kernel@vger.kernel.org Cc: reiserfs-devel@vger.kernel.org Date: Sat, 30 Jan 2021 11:04:43 -0800 In-Reply-To: <29b5ea94496d64e7a73af216b01f26d9ff7ac1fe.1598331149.git.joe@perches.com> References: <29b5ea94496d64e7a73af216b01f26d9ff7ac1fe.1598331149.git.joe@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote: > Use semicolons and braces. ping? > Signed-off-by: Joe Perches > --- >  fs/reiserfs/fix_node.c | 36 ++++++++++++++++++++++++------------ >  1 file changed, 24 insertions(+), 12 deletions(-) > > diff --git a/fs/reiserfs/fix_node.c b/fs/reiserfs/fix_node.c > index fefe87e1c099..aea63e67a42b 100644 > --- a/fs/reiserfs/fix_node.c > +++ b/fs/reiserfs/fix_node.c > @@ -235,8 +235,10 @@ static void check_left(struct tree_balance *tb, int h, int cur_free) >   d_size = 0, ih_size = IH_SIZE; >   > >   /* first item may be merge with last item in left neighbor */ > - if (vi->vi_type & VI_TYPE_LEFT_MERGEABLE) > - d_size = -((int)IH_SIZE), ih_size = 0; > + if (vi->vi_type & VI_TYPE_LEFT_MERGEABLE) { > + d_size = -((int)IH_SIZE); > + ih_size = 0; > + } >   > >   tb->lnum[0] = 0; >   for (i = 0; i < vn->vn_nr_item; > @@ -321,8 +323,10 @@ static void check_right(struct tree_balance *tb, int h, int cur_free) >   d_size = 0, ih_size = IH_SIZE; >   > >   /* last item may be merge with first item in right neighbor */ > - if (vi->vi_type & VI_TYPE_RIGHT_MERGEABLE) > - d_size = -(int)IH_SIZE, ih_size = 0; > + if (vi->vi_type & VI_TYPE_RIGHT_MERGEABLE) { > + d_size = -(int)IH_SIZE; > + ih_size = 0; > + } >   > >   tb->rnum[0] = 0; >   for (i = vn->vn_nr_item - 1; i >= 0; > @@ -1534,8 +1538,10 @@ static int ip_check_balance(struct tree_balance *tb, int h) >   nver1 = get_num_ver(vn->vn_mode, tb, h, >   0, -1, 0, -1, >   snum012 + NOTHING_SHIFT_FLOW, FLOW); > - if (nver > nver1) > - nset = NOTHING_SHIFT_FLOW, nver = nver1; > + if (nver > nver1) { > + nset = NOTHING_SHIFT_FLOW; > + nver = nver1; > + } >   } >   > >   /* > @@ -1559,8 +1565,10 @@ static int ip_check_balance(struct tree_balance *tb, int h) >   ((tb->lbytes != -1) ? 1 : 0), >   tb->lbytes, 0, -1, >   snum012 + LEFT_SHIFT_FLOW, FLOW); > - if (lnver > lnver1) > - lset = LEFT_SHIFT_FLOW, lnver = lnver1; > + if (lnver > lnver1) { > + lset = LEFT_SHIFT_FLOW; > + lnver = lnver1; > + } >   } >   > >   /* > @@ -1590,8 +1598,10 @@ static int ip_check_balance(struct tree_balance *tb, int h) >   tb->rbytes, >   snum012 + RIGHT_SHIFT_FLOW, FLOW); >   > > - if (rnver > rnver1) > - rset = RIGHT_SHIFT_FLOW, rnver = rnver1; > + if (rnver > rnver1) { > + rset = RIGHT_SHIFT_FLOW; > + rnver = rnver1; > + } >   } >   > >   /* > @@ -1622,8 +1632,10 @@ static int ip_check_balance(struct tree_balance *tb, int h) >   ((tb->rbytes != -1) ? 1 : 0)), >   tb->rbytes, >   snum012 + LR_SHIFT_FLOW, FLOW); > - if (lrnver > lrnver1) > - lrset = LR_SHIFT_FLOW, lrnver = lrnver1; > + if (lrnver > lrnver1) { > + lrset = LR_SHIFT_FLOW; > + lrnver = lrnver1; > + } >   } >   > >   /*