From: Jens Axboe <axboe@kernel.dk>
To: Colin King <colin.king@canonical.com>, linux-block@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] block: clean up dead code that is now redundant
Date: Wed, 14 Nov 2018 15:20:07 -0700 [thread overview]
Message-ID: <4ec214ef-d434-df9a-2bb3-9bda2ef55fbe@kernel.dk> (raw)
In-Reply-To: <20181114221705.17207-1-colin.king@canonical.com>
On 11/14/18 3:17 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The boolean next_sorted is set to false and is never changed, hence
> the code that checks if it is true is dead code and can now be
> removed. This dead code occurred from a previous commit that cleaned
> up the elevator and removed the setting of next_sorted to true.
Ah nice, it's also the last "user" of q->nr_sorted, so that one can
go away as well.
--
Jens Axboe
prev parent reply other threads:[~2018-11-14 22:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 22:17 [PATCH][next] block: clean up dead code that is now redundant Colin King
2018-11-14 22:20 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ec214ef-d434-df9a-2bb3-9bda2ef55fbe@kernel.dk \
--to=axboe@kernel.dk \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox