From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87BFDC43441 for ; Wed, 14 Nov 2018 22:27:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3AEE922549 for ; Wed, 14 Nov 2018 22:27:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="cbkQJIel" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AEE922549 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387878AbeKOIcV (ORCPT ); Thu, 15 Nov 2018 03:32:21 -0500 Received: from mail-it1-f178.google.com ([209.85.166.178]:38699 "EHLO mail-it1-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387459AbeKOIcV (ORCPT ); Thu, 15 Nov 2018 03:32:21 -0500 Received: by mail-it1-f178.google.com with SMTP id k141-v6so26395961itk.3 for ; Wed, 14 Nov 2018 14:27:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8lAGQl5PNsb6SeAmNMfGQNqndWsnnu2bIdRFuCiYvGI=; b=cbkQJIelSzEBEncmdZxwM3sfM9UEBvxs6hmH0twrD89sYOdMmKyWicePRA1Kh4j6aN 32rrNhaHl6oBm4VGOC8BlSjT6XntX+cysNuQSaw8FqPozw9AEYHMPKHtG5VXbaDDfTuv x8wpeUG79eFoTY773PZcMYWNImrFKHiJTK8agFmJorgy6jEeg3XPdX16R4oBlmX0LkV4 gbk0HB0mil7Dv14tB9JsimUognPwDZAHM4re1hH721z9bam/xKor9kGwbNfG/ISj7oyN Z4rL7/qxuT+n40bJWc8GGMpdU1Md2+t6GX3+yehHw/0qnSCaBfD5GuG3LN8VluMAj0az 8G4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8lAGQl5PNsb6SeAmNMfGQNqndWsnnu2bIdRFuCiYvGI=; b=EOy0q8aAh8+IpAAAEN+CvTW3Nhrf+sEyxnPb/NfeoJv+8JAE+J9I03riqHNQVMkqQ5 22wiF4bYdty0o83gqhrFgdUX3ZHiDRmNA05+EY8CSg7EpRaapdiqseinWGuh1CICUngy dZ8mV3Jsr2ByYl9NVfrKNQAyvWzOWYuhzLs0FjPyKViOPyixLyxahbSLdXY9uEdHo7w+ per1sSPSkV1n7MkzRcZiH3jEdd87Ek3keckslG3s5Pf7iXZtzW3sSSaEdnjVinvbGR27 754VxAdny2uEjAq9zpEBfYghe/vAE6X0SG1lQd9XqnH93YMPN246e0SzvmeTfgwOasB1 i/xA== X-Gm-Message-State: AGRZ1gJpxu/I2LoutQncQoWjrdwkFWqA+z6Buv+teL1XSsTFtS/+zPXS xLlTVdb2D3mlhCoPG98TpIJeY8ohSXc= X-Google-Smtp-Source: AJdET5e9dNHZiGvUhrsK8/wVeT+WAX02QOgXYQI7/MIxZhGO0TpN7a6TQnxV5GT1vJU48HbzO88eIA== X-Received: by 2002:a02:8785:: with SMTP id t5mr2737287jai.73.1542234009852; Wed, 14 Nov 2018 14:20:09 -0800 (PST) Received: from [192.168.1.56] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id t64-v6sm8717224iof.19.2018.11.14.14.20.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Nov 2018 14:20:08 -0800 (PST) Subject: Re: [PATCH][next] block: clean up dead code that is now redundant To: Colin King , linux-block@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20181114221705.17207-1-colin.king@canonical.com> From: Jens Axboe Message-ID: <4ec214ef-d434-df9a-2bb3-9bda2ef55fbe@kernel.dk> Date: Wed, 14 Nov 2018 15:20:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181114221705.17207-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/14/18 3:17 PM, Colin King wrote: > From: Colin Ian King > > The boolean next_sorted is set to false and is never changed, hence > the code that checks if it is true is dead code and can now be > removed. This dead code occurred from a previous commit that cleaned > up the elevator and removed the setting of next_sorted to true. Ah nice, it's also the last "user" of q->nr_sorted, so that one can go away as well. -- Jens Axboe