From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5088F419307 for ; Wed, 1 Jul 2026 11:45:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782906317; cv=none; b=JBNPXhn7E9uhuqq0LWiTQlknwouvhfvX3db+T4chAYNC5VD32KBDfayQSEf+ywnjvyMwYgq5xsJuwX3DuudQkpvzNr7KmyKSw1HaahZiPZzopRbruBPtAxJlrMRzJvcANQbKx8JgPYreSTjNq3152BUs2jFSLSAzogzibLx5c0Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782906317; c=relaxed/simple; bh=8bDt6WmHd38RjI3I07PX4H7z+6SwekPIKJxwxBqTYLA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QKZiDzQSSWpEPhKKEAv/7fA8Ktuvs3+7X7aT7FKRO+AFk8wVClEm/zZGBz6g6E+UhExzc+YXaQaZ8eWI2VYSmwoDJ+wCbMMGmnauOxnPRNC32tsCTIRNZuiVVdx05wzqDd33WtXMmuHN4aMcqD9S/vtHMj4uVzCdvu0yWE/9c0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hFmz9lZP; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hFmz9lZP" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-37fdee9276fso456215a91.3 for ; Wed, 01 Jul 2026 04:45:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782906315; x=1783511115; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=/ee7YMVRzqI+ZD40aoZQ9RtQKlP28mAE9ycV55I3/ig=; b=hFmz9lZPofobwn/4XRZP9xPGmW8OajGNHW1Qluj0fBDepLqvCsfV9ap6u3UxDZZr1z ZqewUoqGpRLJI/R5YSUElyMDqlDoQXSU1hd32pwFP4X/ah5lv5AODrRugGLoaA+yV8a0 UfMtTl0e9ZsGJruwgtl9TH5OsdQ+yHXh80jKycQTFF4LK0bvxYbxxkkFkRcaBhegJ436 HGfekBdG7MpndTUiAGj3uh1KgCGWm8xoPmAU/mVApupvZtYwt8YYtbIaIkvA8CNIdxc6 MnYYiRGJr8C0bZMtZEgHeyXeLJFCBEVNHrjpiB8ItCf8s7xMH9b1Z04F9Wk80keWrCMV A5Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782906315; x=1783511115; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/ee7YMVRzqI+ZD40aoZQ9RtQKlP28mAE9ycV55I3/ig=; b=IKy2rjyFjj5R4kt8h6yVHnfKRrzDJOQLQL6moqxXsz12Iju+r/PPeqBb70bdIVlpOZ AWgDBvIevWKo/TBbaC9/Srr1r3fKSI9My797E7D4YsUzcUEDDYXhSXWqbNM/Vy39CpO/ EoQ4I4Uik/lrgaswCYCkL8GP8u05nowOvBEQfum+CoRhzD5tGMk4BB1VXaIMUwynZh9f WtiW8fUozbC8hcFEoVOoEqBJQ0tNpTzAPh2C9XJsSrc1FRMW8f0six2GzVLTuM55vM8m 3KDlAb8X0rm8L1+pnQOHnMGc6WNSJK6EOq4EXg9Anpy5eJBiAShJi0Ggg+a4pGuSUoHm SxeQ== X-Forwarded-Encrypted: i=1; AHgh+RpfA0TZPCBm9S3vE1kfvK63PGRMsJl1MSseHNvzgxXEcdqdYjMnkzI4veNz0CsDhqEs8s4565vRouSyM1g=@vger.kernel.org X-Gm-Message-State: AOJu0YyzbyRvyEX+hyGXJHjX1w/Zygu3BGI1Jl6jDgcH3LvwmrOcONpt LTNC5S7QBKuKbT0y01ACa4xa03M23k7ChqbX73+/uRiybU2wBZWXKZgY X-Gm-Gg: AfdE7ck1nIVwPGRSKU+SDTzYxURolhmhD8ZYLakYut5MH006rdTg25b0hfn6c3kFSgN Eo3HLB/fj/rbZAslt2mWiP6TbzUtqhKB6iWhrVeUEsDOf8FMyMMIKu9yNwmIOKlOT8bBkjYFaUY prXY0/7Dz5tyw9qvMHR1T3b2r+wsef0Px7cX8m8Hucguxcdt9ZqExkZlnU9cxlyr7EQbFfulM3V jkYVOT1okCqiZnhqA4vr4jAUd9sLFw+sgxb66wTlKkaIY4W3EKkaTwAYwl5hMgiTDr0xLcMYmAZ mFNyTbdyRD2amWy3PgtwUs1Kb2sVD4xlZYVaAFRC4fyrKNmWdKM8MJQ7o+0JTPMVUcHEZiP+Y/C qHmMuKqG54abVidmbMJX4s3UWmiPGLCCpN1eZcK2dN2rv+r3gi+fX6PjfKzDwXjYbLgnEJGDNcD /d/uU54uuhTfi+QqyKVqH410jor20Cp+TQN/XEL15bOzE= X-Received: by 2002:a17:90b:548b:b0:37f:9ce1:cdab with SMTP id 98e67ed59e1d1-380baa971aemr453297a91.33.1782906315613; Wed, 01 Jul 2026 04:45:15 -0700 (PDT) Received: from [10.125.192.77] ([210.184.73.204]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38095d4c263sm1750153a91.3.2026.07.01.04.45.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jul 2026 04:45:14 -0700 (PDT) Message-ID: <4ec2bd64-af40-8ebf-b8a8-2dd7421a1100@gmail.com> Date: Wed, 1 Jul 2026 19:45:06 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH v5 4/6] mm/zswap: Implement proactive writeback To: Yosry Ahmed Cc: akpm@linux-foundation.org, tj@kernel.org, hannes@cmpxchg.org, shakeel.butt@linux.dev, mhocko@kernel.org, mkoutny@suse.com, nphamcs@gmail.com, chengming.zhou@linux.dev, muchun.song@linux.dev, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Hao Jia References: <20260629112032.20423-1-jiahao.kernel@gmail.com> <20260629112032.20423-5-jiahao.kernel@gmail.com> From: Hao Jia In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026/7/1 00:10, Yosry Ahmed wrote: >>> Before going through more versions we need to figure out if this will >>> pivot to be a proactive demotion interfcae for swap tiering. >>> >> >> Yes. Should I drop patches 4-6 in the next version and wait for swap >> tiering to be finalized? >> We can try to get the non-memcg parts (patches 1-3) merged upstream >> first. This would also give them plenty of time to bake and catch any >> potential regressions. Thoughts? > > Patches 1-2 can be sent and merged separately, yes. For patch 2, > please include some numbers for the writeback performance before and > after batching. I'd love to collect some performance data. Do you have any recommended benchmarks for this? Thanks, Hao > > Patch 3 does refactoring in preparation for patch 4, so I don't think > it makes sense on its own. >