From: Markus Elfring <Markus.Elfring@web.de>
To: "Jani Nikula" <jani.nikula@intel.com>,
intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
kernel-janitors@vger.kernel.org,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"David Airlie" <airlied@gmail.com>,
"Faith Ekstrand" <faith.ekstrand@collabora.com>,
"Francois Dugast" <francois.dugast@intel.com>,
"José Roberto de Souza" <jose.souza@intel.com>,
"Lucas De Marchi" <lucas.demarchi@intel.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Matt Roper" <matthew.d.roper@intel.com>,
"Matthew Brost" <matthew.brost@intel.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Maxime Ripard" <mripard@kernel.org>,
"Nirmoy Das" <nirmoy.das@intel.com>,
"Philippe Lecluse" <philippe.lecluse@intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/xe/query: Refactor copy_to_user() usage in four functions
Date: Wed, 18 Sep 2024 11:38:57 +0200 [thread overview]
Message-ID: <4eef2944-9ce7-4126-bf09-3e4afcc52dbf@web.de> (raw)
In-Reply-To: <87plp1b989.fsf@intel.com>
>> Assign return values from copy_to_user() calls to additional local variables
>> so that four kfree() calls and return statements can be omitted accordingly.
…
>> +++ b/drivers/gpu/drm/xe/xe_query.c
>> @@ -220,13 +220,11 @@ static int query_engines(struct xe_device *xe,
>>
>> engines->num_engines = i;
>>
>> - if (copy_to_user(query_ptr, engines, size)) {
>> + {
>
> Please don't leave blocks like this behind when you remove the if.
…
>> + unsigned long ctu = copy_to_user(query_ptr, engines, size);
>> kfree(engines);
>> - return -EFAULT;
>> + return ctu ? -EFAULT : 0;
>> }
>> - kfree(engines);
>> -
>> - return 0;
>> }
…
Would you tolerate the shown variable definition without the proposed
compound statement?
Regards,
Markus
prev parent reply other threads:[~2024-09-18 9:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 8:12 [PATCH] drm/xe/query: Refactor copy_to_user() usage in four functions Markus Elfring
2024-09-18 9:29 ` Jani Nikula
2024-09-18 9:38 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4eef2944-9ce7-4126-bf09-3e4afcc52dbf@web.de \
--to=markus.elfring@web.de \
--cc=airlied@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=faith.ekstrand@collabora.com \
--cc=francois.dugast@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jose.souza@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.brost@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=nirmoy.das@intel.com \
--cc=philippe.lecluse@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox