From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84F0FC1B0E3 for ; Mon, 14 Dec 2020 11:55:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 500FF23975 for ; Mon, 14 Dec 2020 11:55:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407778AbgLNLy5 convert rfc822-to-8bit (ORCPT ); Mon, 14 Dec 2020 06:54:57 -0500 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.86.151]:44073 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407754AbgLNLym (ORCPT ); Mon, 14 Dec 2020 06:54:42 -0500 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-57-NlvEctBAMaCvCybvQIbvtA-1; Mon, 14 Dec 2020 11:53:03 +0000 X-MC-Unique: NlvEctBAMaCvCybvQIbvtA-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 14 Dec 2020 11:53:04 +0000 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Mon, 14 Dec 2020 11:53:04 +0000 From: David Laight To: 'Philipp Gerlesberger' , "linux-kernel@vger.kernel.org" CC: "ij72uhux@stud.informatik.uni-erlangen.de" , "linux-media@vger.kernel.org" , "devel@driverdev.osuosl.org" , "linux-kernel@i4.cs.fau.de" , "gregkh@linuxfoundation.org" , "sakari.ailus@linux.intel.com" , "mchehab@kernel.org" Subject: RE: [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS Thread-Topic: [PATCH v2 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS Thread-Index: AQHW0gocnJO7wsTYYEGwNcWFQ1O+9qn2emzA Date: Mon, 14 Dec 2020 11:53:04 +0000 Message-ID: <4eef67d66b0b48feba474906431daa30@AcuMS.aculab.com> References: <20201214110156.6152-1-Philipp.Gerlesberger@fau.de> <20201214110156.6152-13-Philipp.Gerlesberger@fau.de> In-Reply-To: <20201214110156.6152-13-Philipp.Gerlesberger@fau.de> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Philipp Gerlesberger > Sent: 14 December 2020 11:02 > > Logical continuations should be on the previous line > > Co-developed-by: Andrey Khlopkov > Signed-off-by: Andrey Khlopkov > Signed-off-by: Philipp Gerlesberger > --- > drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > index 2f1c2df59f71..7d44070c7114 100644 > --- a/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > +++ b/drivers/staging/media/atomisp/pci/runtime/queue/src/queue.c > @@ -24,8 +24,8 @@ > *****************************************************************************/ > int ia_css_queue_local_init(ia_css_queue_t *qhandle, ia_css_queue_local_t *desc) > { > - if (NULL == qhandle || NULL == desc > - || NULL == desc->cb_elems || NULL == desc->cb_desc) { > + if (NULL == qhandle || NULL == desc || > + NULL == desc->cb_elems || NULL == desc->cb_desc) { > /* Invalid parameters, return error*/ > return -EINVAL; Get rid of the obnoxious backwards tests and it probably fits in 80 columns. if (!qhandle || !desc || !desc->cb_elems || !desc->desc) { ... OTOH if it isn't expected that any of these might be NULL just delete the test. If they ever are 'accidentally' NULL it is usually easier to debug the NULL pointer dereference than an obscure error return. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)