Re: [PATCH v2 06/12] media: atomisp: Remove defines

Mauro Carvalho Chehab
2021-03-23T13:12:50Z

Em Mon, 14 Dec 2020 12:01:50 +0100
Philipp Gerlesberger <Philipp.Gerlesberger@fau.de> escreveu:

> Remov defines, they don't make sense.
> The programmer should know what things need to be static and what not.
> Also leave "inline" out and let the compiler decide
>
> Co-developed-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de>
> Signed-off-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de>
> Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de>
> ---
> .../media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h b/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h
> index 9cd3d92b34c9..45b72e98bc9f 100644
> --- a/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h
> +++ b/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h
> @@ -21,10 +21,7 @@
> #ifndef __INLINE_RMGR__
> #define STORAGE_CLASS_RMGR_H extern
> #define STORAGE_CLASS_RMGR_C
> -#else /* __INLINE_RMGR__ */
> -#define STORAGE_CLASS_RMGR_H static inline
> -#define STORAGE_CLASS_RMGR_C static inline
> -#endif /* __INLINE_RMGR__ */
> +#endif

No, that's not the right way to address it. Instead, you should
replace the occurrences of those macros at the code and get rid
of them.

Thanks,
Mauro