Re: [PATCH v6 0/3] serial: 8250_pnp: Support configurable reg shift property

[albanhuang <albanhuang0@gmail.com>]

在 2024/4/9 20:53, Andy Shevchenko 写道:
> On Tue, Apr 09, 2024 at 03:43:20PM +0800, Guanbing Huang wrote:
>> From: Guanbing Huang <albanhuang@tencent.com>
>>
>> The 16550a serial port based on the ACPI table requires obtaining the
>> reg-shift attribute. In the ACPI scenario, If the reg-shift property
>> is not configured like in DTS, the 16550a serial driver cannot read or
>> write controller registers properly during initialization.
>>
>> To address the issue of configuring the reg-shift property, the
>> __uart_read_properties() universal interface is called to implement it.
>> Adaptation of PNP devices is done in the __uart_read_properties() function.
> You either forgot or deliberately not added my tag. Can you elaborate?

I'm very sorry, this is my first time submitting a kernel patch. My 
understanding

of the submission specification is not comprehensive and profound enough,

and I didn't intentionally not add tags. I hope you can forgive my 
operational mistake.

Should I just add a "Reviewed-by tag", or do I need any other tags? Thanks.


With Best Regards.

>