From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8998419CC02; Wed, 26 Mar 2025 07:36:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742974568; cv=none; b=Jm/reGrm4ldvxiMDLslGfcUNwDr1mu46nPcPkpHNNRsu2nfog5BlLWmQMUiP+Y8UBICZIqL1e0INdt+IhdztwidlB4dY44vy7iSYxmzqCNT/zLpSfRZyT3mIiRIRfCC6VqiDh4IosT/1xpeOxxpjKIWYzTg9G/XjaWcpFhtouD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742974568; c=relaxed/simple; bh=x2b6sU2iYQeahM2s7nfJZgWOLSXDtqDOQPWtxmoo9BA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A04SPI17kMqaWaWBNGKxpRKi2wZToM5T7HB4pqhJpUxwlnDEaElFOCSYy7OOmLvdY38QidIko8R+ysf1BpiBYApILUASNBq/CLrSClvoyKCurUPErQOnVnrRDy912X3pVRP2A8s4Nc/MNYyRWCcXgRAry7sewgUpLmih3nq55Yc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OID1J7ex; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OID1J7ex" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2B55C4CEE2; Wed, 26 Mar 2025 07:36:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742974568; bh=x2b6sU2iYQeahM2s7nfJZgWOLSXDtqDOQPWtxmoo9BA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=OID1J7ex19eexSfzSE+KgXrXCwtmUZR/v5WJpjzEx949Rx+5biEqfMRdssESL2oji kECq7ZUWhujrp72qtCpcLbNsp16QsGNfBvh5hbg5PerLdCbnANUFdLOb2B+4ACTlZs ct4jl1ARWds5Z6e62fUrFaEuAhwOcqbUjgmbldB2NqUtiT3jKvCy/fZdBrrmpemqUl 72obCnvq/xNYtceo87rjsnh4ZPpdld15lLo509Xrnu5WWtRQf2NK0g34+HqWClPeRP xQn4NkKo/rneRI4DAyrKjyo4kGIUkRgTXOQXM9PFWenYgQDrVrcf7Qv8wiigyOnORR enyjXyU/BGNcQ== Message-ID: <4f2252fb-841e-46e0-942a-5db9767db89f@kernel.org> Date: Wed, 26 Mar 2025 08:36:01 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] firmware: exynos-acpm: allow use during system shutdown To: Tudor Ambarus , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Alim Akhtar Cc: Peter Griffin , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20250324-acpm-atomic-v2-0-7d87746e1765@linaro.org> <20250324-acpm-atomic-v2-2-7d87746e1765@linaro.org> <974ddabee5a2a43b9d32f382ec4b13afab066f1a.camel@linaro.org> <60732c52-7774-48c6-8ec8-44ae82d86267@kernel.org> <42905f72-100b-432a-becb-7e1f835e518e@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <42905f72-100b-432a-becb-7e1f835e518e@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 26/03/2025 08:24, Tudor Ambarus wrote: >>>> >>>> What happens if system_state is changed to shutdown in this particular >>>> moment? How did you prevent this from happening? >>> >>> Yes, and that's also what the I2C subsystem is doing, AFAICS, see >>> i2c_in_atomic_xfer_mode() and its use. This is to make a very >>> specific corner case work, similar to I2C which has to deal with >>> the same issue during shutdown. >> >> But they don't have a choice so they try to do the best to avoid >> sleeping. And it is a subsystem, not a driver, which means their >> patterns are sometimes special. Drivers should not replicate subsystem >> workarounds. >> >>> >>> Would you have a better suggestion? >> >> Yes, you have a choice, you can always use udelay. Driver code is >> supposed to be always correct. > > Using udelay() is good enough for now. I see that downstream uses a > usleep_range(50, 100) and I'm concerned that we're going to waste lots > of cpu cyles once more and more clients get added. If this is going to be the case, then we can revisit it with some numbers. Especially if this ACPM turns out to be a bus driver. > > If there's no concurrency on the ACPM queue mutexes at late system > shutdown, would it work to pass the don't sleep requirement from the > client to ACPM and use udelay only then? You mean the client will choose what sort of delay it expects (sleeping or not)? That would work, but can you actually control it from the client side? Best regards, Krzysztof