From: "Gupta, Nipun" <nipun.gupta@amd.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
davem@davemloft.net, dri-devel@lists.freedesktop.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
krzk+dt@kernel.org, gregkh@linuxfoundation.org, robh@kernel.org,
conor+dt@kernel.org, ogabbay@kernel.org,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
derek.kiernan@amd.com, dragan.cvetic@amd.com, arnd@arndb.de,
praveen.jain@amd.com, harpreet.anand@amd.com,
nikhil.agarwal@amd.com, srivatsa@csail.mit.edu, code@tyhicks.com,
ptsm@linux.microsoft.com, linux-crypto@vger.kernel.org,
David Howells <dhowells@redhat.com>,
Lukas Wunner <lukas@wunner.de>,
Ignat Korchagin <ignat@cloudflare.com>,
keyrings@vger.kernel.org
Subject: Re: [PATCH v2 2/3] accel/amdpk: add driver for AMD PKI accelerator
Date: Fri, 11 Apr 2025 23:50:54 +0530 [thread overview]
Message-ID: <4f365fae-aae2-a0df-e8e9-268b536378b1@amd.com> (raw)
In-Reply-To: <Z_imAnYu1hGRb8An@gondor.apana.org.au>
On 11-04-2025 10:47, Herbert Xu wrote:
> On Fri, Apr 11, 2025 at 10:21:03AM +0530, Gupta, Nipun wrote:
>>
>> added crypto maintainers for comments.
>> IMO, as accel framework is designed to support any type of compute
>> accelerators, the PKI crypto accelerator in accel framework is not
>> completely out of place here, as also suggested at:
>> https://lore.kernel.org/all/2025031352-gyration-deceit-5563@gregkh/
>>
>> Having the crypto accelerator as part of accel also enables to extract
>> the most performance from the HW PKI engines, given that the queue
>> assignment is handled per drm device open call.
>
> There is actually a user-space interface for asymmetric crypto
> through the keyring subsystem. Adding the maintainers of those
> in case they wish to comment on your driver.
AFAIU after looking into it, the keyring subsystem is not to perform the
data operations, but for managing keys for these operations. Kindly
correct me if I am wrong here.
Thanks,
Nipun
next prev parent reply other threads:[~2025-04-11 18:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 17:30 [PATCH v2 1/3] dt-bindings: accel: add device tree for AMD PKI accelerator Nipun Gupta
2025-04-09 17:30 ` [PATCH v2 2/3] accel/amdpk: add driver " Nipun Gupta
2025-04-10 7:36 ` Krzysztof Kozlowski
2025-04-11 4:51 ` Gupta, Nipun
2025-04-11 5:17 ` Herbert Xu
2025-04-11 18:20 ` Gupta, Nipun [this message]
2025-04-12 1:23 ` Herbert Xu
2025-04-17 15:32 ` Gupta, Nipun
2025-04-20 6:39 ` Herbert Xu
2025-04-13 18:52 ` Lukas Wunner
2025-04-16 15:11 ` Gupta, Nipun
2025-04-11 16:34 ` Jeff Hugo
2025-04-16 10:41 ` kernel test robot
2025-04-09 17:30 ` [PATCH v2 3/3] accel/amdpk: add debugfs support Nipun Gupta
2025-04-10 7:29 ` [PATCH v2 1/3] dt-bindings: accel: add device tree for AMD PKI accelerator Krzysztof Kozlowski
2025-04-11 18:18 ` Gupta, Nipun
2025-04-11 16:16 ` Jeff Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f365fae-aae2-a0df-e8e9-268b536378b1@amd.com \
--to=nipun.gupta@amd.com \
--cc=airlied@gmail.com \
--cc=arnd@arndb.de \
--cc=code@tyhicks.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=derek.kiernan@amd.com \
--cc=devicetree@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=dragan.cvetic@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=harpreet.anand@amd.com \
--cc=herbert@gondor.apana.org.au \
--cc=ignat@cloudflare.com \
--cc=keyrings@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nikhil.agarwal@amd.com \
--cc=ogabbay@kernel.org \
--cc=praveen.jain@amd.com \
--cc=ptsm@linux.microsoft.com \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=srivatsa@csail.mit.edu \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox