* [PATCH] ext4: MMP: Fix endianness bug.
@ 2012-02-23 19:09 santoshprasadnayak
2012-02-23 21:49 ` Johann Lombardi
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: santoshprasadnayak @ 2012-02-23 19:09 UTC (permalink / raw)
To: tytso
Cc: adilger, andrew_perepechko, nikitas_angelinas, johann,
linux-kernel, kernel-janitors, Santosh Nayak
From: Santosh Nayak <santoshprasadnayak@gmail.com>
Sparse complaint this endian bug in ext4: mmp.
Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
---
fs/ext4/mmp.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
index 7ea4ba4..ed6548d 100644
--- a/fs/ext4/mmp.c
+++ b/fs/ext4/mmp.c
@@ -257,8 +257,8 @@ int ext4_multi_mount_protect(struct super_block *sb,
* If check_interval in MMP block is larger, use that instead of
* update_interval from the superblock.
*/
- if (mmp->mmp_check_interval > mmp_check_interval)
- mmp_check_interval = mmp->mmp_check_interval;
+ if (le16_to_cpu(mmp->mmp_check_interval) > mmp_check_interval)
+ mmp_check_interval = le16_to_cpu(mmp->mmp_check_interval);
seq = le32_to_cpu(mmp->mmp_seq);
if (seq == EXT4_MMP_SEQ_CLEAN)
--
1.7.4.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ext4: MMP: Fix endianness bug.
2012-02-23 19:09 [PATCH] ext4: MMP: Fix endianness bug santoshprasadnayak
@ 2012-02-23 21:49 ` Johann Lombardi
2012-02-24 17:10 ` Andreas Dilger
2012-02-27 6:11 ` Ted Ts'o
2 siblings, 0 replies; 4+ messages in thread
From: Johann Lombardi @ 2012-02-23 21:49 UTC (permalink / raw)
To: santoshprasadnayak
Cc: tytso, adilger, andrew_perepechko, nikitas_angelinas,
linux-kernel, kernel-janitors
On Fri, Feb 24, 2012 at 12:39:05AM +0530, santoshprasadnayak@gmail.com wrote:
> @@ -257,8 +257,8 @@ int ext4_multi_mount_protect(struct super_block *sb,
> * If check_interval in MMP block is larger, use that instead of
> * update_interval from the superblock.
> */
> - if (mmp->mmp_check_interval > mmp_check_interval)
> - mmp_check_interval = mmp->mmp_check_interval;
> + if (le16_to_cpu(mmp->mmp_check_interval) > mmp_check_interval)
> + mmp_check_interval = le16_to_cpu(mmp->mmp_check_interval);
Looks good to me.
Reviewed-by: Johann Lombardi <johann@whamcloud.com>
Johann
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ext4: MMP: Fix endianness bug.
2012-02-23 19:09 [PATCH] ext4: MMP: Fix endianness bug santoshprasadnayak
2012-02-23 21:49 ` Johann Lombardi
@ 2012-02-24 17:10 ` Andreas Dilger
2012-02-27 6:11 ` Ted Ts'o
2 siblings, 0 replies; 4+ messages in thread
From: Andreas Dilger @ 2012-02-24 17:10 UTC (permalink / raw)
To: santoshprasadnayak@gmail.com
Cc: tytso@mit.edu, adilger@dilger.ca, andrew_perepechko@xyratex.com,
nikitas_angelinas@xyratex.com, johann@whamcloud.com,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Santosh Nayak
On 2012-02-23, at 12:09, santoshprasadnayak@gmail.com wrote:
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>
> Sparse complaint this endian bug in ext4: mmp.
>
> Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
Looks good.
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
> ---
> fs/ext4/mmp.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
> index 7ea4ba4..ed6548d 100644
> --- a/fs/ext4/mmp.c
> +++ b/fs/ext4/mmp.c
> @@ -257,8 +257,8 @@ int ext4_multi_mount_protect(struct super_block *sb,
> * If check_interval in MMP block is larger, use that instead of
> * update_interval from the superblock.
> */
> - if (mmp->mmp_check_interval > mmp_check_interval)
> - mmp_check_interval = mmp->mmp_check_interval;
> + if (le16_to_cpu(mmp->mmp_check_interval) > mmp_check_interval)
> + mmp_check_interval = le16_to_cpu(mmp->mmp_check_interval);
>
> seq = le32_to_cpu(mmp->mmp_seq);
> if (seq == EXT4_MMP_SEQ_CLEAN)
> --
> 1.7.4.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ext4: MMP: Fix endianness bug.
2012-02-23 19:09 [PATCH] ext4: MMP: Fix endianness bug santoshprasadnayak
2012-02-23 21:49 ` Johann Lombardi
2012-02-24 17:10 ` Andreas Dilger
@ 2012-02-27 6:11 ` Ted Ts'o
2 siblings, 0 replies; 4+ messages in thread
From: Ted Ts'o @ 2012-02-27 6:11 UTC (permalink / raw)
To: santoshprasadnayak
Cc: adilger, andrew_perepechko, nikitas_angelinas, johann,
linux-kernel, kernel-janitors
On Fri, Feb 24, 2012 at 12:39:05AM +0530, santoshprasadnayak@gmail.com wrote:
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>
> Sparse complaint this endian bug in ext4: mmp.
>
> Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-02-27 6:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-23 19:09 [PATCH] ext4: MMP: Fix endianness bug santoshprasadnayak
2012-02-23 21:49 ` Johann Lombardi
2012-02-24 17:10 ` Andreas Dilger
2012-02-27 6:11 ` Ted Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox