From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bastien Curutchet <bastien.curutchet@bootlin.com>,
Peter Rosin <peda@axentia.se>, Andi Shyti <andi.shyti@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Peter Korsgaard <peter.korsgaard@barco.com>,
Wolfram Sang <wsa@kernel.org>
Cc: linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
herve.codina@bootlin.com, christophercordahi@nanometrics.ca
Subject: Re: [PATCH 1/3] dt-bindings: i2c: gpio: Add 'transition-delay-ms' property
Date: Mon, 27 May 2024 16:38:19 +0200 [thread overview]
Message-ID: <4f4db483-6042-4f85-9c64-8d3ad9290506@kernel.org> (raw)
In-Reply-To: <20240527113908.127893-2-bastien.curutchet@bootlin.com>
On 27/05/2024 13:39, Bastien Curutchet wrote:
> The i2c-gpio-mux can be used to describe a multiplexer built upon
> several i2c isolators having an enable pin (such as LTC4310). These
> isolators can need some time between their enable pin's assertion and
> the first i2c transfer.
>
> Add a 'transition-delay-ms' property that indicates the delay to be
> respected before doing the first i2c transfer.
>
That's quite limited hardware description, comparing to cover letter.
Please provide full description here, not in cover letter. This is the
binding, so the hardware part.
Anyway, this does not look like property of mux itself. If there is no
isolator, the mux would work fine, right?
Then why you are not adding this property to every possible bus and I2C
controller? I2C isolator could be placed there as well.
So just like RC binding, that's not a property of I2C mux. Maybe this
fits usage of GPIO RC / delay binding.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-27 14:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 11:39 [PATCH 0/3] i2c: mux: gpio: Add 'transition-delay-ms' property Bastien Curutchet
2024-05-27 11:39 ` [PATCH 1/3] dt-bindings: i2c: " Bastien Curutchet
2024-05-27 14:38 ` Krzysztof Kozlowski [this message]
2024-05-28 6:59 ` Bastien Curutchet
2024-05-28 7:49 ` Krzysztof Kozlowski
2024-05-27 11:39 ` [PATCH 2/3] i2c: mux: gpio: Re-order #include to match alphabetic order Bastien Curutchet
2024-05-27 11:39 ` [PATCH 3/3] i2c: mux: gpio: Add support for the 'transition-delay-ms' property Bastien Curutchet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f4db483-6042-4f85-9c64-8d3ad9290506@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=bastien.curutchet@bootlin.com \
--cc=christophercordahi@nanometrics.ca \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=herve.codina@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=peter.korsgaard@barco.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox