From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: leo.jt.wang@gmail.com, robh+dt@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
joel@jms.id.au, andrew@codeconstruct.com.au,
keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com,
geert+renesas@glider.be, magnus.damm@gmail.com,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, george.kw.lee@fii-foxconn.com,
leo.jt.wang@fii-foxconn.com
Subject: Re: [PATCH] ASPEED: bmc: Add device tree for Meta(Facebook) Clemente compute-tray.
Date: Fri, 9 May 2025 13:36:01 +0200 [thread overview]
Message-ID: <4f7b44f0-128c-4615-96cf-2d9d8bc54cdb@linaro.org> (raw)
In-Reply-To: <681dc3eb.170a0220.1fd80.c9ce@mx.google.com>
On 09/05/2025 10:59, leo.jt.wang@gmail.com wrote:
> From: Leo Wang <leo.jt.wang@fii-foxconn.com>
>
> Signed-off-by: Leo Wang <leo.jt.wang@fii-foxconn.com>
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
You CC-ed an address, which suggests you do not work on mainline kernel
or you do not use get_maintainers.pl/b4/patman. Please rebase and always
work on mainline or start using mentioned tools, so correct addresses
will be used.
...
> +&io_expander13 {
> + gpio-line-names =
> + "rmc_en_dc_pwr_on","",
> + "","",
> + "","",
> + "","",
> + "leak_config_0","leak_config_1",
> + "leak_config_2","leak_config_3",
> + "mfg_led_test_mode_l","small_leak_err_inj",
> + "large_leak_err_inj","";
> +};
> \ No newline at end of file
You have patch warning.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-09 11:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-09 8:59 [PATCH] ASPEED: bmc: Add device tree for Meta(Facebook) Clemente compute-tray leo.jt.wang
2025-05-09 11:36 ` Krzysztof Kozlowski [this message]
2025-05-09 13:00 ` Andrew Lunn
2025-05-09 14:17 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f7b44f0-128c-4615-96cf-2d9d8bc54cdb@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=george.kw.lee@fii-foxconn.com \
--cc=gpiccoli@igalia.com \
--cc=joel@jms.id.au \
--cc=keescook@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=leo.jt.wang@fii-foxconn.com \
--cc=leo.jt.wang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox