From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751159AbdKTMQA (ORCPT ); Mon, 20 Nov 2017 07:16:00 -0500 Received: from mga06.intel.com ([134.134.136.31]:16586 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751021AbdKTMP7 (ORCPT ); Mon, 20 Nov 2017 07:15:59 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,426,1505804400"; d="scan'208";a="3866099" Subject: Re: [PATCH v1 0/9] perf stat: Enable '--per-thread' on all threads To: Jiri Olsa Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com References: <1511189024-19908-1-git-send-email-yao.jin@linux.intel.com> <20171120092648.GA30958@krava> From: "Jin, Yao" Message-ID: <4fa51069-25b0-f53b-b0fa-34320445e2b4@linux.intel.com> Date: Mon, 20 Nov 2017 20:15:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171120092648.GA30958@krava> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/20/2017 5:26 PM, Jiri Olsa wrote: > On Mon, Nov 20, 2017 at 10:43:35PM +0800, Jin Yao wrote: >> perf stat --per-thread is useful to break down data per thread. >> But it currently requires specifying --pid/--tid to limit it to a process. >> >> For analysis it would be useful to do it globally for the whole system. > > I can't compile this: > > builtin-script.c: In function ‘perf_sample__fprint_metric’: > builtin-script.c:1549:2: error: too few arguments to function ‘perf_stat__update_shadow_stats’ > perf_stat__update_shadow_stats(evsel, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from builtin-script.c:24:0: > util/stat.h:134:6: note: declared here > void perf_stat__update_shadow_stats(struct perf_evsel *counter, u64 count, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > builtin-script.c:1555:4: error: too few arguments to function ‘perf_stat__print_shadow_stats’ > perf_stat__print_shadow_stats(ev2, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from builtin-script.c:24:0: > util/stat.h:143:6: note: declared here > void perf_stat__print_shadow_stats(struct perf_evsel *evsel, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > mv: cannot stat './.builtin-script.o.tmp': No such file or directory > > thanks, > jirka > Hi Jiri, This patch set is based on the latest perf/core branch. I pull the branch right now and try the build again, the building is OK. Could you tell me which branch you are testing on? Thanks Jin Yao