From: Konrad Leszczynski <konrad.leszczynski@intel.com>
To: Simon Horman <horms@kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Rojewski, Cezary" <cezary.rojewski@intel.com>,
"Basierski, Sebastian" <sebastian.basierski@intel.com>,
"Jurczenia, Karol" <Karol.Jurczenia@intel.com>
Subject: Re: [PATCH net-next 7/7] net: stmmac: add TC flower filter support for IP EtherType
Date: Thu, 28 Aug 2025 11:46:58 +0200 [thread overview]
Message-ID: <4fc29d26-14a0-4295-b82f-48e21b376f49@intel.com> (raw)
In-Reply-To: <20250827193710.GT10519@horms.kernel.org>
On 27-Aug-25 21:37, Simon Horman wrote:
> On Tue, Aug 26, 2025 at 01:32:47PM +0200, Konrad Leszczynski wrote:
>> From: Karol Jurczenia <karol.jurczenia@intel.com>
>>
>> Add missing Traffic Control (TC) offload for flower filters matching the
>> IP EtherType (ETH_P_IP).
>>
>> Reviewed-by: Konrad Leszczynski <konrad.leszczynski@intel.com>
>> Reviewed-by: Sebastian Basierski <sebastian.basierski@intel.com>
>> Signed-off-by: Karol Jurczenia <karol.jurczenia@intel.com>
> Konrad,
>
> As per my comment on an earlier patch, your SoB line needs to go here.
>
> Otherwise, this looks good to me.
>
> Reviewed-by: Simon Horman <horms@kernel.org>
Hi Simon, thanks for the review. I'll split the patchset into two to and
address all your comments.
next prev parent reply other threads:[~2025-08-28 9:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 11:32 [PATCH net-next 0/7] net: stmmac: fixes and new features Konrad Leszczynski
2025-08-26 11:32 ` [PATCH net-next 1/7] net: stmmac: replace memcpy with strscpy in ethtool Konrad Leszczynski
2025-08-27 19:13 ` Simon Horman
2025-08-26 11:32 ` [PATCH net-next 2/7] net: stmmac: correct Tx descriptors debugfs prints Konrad Leszczynski
2025-08-26 11:32 ` [PATCH net-next 3/7] net: stmmac: check if interface is running before TC block setup Konrad Leszczynski
2025-08-26 11:32 ` [PATCH net-next 4/7] net: stmmac: enable ARP Offload on mac_link_up() Konrad Leszczynski
2025-08-26 17:05 ` kernel test robot
2025-08-27 19:28 ` Simon Horman
2025-08-26 11:32 ` [PATCH net-next 5/7] net: stmmac: set TE/RE bits for ARP Offload when interface down Konrad Leszczynski
2025-08-26 11:32 ` [PATCH net-next 6/7] net: stmmac: enhance VLAN protocol detection for GRO Konrad Leszczynski
2025-08-27 19:35 ` Simon Horman
2025-08-26 11:32 ` [PATCH net-next 7/7] net: stmmac: add TC flower filter support for IP EtherType Konrad Leszczynski
2025-08-27 19:37 ` Simon Horman
2025-08-28 9:46 ` Konrad Leszczynski [this message]
2025-08-26 17:29 ` [PATCH net-next 0/7] net: stmmac: fixes and new features Vadim Fedorenko
2025-08-28 6:47 ` Konrad Leszczynski
2025-08-28 12:25 ` Andrew Lunn
2025-08-28 12:51 ` Konrad Leszczynski
2025-08-28 13:21 ` Vadim Fedorenko
2025-08-28 14:40 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fc29d26-14a0-4295-b82f-48e21b376f49@intel.com \
--to=konrad.leszczynski@intel.com \
--cc=Karol.Jurczenia@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=cezary.rojewski@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sebastian.basierski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).