From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68C17C43387 for ; Wed, 9 Jan 2019 09:10:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 418F1214C6 for ; Wed, 9 Jan 2019 09:10:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730023AbfAIJKx (ORCPT ); Wed, 9 Jan 2019 04:10:53 -0500 Received: from mga18.intel.com ([134.134.136.126]:61486 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729716AbfAIJKx (ORCPT ); Wed, 9 Jan 2019 04:10:53 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2019 01:10:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,456,1539673200"; d="scan'208";a="124513868" Received: from linux.intel.com ([10.54.29.200]) by FMSMGA003.fm.intel.com with ESMTP; 09 Jan 2019 01:10:50 -0800 Received: from [10.125.252.236] (abudanko-mobl.ccr.corp.intel.com [10.125.252.236]) by linux.intel.com (Postfix) with ESMTP id 0D558580490; Wed, 9 Jan 2019 01:10:47 -0800 (PST) From: Alexey Budankov Subject: Re: [PATCH v2 2/4] perf record: bind the AIO user space buffers to nodes To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Namhyung Kim , Alexander Shishkin , Andi Kleen , linux-kernel References: <20190101213938.GF13760@krava> Organization: Intel Corp. Message-ID: <4fdbe0c8-1985-4b90-eeaf-6d1664af78f8@linux.intel.com> Date: Wed, 9 Jan 2019 12:10:45 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190101213938.GF13760@krava> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 02.01.2019 0:39, Jiri Olsa wrote: > On Mon, Dec 24, 2018 at 03:24:36PM +0300, Alexey Budankov wrote: > > SNIP > >> +#else >> +static void perf_mmap__aio_alloc(void **data, size_t len) >> +{ >> + *data = malloc(len); >> +} >> + >> +static void perf_mmap__aio_free(void **data, size_t len __maybe_unused) >> +{ >> + zfree(data); >> +} >> + >> +static void perf_mmap__aio_bind(void *data __maybe_unused, size_t len __maybe_unused, >> + int cpu __maybe_unused, int affinity __maybe_unused) >> +{ >> +} >> +#endif >> + >> static int perf_mmap__aio_mmap(struct perf_mmap *map, struct mmap_params *mp) >> { >> int delta_max, i, prio; >> @@ -177,11 +220,13 @@ static int perf_mmap__aio_mmap(struct perf_mmap *map, struct mmap_params *mp) >> } >> delta_max = sysconf(_SC_AIO_PRIO_DELTA_MAX); >> for (i = 0; i < map->aio.nr_cblocks; ++i) { >> - map->aio.data[i] = malloc(perf_mmap__mmap_len(map)); >> + size_t mmap_len = perf_mmap__mmap_len(map); > > WARNING: Missing a blank line after declarations > > and plenty of othres from scripts/checkpatch.pl, > please run that Corrected in v3. Thanks! Alexey > > jirka >