Re: Please revert the addition of the AMD QDMA driver

[Lizhi Hou <lizhi.hou@amd.com>]

Hi Christoph and Vinod,


Sorry, I did not know the limitation of get/set_dma_ops.

Instead of reverting the entire driver, is it ok to put a fix on top to 
address this issue?


Thanks,

Lizhi

On 9/16/24 00:40, Christoph Hellwig wrote:
> Hi Vinod,
>
> I just noticed you added the AMD QDMA driver for this merge window,
> which is completely broken in terms of DMA API usage by using the
> private get/set_dma_ops APIs.  These were never for driver use (
> and I've been working for years to fix the few abusers), but with the
> DMA changes in 6.12 it actually can't work at all, as the dma-iommu
> driver now also sets NULL DMA ops in addition to dma-direct.
>
> As a reminder drivers must never try to inherit dma settings from
> one device or another, instead pass the actual DMA device to whatever
> layer does the DMA mapping.  Without that you break all kinds of
> thing.
>
>