From: "Du, Changbin" <changbin.du@gmail.com>
To: <mchehab@infradead.org>
Cc: <tsoni@codeaurora.org>, <dan.carpenter@oracle.com>,
<kumarrav@codeaurora.org>, <linux-media@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] media: gpio-ir-recv: add allowed_protos and map_name for platform data
Date: Tue, 3 Jul 2012 18:27:19 +0800 [thread overview]
Message-ID: <4ff2c90c.83e6440a.48b4.3727@mx.google.com> (raw)
It's better to give platform code a chance to specify the allowed
protocols and which keymap to use.
Signed-off-by: Du, Changbin <changbin.du@gmail.com>
---
drivers/media/rc/gpio-ir-recv.c | 10 ++++++++--
include/media/gpio-ir-recv.h | 6 ++++--
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/media/rc/gpio-ir-recv.c
b/drivers/media/rc/gpio-ir-recv.c
index 0d87545..f0d09af 100644
--- a/drivers/media/rc/gpio-ir-recv.c
+++ b/drivers/media/rc/gpio-ir-recv.c
@@ -83,11 +83,17 @@ static int __devinit gpio_ir_recv_probe(struct
platform_device *pdev)
}
rcdev->driver_type = RC_DRIVER_IR_RAW;
- rcdev->allowed_protos = RC_TYPE_ALL;
rcdev->input_name = GPIO_IR_DEVICE_NAME;
rcdev->input_id.bustype = BUS_HOST;
rcdev->driver_name = GPIO_IR_DRIVER_NAME;
- rcdev->map_name = RC_MAP_EMPTY;
+ if (pdata->allowed_protos)
+ rcdev->allowed_protos = pdata->allowed_protos;
+ else
+ rcdev->allowed_protos = RC_TYPE_ALL;
+ if (pdata->map_name)
+ rcdev->map_name = pdata->map_name;
+ else
+ rcdev->map_name = RC_MAP_EMPTY;
gpio_dev->rcdev = rcdev;
gpio_dev->gpio_nr = pdata->gpio_nr;
diff --git a/include/media/gpio-ir-recv.h b/include/media/gpio-ir-recv.h
index 67797bf..0142736 100644
--- a/include/media/gpio-ir-recv.h
+++ b/include/media/gpio-ir-recv.h
@@ -14,8 +14,10 @@
#define __GPIO_IR_RECV_H__
struct gpio_ir_recv_platform_data {
- int gpio_nr;
- bool active_low;
+ int gpio_nr;
+ bool active_low;
+ u64 allowed_protos;
+ const char *map_name;
};
#endif /* __GPIO_IR_RECV_H__ */
--
1.7.9.5
next reply other threads:[~2012-07-03 10:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 10:27 Du, Changbin [this message]
2012-07-03 11:19 ` [PATCH] media: gpio-ir-recv: add allowed_protos and map_name for platform data Benoît Thébaudeau
2012-07-04 3:08 ` Du, Changbin
2012-07-06 21:23 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ff2c90c.83e6440a.48b4.3727@mx.google.com \
--to=changbin.du@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=kumarrav@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox