From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753289AbeFAPur (ORCPT ); Fri, 1 Jun 2018 11:50:47 -0400 Received: from mail-ot0-f194.google.com ([74.125.82.194]:41967 "EHLO mail-ot0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752262AbeFAPul (ORCPT ); Fri, 1 Jun 2018 11:50:41 -0400 X-Google-Smtp-Source: ADUXVKLNnOt5PlRlTqVUJ7D/ZS5dgJsTe6xOE08h8uFYgkQ7I26dZtBBcJwuNCdNTqT07LxvCPTpYg== Subject: Re: [PATCH v2] PCI: Check for PCIe downtraining conditions To: Sinan Kaya , bhelgaas@google.com Cc: alex_gagniuc@dellteam.com, austin_bolen@dell.com, shyam_iyer@dell.com, keith.busch@intel.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180601150129.10486-1-mr.nuke.me@gmail.com> <35a67b5b-5f37-c779-64a3-eb5e21362e9c@codeaurora.org> <321c6d7d-b8e6-9b8d-91e5-a4f748acaa8e@codeaurora.org> From: "Alex G." Message-ID: <4ffb153a-c26e-8762-df86-9d84dc726fa4@gmail.com> Date: Fri, 1 Jun 2018 10:50:39 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <321c6d7d-b8e6-9b8d-91e5-a4f748acaa8e@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/01/2018 10:10 AM, Sinan Kaya wrote: > On 6/1/2018 11:06 AM, Alex G. wrote: >> On 06/01/2018 10:03 AM, Sinan Kaya wrote: >>> On 6/1/2018 11:01 AM, Alexandru Gagniuc wrote: >>>> + /* Multi-function PCIe share the same link/status. */ >>>> + if (PCI_FUNC(dev->devfn) != 0) >>>> + return; >>> >>> How about virtual functions? >> >> I have almost no clue about those. Is your concern that we might end up >> printing more than our fair share of link statuses? > > Yes, struct pci_dev also has a flag called is_virtfn that you should bail out > here too. Will be fixed in v3. Thanks, Alex >> >> Alex >> >> > >