* [PATCH v2] bus: mhi: host: pci_generic: Add Foxconn T99W696
@ 2025-05-28 9:22 Slark Xiao
2025-06-17 9:39 ` Manivannan Sadhasivam
2025-07-08 12:49 ` Manivannan Sadhasivam
0 siblings, 2 replies; 7+ messages in thread
From: Slark Xiao @ 2025-05-28 9:22 UTC (permalink / raw)
To: manivannan.sadhasivam, johan+linaro, mhi
Cc: linux-arm-msm, linux-kernel, Slark Xiao
T99W696 is designed based on Qualcomm SDX61 chip which is a cost
down chip refer to previous SDX62/SDX65. Though we have a support
on SDX62/SDX65, we create a new channel config for SDX61 since
we add a NMEA channel support from this product.
For new products we are allowed to customize the subVID and
subPID only.
Signed-off-by: Slark Xiao <slark_xiao@163.com>
---
v2: Correct the ch_cfg as sdx61 channels
---
drivers/bus/mhi/host/pci_generic.c | 52 ++++++++++++++++++++++++++++++
1 file changed, 52 insertions(+)
diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index a4a62429c784..a90ab31c46a9 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -490,6 +490,23 @@ static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = {
MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
};
+static const struct mhi_channel_config mhi_foxconn_sdx61_channels[] = {
+ MHI_CHANNEL_CONFIG_UL(0, "LOOPBACK", 32, 0),
+ MHI_CHANNEL_CONFIG_DL(1, "LOOPBACK", 32, 0),
+ MHI_CHANNEL_CONFIG_UL(4, "DIAG", 32, 1),
+ MHI_CHANNEL_CONFIG_DL(5, "DIAG", 32, 1),
+ MHI_CHANNEL_CONFIG_UL(12, "MBIM", 32, 0),
+ MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
+ MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
+ MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
+ MHI_CHANNEL_CONFIG_UL_FP(34, "FIREHOSE", 32, 0),
+ MHI_CHANNEL_CONFIG_DL_FP(35, "FIREHOSE", 32, 0),
+ MHI_CHANNEL_CONFIG_UL(50, "NMEA", 32, 0),
+ MHI_CHANNEL_CONFIG_DL(51, "NMEA", 32, 0),
+ MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
+ MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
+};
+
static struct mhi_event_config mhi_foxconn_sdx55_events[] = {
MHI_EVENT_CONFIG_CTRL(0, 128),
MHI_EVENT_CONFIG_DATA(1, 128),
@@ -506,6 +523,15 @@ static const struct mhi_controller_config modem_foxconn_sdx55_config = {
.event_cfg = mhi_foxconn_sdx55_events,
};
+static const struct mhi_controller_config modem_foxconn_sdx61_config = {
+ .max_channels = 128,
+ .timeout_ms = 20000,
+ .num_channels = ARRAY_SIZE(mhi_foxconn_sdx61_channels),
+ .ch_cfg = mhi_foxconn_sdx61_channels,
+ .num_events = ARRAY_SIZE(mhi_foxconn_sdx55_events),
+ .event_cfg = mhi_foxconn_sdx55_events,
+};
+
static const struct mhi_controller_config modem_foxconn_sdx72_config = {
.max_channels = 128,
.timeout_ms = 20000,
@@ -615,6 +641,17 @@ static const struct mhi_pci_dev_info mhi_foxconn_dw5934e_info = {
.sideband_wake = false,
};
+static const struct mhi_pci_dev_info mhi_foxconn_t99w696_info = {
+ .name = "foxconn-t99w696",
+ .edl = "qcom/sdx61/foxconn/prog_firehose_lite.elf",
+ .edl_trigger = true,
+ .config = &modem_foxconn_sdx61_config,
+ .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
+ .dma_data_width = 32,
+ .mru_default = 32768,
+ .sideband_wake = false,
+};
+
static const struct mhi_channel_config mhi_mv3x_channels[] = {
MHI_CHANNEL_CONFIG_UL(0, "LOOPBACK", 64, 0),
MHI_CHANNEL_CONFIG_DL(1, "LOOPBACK", 64, 0),
@@ -863,6 +900,21 @@ static const struct pci_device_id mhi_pci_id_table[] = {
/* Telit FE990A */
{ PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, 0x1c5d, 0x2015),
.driver_data = (kernel_ulong_t) &mhi_telit_fe990a_info },
+ /* Foxconn T99W696.01, Lenovo Generic SKU */
+ { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe142),
+ .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
+ /* Foxconn T99W696.02, Lenovo X1 Carbon SKU */
+ { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe143),
+ .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
+ /* Foxconn T99W696.03, Lenovo X1 2in1 SKU */
+ { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe144),
+ .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
+ /* Foxconn T99W696.04, Lenovo PRC SKU */
+ { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe145),
+ .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
+ /* Foxconn T99W696.00, Foxconn SKU */
+ { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe146),
+ .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
{ PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0308),
.driver_data = (kernel_ulong_t) &mhi_qcom_sdx65_info },
{ PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0309),
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] bus: mhi: host: pci_generic: Add Foxconn T99W696
2025-05-28 9:22 [PATCH v2] bus: mhi: host: pci_generic: Add Foxconn T99W696 Slark Xiao
@ 2025-06-17 9:39 ` Manivannan Sadhasivam
2025-06-20 7:01 ` Slark Xiao
2025-07-08 12:49 ` Manivannan Sadhasivam
1 sibling, 1 reply; 7+ messages in thread
From: Manivannan Sadhasivam @ 2025-06-17 9:39 UTC (permalink / raw)
To: Slark Xiao
Cc: manivannan.sadhasivam, johan+linaro, mhi, linux-arm-msm,
linux-kernel
On Wed, May 28, 2025 at 05:22:32PM +0800, Slark Xiao wrote:
> T99W696 is designed based on Qualcomm SDX61 chip which is a cost
> down chip refer to previous SDX62/SDX65. Though we have a support
> on SDX62/SDX65, we create a new channel config for SDX61 since
> we add a NMEA channel support from this product.
> For new products we are allowed to customize the subVID and
> subPID only.
>
Could you please push the firmware to linux-firmware? I don't expect the users
of the products to upstream the firmware, but I do expect the vendors to do so.
FYI: Qcom was able to upstream the firmware for one of their modems:
https://web.git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/qcom/qdu100/xbl_s.melf?id=01842da45df0a9f862098d1597f6ae5774b3e48a
So there should be no licensing issues. Going forward, I want both Qcom and
vendors to upstream the firmware before the modem support gets in.
- Mani
> Signed-off-by: Slark Xiao <slark_xiao@163.com>
> ---
> v2: Correct the ch_cfg as sdx61 channels
> ---
> drivers/bus/mhi/host/pci_generic.c | 52 ++++++++++++++++++++++++++++++
> 1 file changed, 52 insertions(+)
>
> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> index a4a62429c784..a90ab31c46a9 100644
> --- a/drivers/bus/mhi/host/pci_generic.c
> +++ b/drivers/bus/mhi/host/pci_generic.c
> @@ -490,6 +490,23 @@ static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = {
> MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
> };
>
> +static const struct mhi_channel_config mhi_foxconn_sdx61_channels[] = {
> + MHI_CHANNEL_CONFIG_UL(0, "LOOPBACK", 32, 0),
> + MHI_CHANNEL_CONFIG_DL(1, "LOOPBACK", 32, 0),
> + MHI_CHANNEL_CONFIG_UL(4, "DIAG", 32, 1),
> + MHI_CHANNEL_CONFIG_DL(5, "DIAG", 32, 1),
> + MHI_CHANNEL_CONFIG_UL(12, "MBIM", 32, 0),
> + MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
> + MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
> + MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
> + MHI_CHANNEL_CONFIG_UL_FP(34, "FIREHOSE", 32, 0),
> + MHI_CHANNEL_CONFIG_DL_FP(35, "FIREHOSE", 32, 0),
> + MHI_CHANNEL_CONFIG_UL(50, "NMEA", 32, 0),
> + MHI_CHANNEL_CONFIG_DL(51, "NMEA", 32, 0),
> + MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
> + MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
> +};
> +
> static struct mhi_event_config mhi_foxconn_sdx55_events[] = {
> MHI_EVENT_CONFIG_CTRL(0, 128),
> MHI_EVENT_CONFIG_DATA(1, 128),
> @@ -506,6 +523,15 @@ static const struct mhi_controller_config modem_foxconn_sdx55_config = {
> .event_cfg = mhi_foxconn_sdx55_events,
> };
>
> +static const struct mhi_controller_config modem_foxconn_sdx61_config = {
> + .max_channels = 128,
> + .timeout_ms = 20000,
> + .num_channels = ARRAY_SIZE(mhi_foxconn_sdx61_channels),
> + .ch_cfg = mhi_foxconn_sdx61_channels,
> + .num_events = ARRAY_SIZE(mhi_foxconn_sdx55_events),
> + .event_cfg = mhi_foxconn_sdx55_events,
> +};
> +
> static const struct mhi_controller_config modem_foxconn_sdx72_config = {
> .max_channels = 128,
> .timeout_ms = 20000,
> @@ -615,6 +641,17 @@ static const struct mhi_pci_dev_info mhi_foxconn_dw5934e_info = {
> .sideband_wake = false,
> };
>
> +static const struct mhi_pci_dev_info mhi_foxconn_t99w696_info = {
> + .name = "foxconn-t99w696",
> + .edl = "qcom/sdx61/foxconn/prog_firehose_lite.elf",
> + .edl_trigger = true,
> + .config = &modem_foxconn_sdx61_config,
> + .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
> + .dma_data_width = 32,
> + .mru_default = 32768,
> + .sideband_wake = false,
> +};
> +
> static const struct mhi_channel_config mhi_mv3x_channels[] = {
> MHI_CHANNEL_CONFIG_UL(0, "LOOPBACK", 64, 0),
> MHI_CHANNEL_CONFIG_DL(1, "LOOPBACK", 64, 0),
> @@ -863,6 +900,21 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> /* Telit FE990A */
> { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, 0x1c5d, 0x2015),
> .driver_data = (kernel_ulong_t) &mhi_telit_fe990a_info },
> + /* Foxconn T99W696.01, Lenovo Generic SKU */
> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe142),
> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
> + /* Foxconn T99W696.02, Lenovo X1 Carbon SKU */
> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe143),
> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
> + /* Foxconn T99W696.03, Lenovo X1 2in1 SKU */
> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe144),
> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
> + /* Foxconn T99W696.04, Lenovo PRC SKU */
> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe145),
> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
> + /* Foxconn T99W696.00, Foxconn SKU */
> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe146),
> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
> { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0308),
> .driver_data = (kernel_ulong_t) &mhi_qcom_sdx65_info },
> { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0309),
> --
> 2.25.1
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re:Re: [PATCH v2] bus: mhi: host: pci_generic: Add Foxconn T99W696
2025-06-17 9:39 ` Manivannan Sadhasivam
@ 2025-06-20 7:01 ` Slark Xiao
2025-06-24 2:50 ` Dmitry Baryshkov
0 siblings, 1 reply; 7+ messages in thread
From: Slark Xiao @ 2025-06-20 7:01 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: manivannan.sadhasivam, johan+linaro, mhi, linux-arm-msm,
linux-kernel
At 2025-06-17 17:39:11, "Manivannan Sadhasivam" <mani@kernel.org> wrote:
>On Wed, May 28, 2025 at 05:22:32PM +0800, Slark Xiao wrote:
>> T99W696 is designed based on Qualcomm SDX61 chip which is a cost
>> down chip refer to previous SDX62/SDX65. Though we have a support
>> on SDX62/SDX65, we create a new channel config for SDX61 since
>> we add a NMEA channel support from this product.
>> For new products we are allowed to customize the subVID and
>> subPID only.
>>
>
>Could you please push the firmware to linux-firmware? I don't expect the users
>of the products to upstream the firmware, but I do expect the vendors to do so.
>
>FYI: Qcom was able to upstream the firmware for one of their modems:
>https://web.git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/qcom/qdu100/xbl_s.melf?id=01842da45df0a9f862098d1597f6ae5774b3e48a
>
>So there should be no licensing issues. Going forward, I want both Qcom and
>vendors to upstream the firmware before the modem support gets in.
>
>- Mani
>
It should be okay. But we are facing that we can't commit files to linux-firmware
since China was banned from that community.
I will share the edl file to you in another mail.
Thanks
>> Signed-off-by: Slark Xiao <slark_xiao@163.com>
>> ---
>> v2: Correct the ch_cfg as sdx61 channels
>> ---
>> drivers/bus/mhi/host/pci_generic.c | 52 ++++++++++++++++++++++++++++++
>> 1 file changed, 52 insertions(+)
>>
>> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
>> index a4a62429c784..a90ab31c46a9 100644
>> --- a/drivers/bus/mhi/host/pci_generic.c
>> +++ b/drivers/bus/mhi/host/pci_generic.c
>> @@ -490,6 +490,23 @@ static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = {
>> MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
>> };
>>
>> +static const struct mhi_channel_config mhi_foxconn_sdx61_channels[] = {
>> + MHI_CHANNEL_CONFIG_UL(0, "LOOPBACK", 32, 0),
>> + MHI_CHANNEL_CONFIG_DL(1, "LOOPBACK", 32, 0),
>> + MHI_CHANNEL_CONFIG_UL(4, "DIAG", 32, 1),
>> + MHI_CHANNEL_CONFIG_DL(5, "DIAG", 32, 1),
>> + MHI_CHANNEL_CONFIG_UL(12, "MBIM", 32, 0),
>> + MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
>> + MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
>> + MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
>> + MHI_CHANNEL_CONFIG_UL_FP(34, "FIREHOSE", 32, 0),
>> + MHI_CHANNEL_CONFIG_DL_FP(35, "FIREHOSE", 32, 0),
>> + MHI_CHANNEL_CONFIG_UL(50, "NMEA", 32, 0),
>> + MHI_CHANNEL_CONFIG_DL(51, "NMEA", 32, 0),
>> + MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
>> + MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
>> +};
>> +
>> static struct mhi_event_config mhi_foxconn_sdx55_events[] = {
>> MHI_EVENT_CONFIG_CTRL(0, 128),
>> MHI_EVENT_CONFIG_DATA(1, 128),
>> @@ -506,6 +523,15 @@ static const struct mhi_controller_config modem_foxconn_sdx55_config = {
>> .event_cfg = mhi_foxconn_sdx55_events,
>> };
>>
>> +static const struct mhi_controller_config modem_foxconn_sdx61_config = {
>> + .max_channels = 128,
>> + .timeout_ms = 20000,
>> + .num_channels = ARRAY_SIZE(mhi_foxconn_sdx61_channels),
>> + .ch_cfg = mhi_foxconn_sdx61_channels,
>> + .num_events = ARRAY_SIZE(mhi_foxconn_sdx55_events),
>> + .event_cfg = mhi_foxconn_sdx55_events,
>> +};
>> +
>> static const struct mhi_controller_config modem_foxconn_sdx72_config = {
>> .max_channels = 128,
>> .timeout_ms = 20000,
>> @@ -615,6 +641,17 @@ static const struct mhi_pci_dev_info mhi_foxconn_dw5934e_info = {
>> .sideband_wake = false,
>> };
>>
>> +static const struct mhi_pci_dev_info mhi_foxconn_t99w696_info = {
>> + .name = "foxconn-t99w696",
>> + .edl = "qcom/sdx61/foxconn/prog_firehose_lite.elf",
>> + .edl_trigger = true,
>> + .config = &modem_foxconn_sdx61_config,
>> + .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
>> + .dma_data_width = 32,
>> + .mru_default = 32768,
>> + .sideband_wake = false,
>> +};
>> +
>> static const struct mhi_channel_config mhi_mv3x_channels[] = {
>> MHI_CHANNEL_CONFIG_UL(0, "LOOPBACK", 64, 0),
>> MHI_CHANNEL_CONFIG_DL(1, "LOOPBACK", 64, 0),
>> @@ -863,6 +900,21 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>> /* Telit FE990A */
>> { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, 0x1c5d, 0x2015),
>> .driver_data = (kernel_ulong_t) &mhi_telit_fe990a_info },
>> + /* Foxconn T99W696.01, Lenovo Generic SKU */
>> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe142),
>> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
>> + /* Foxconn T99W696.02, Lenovo X1 Carbon SKU */
>> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe143),
>> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
>> + /* Foxconn T99W696.03, Lenovo X1 2in1 SKU */
>> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe144),
>> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
>> + /* Foxconn T99W696.04, Lenovo PRC SKU */
>> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe145),
>> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
>> + /* Foxconn T99W696.00, Foxconn SKU */
>> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe146),
>> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
>> { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0308),
>> .driver_data = (kernel_ulong_t) &mhi_qcom_sdx65_info },
>> { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0309),
>> --
>> 2.25.1
>>
>
>--
>மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] bus: mhi: host: pci_generic: Add Foxconn T99W696
2025-06-20 7:01 ` Slark Xiao
@ 2025-06-24 2:50 ` Dmitry Baryshkov
2025-06-24 6:40 ` Slark Xiao
2025-07-08 11:30 ` Slark Xiao
0 siblings, 2 replies; 7+ messages in thread
From: Dmitry Baryshkov @ 2025-06-24 2:50 UTC (permalink / raw)
To: Slark Xiao
Cc: Manivannan Sadhasivam, manivannan.sadhasivam, johan+linaro, mhi,
linux-arm-msm, linux-kernel
On Fri, Jun 20, 2025 at 03:01:25PM +0800, Slark Xiao wrote:
>
>
> At 2025-06-17 17:39:11, "Manivannan Sadhasivam" <mani@kernel.org> wrote:
> >On Wed, May 28, 2025 at 05:22:32PM +0800, Slark Xiao wrote:
> >> T99W696 is designed based on Qualcomm SDX61 chip which is a cost
> >> down chip refer to previous SDX62/SDX65. Though we have a support
> >> on SDX62/SDX65, we create a new channel config for SDX61 since
> >> we add a NMEA channel support from this product.
> >> For new products we are allowed to customize the subVID and
> >> subPID only.
> >>
> >
> >Could you please push the firmware to linux-firmware? I don't expect the users
> >of the products to upstream the firmware, but I do expect the vendors to do so.
> >
> >FYI: Qcom was able to upstream the firmware for one of their modems:
> >https://web.git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/qcom/qdu100/xbl_s.melf?id=01842da45df0a9f862098d1597f6ae5774b3e48a
> >
> >So there should be no licensing issues. Going forward, I want both Qcom and
> >vendors to upstream the firmware before the modem support gets in.
> >
> >- Mani
> >
> It should be okay. But we are facing that we can't commit files to linux-firmware
> since China was banned from that community.
> I will share the edl file to you in another mail.
You can use b4 Web Relay to send patches. Or you can use the git
send-email to send it to the linux-firmware ML. The issue is that
linux-firmware maintainers could not identify you as a valid sender of
the firmware. Either use a Foxconn-related business email to Sign-off
the patch (and probably send the email through Foxconn email channels)
or find somebody in Qualcomm who can acknowledge you as a valid sender
for Foxconn firmware. Otherwise your emails to linux-firmware look like
coming from the random user.
>
> Thanks
> >> Signed-off-by: Slark Xiao <slark_xiao@163.com>
> >> ---
> >> v2: Correct the ch_cfg as sdx61 channels
> >> ---
> >> drivers/bus/mhi/host/pci_generic.c | 52 ++++++++++++++++++++++++++++++
> >> 1 file changed, 52 insertions(+)
> >>
> >> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
> >> index a4a62429c784..a90ab31c46a9 100644
> >> --- a/drivers/bus/mhi/host/pci_generic.c
> >> +++ b/drivers/bus/mhi/host/pci_generic.c
> >> @@ -490,6 +490,23 @@ static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = {
> >> MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
> >> };
> >>
> >> +static const struct mhi_channel_config mhi_foxconn_sdx61_channels[] = {
> >> + MHI_CHANNEL_CONFIG_UL(0, "LOOPBACK", 32, 0),
> >> + MHI_CHANNEL_CONFIG_DL(1, "LOOPBACK", 32, 0),
> >> + MHI_CHANNEL_CONFIG_UL(4, "DIAG", 32, 1),
> >> + MHI_CHANNEL_CONFIG_DL(5, "DIAG", 32, 1),
> >> + MHI_CHANNEL_CONFIG_UL(12, "MBIM", 32, 0),
> >> + MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
> >> + MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
> >> + MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
> >> + MHI_CHANNEL_CONFIG_UL_FP(34, "FIREHOSE", 32, 0),
> >> + MHI_CHANNEL_CONFIG_DL_FP(35, "FIREHOSE", 32, 0),
> >> + MHI_CHANNEL_CONFIG_UL(50, "NMEA", 32, 0),
> >> + MHI_CHANNEL_CONFIG_DL(51, "NMEA", 32, 0),
> >> + MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
> >> + MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
> >> +};
> >> +
> >> static struct mhi_event_config mhi_foxconn_sdx55_events[] = {
> >> MHI_EVENT_CONFIG_CTRL(0, 128),
> >> MHI_EVENT_CONFIG_DATA(1, 128),
> >> @@ -506,6 +523,15 @@ static const struct mhi_controller_config modem_foxconn_sdx55_config = {
> >> .event_cfg = mhi_foxconn_sdx55_events,
> >> };
> >>
> >> +static const struct mhi_controller_config modem_foxconn_sdx61_config = {
> >> + .max_channels = 128,
> >> + .timeout_ms = 20000,
> >> + .num_channels = ARRAY_SIZE(mhi_foxconn_sdx61_channels),
> >> + .ch_cfg = mhi_foxconn_sdx61_channels,
> >> + .num_events = ARRAY_SIZE(mhi_foxconn_sdx55_events),
> >> + .event_cfg = mhi_foxconn_sdx55_events,
> >> +};
> >> +
> >> static const struct mhi_controller_config modem_foxconn_sdx72_config = {
> >> .max_channels = 128,
> >> .timeout_ms = 20000,
> >> @@ -615,6 +641,17 @@ static const struct mhi_pci_dev_info mhi_foxconn_dw5934e_info = {
> >> .sideband_wake = false,
> >> };
> >>
> >> +static const struct mhi_pci_dev_info mhi_foxconn_t99w696_info = {
> >> + .name = "foxconn-t99w696",
> >> + .edl = "qcom/sdx61/foxconn/prog_firehose_lite.elf",
> >> + .edl_trigger = true,
> >> + .config = &modem_foxconn_sdx61_config,
> >> + .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
> >> + .dma_data_width = 32,
> >> + .mru_default = 32768,
> >> + .sideband_wake = false,
> >> +};
> >> +
> >> static const struct mhi_channel_config mhi_mv3x_channels[] = {
> >> MHI_CHANNEL_CONFIG_UL(0, "LOOPBACK", 64, 0),
> >> MHI_CHANNEL_CONFIG_DL(1, "LOOPBACK", 64, 0),
> >> @@ -863,6 +900,21 @@ static const struct pci_device_id mhi_pci_id_table[] = {
> >> /* Telit FE990A */
> >> { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, 0x1c5d, 0x2015),
> >> .driver_data = (kernel_ulong_t) &mhi_telit_fe990a_info },
> >> + /* Foxconn T99W696.01, Lenovo Generic SKU */
> >> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe142),
> >> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
> >> + /* Foxconn T99W696.02, Lenovo X1 Carbon SKU */
> >> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe143),
> >> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
> >> + /* Foxconn T99W696.03, Lenovo X1 2in1 SKU */
> >> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe144),
> >> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
> >> + /* Foxconn T99W696.04, Lenovo PRC SKU */
> >> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe145),
> >> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
> >> + /* Foxconn T99W696.00, Foxconn SKU */
> >> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe146),
> >> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
> >> { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0308),
> >> .driver_data = (kernel_ulong_t) &mhi_qcom_sdx65_info },
> >> { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0309),
> >> --
> >> 2.25.1
> >>
> >
> >--
> >மணிவண்ணன் சதாசிவம்
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re:Re: [PATCH v2] bus: mhi: host: pci_generic: Add Foxconn T99W696
2025-06-24 2:50 ` Dmitry Baryshkov
@ 2025-06-24 6:40 ` Slark Xiao
2025-07-08 11:30 ` Slark Xiao
1 sibling, 0 replies; 7+ messages in thread
From: Slark Xiao @ 2025-06-24 6:40 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Manivannan Sadhasivam, manivannan.sadhasivam, johan+linaro, mhi,
linux-arm-msm, linux-kernel
At 2025-06-24 10:50:11, "Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com> wrote:
>On Fri, Jun 20, 2025 at 03:01:25PM +0800, Slark Xiao wrote:
>>
>>
>> At 2025-06-17 17:39:11, "Manivannan Sadhasivam" <mani@kernel.org> wrote:
>> >On Wed, May 28, 2025 at 05:22:32PM +0800, Slark Xiao wrote:
>> >> T99W696 is designed based on Qualcomm SDX61 chip which is a cost
>> >> down chip refer to previous SDX62/SDX65. Though we have a support
>> >> on SDX62/SDX65, we create a new channel config for SDX61 since
>> >> we add a NMEA channel support from this product.
>> >> For new products we are allowed to customize the subVID and
>> >> subPID only.
>> >>
>> >
>> >Could you please push the firmware to linux-firmware? I don't expect the users
>> >of the products to upstream the firmware, but I do expect the vendors to do so.
>> >
>> >FYI: Qcom was able to upstream the firmware for one of their modems:
>> >https://web.git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/qcom/qdu100/xbl_s.melf?id=01842da45df0a9f862098d1597f6ae5774b3e48a
>> >
>> >So there should be no licensing issues. Going forward, I want both Qcom and
>> >vendors to upstream the firmware before the modem support gets in.
>> >
>> >- Mani
>> >
>> It should be okay. But we are facing that we can't commit files to linux-firmware
>> since China was banned from that community.
>> I will share the edl file to you in another mail.
>
>You can use b4 Web Relay to send patches. Or you can use the git
>send-email to send it to the linux-firmware ML. The issue is that
>linux-firmware maintainers could not identify you as a valid sender of
>the firmware. Either use a Foxconn-related business email to Sign-off
>the patch (and probably send the email through Foxconn email channels)
>or find somebody in Qualcomm who can acknowledge you as a valid sender
>for Foxconn firmware. Otherwise your emails to linux-firmware look like
>coming from the random user.
>
>>
>> Thanks
It's not easy to setup the smtp system for my company email.
So for kernel patches, I always use my own 163 mail to commit pathes
like this. But I just found this mail may not be accepted by linux-firmware
in gitlab.com. So I switch my email from 163 mail to gmail. That's why
I use 2 different mail to send patches.
Anyway, I just used my commpany's email to do an ACK.
Thanks
>> >> Signed-off-by: Slark Xiao <slark_xiao@163.com>
>> >> ---
>> >> v2: Correct the ch_cfg as sdx61 channels
>> >> ---
>> >> drivers/bus/mhi/host/pci_generic.c | 52 ++++++++++++++++++++++++++++++
>> >> 1 file changed, 52 insertions(+)
>> >>
>> >> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
>> >> index a4a62429c784..a90ab31c46a9 100644
>> >> --- a/drivers/bus/mhi/host/pci_generic.c
>> >> +++ b/drivers/bus/mhi/host/pci_generic.c
>> >> @@ -490,6 +490,23 @@ static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = {
>> >> MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
>> >> };
>> >>
>> >> +static const struct mhi_channel_config mhi_foxconn_sdx61_channels[] = {
>> >> + MHI_CHANNEL_CONFIG_UL(0, "LOOPBACK", 32, 0),
>> >> + MHI_CHANNEL_CONFIG_DL(1, "LOOPBACK", 32, 0),
>> >> + MHI_CHANNEL_CONFIG_UL(4, "DIAG", 32, 1),
>> >> + MHI_CHANNEL_CONFIG_DL(5, "DIAG", 32, 1),
>> >> + MHI_CHANNEL_CONFIG_UL(12, "MBIM", 32, 0),
>> >> + MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
>> >> + MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
>> >> + MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
>> >> + MHI_CHANNEL_CONFIG_UL_FP(34, "FIREHOSE", 32, 0),
>> >> + MHI_CHANNEL_CONFIG_DL_FP(35, "FIREHOSE", 32, 0),
>> >> + MHI_CHANNEL_CONFIG_UL(50, "NMEA", 32, 0),
>> >> + MHI_CHANNEL_CONFIG_DL(51, "NMEA", 32, 0),
>> >> + MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
>> >> + MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
>> >> +};
>> >> +
>> >> static struct mhi_event_config mhi_foxconn_sdx55_events[] = {
>> >> MHI_EVENT_CONFIG_CTRL(0, 128),
>> >> MHI_EVENT_CONFIG_DATA(1, 128),
>> >> @@ -506,6 +523,15 @@ static const struct mhi_controller_config modem_foxconn_sdx55_config = {
>> >> .event_cfg = mhi_foxconn_sdx55_events,
>> >> };
>> >>
>> >> +static const struct mhi_controller_config modem_foxconn_sdx61_config = {
>> >> + .max_channels = 128,
>> >> + .timeout_ms = 20000,
>> >> + .num_channels = ARRAY_SIZE(mhi_foxconn_sdx61_channels),
>> >> + .ch_cfg = mhi_foxconn_sdx61_channels,
>> >> + .num_events = ARRAY_SIZE(mhi_foxconn_sdx55_events),
>> >> + .event_cfg = mhi_foxconn_sdx55_events,
>> >> +};
>> >> +
>> >> static const struct mhi_controller_config modem_foxconn_sdx72_config = {
>> >> .max_channels = 128,
>> >> .timeout_ms = 20000,
>> >> @@ -615,6 +641,17 @@ static const struct mhi_pci_dev_info mhi_foxconn_dw5934e_info = {
>> >> .sideband_wake = false,
>> >> };
>> >>
>> >> +static const struct mhi_pci_dev_info mhi_foxconn_t99w696_info = {
>> >> + .name = "foxconn-t99w696",
>> >> + .edl = "qcom/sdx61/foxconn/prog_firehose_lite.elf",
>> >> + .edl_trigger = true,
>> >> + .config = &modem_foxconn_sdx61_config,
>> >> + .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
>> >> + .dma_data_width = 32,
>> >> + .mru_default = 32768,
>> >> + .sideband_wake = false,
>> >> +};
>> >> +
>> >> static const struct mhi_channel_config mhi_mv3x_channels[] = {
>> >> MHI_CHANNEL_CONFIG_UL(0, "LOOPBACK", 64, 0),
>> >> MHI_CHANNEL_CONFIG_DL(1, "LOOPBACK", 64, 0),
>> >> @@ -863,6 +900,21 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>> >> /* Telit FE990A */
>> >> { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, 0x1c5d, 0x2015),
>> >> .driver_data = (kernel_ulong_t) &mhi_telit_fe990a_info },
>> >> + /* Foxconn T99W696.01, Lenovo Generic SKU */
>> >> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe142),
>> >> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
>> >> + /* Foxconn T99W696.02, Lenovo X1 Carbon SKU */
>> >> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe143),
>> >> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
>> >> + /* Foxconn T99W696.03, Lenovo X1 2in1 SKU */
>> >> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe144),
>> >> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
>> >> + /* Foxconn T99W696.04, Lenovo PRC SKU */
>> >> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe145),
>> >> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
>> >> + /* Foxconn T99W696.00, Foxconn SKU */
>> >> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe146),
>> >> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
>> >> { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0308),
>> >> .driver_data = (kernel_ulong_t) &mhi_qcom_sdx65_info },
>> >> { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0309),
>> >> --
>> >> 2.25.1
>> >>
>> >
>> >--
>> >மணிவண்ணன் சதாசிவம்
>
>--
>With best wishes
>Dmitry
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re:Re: [PATCH v2] bus: mhi: host: pci_generic: Add Foxconn T99W696
2025-06-24 2:50 ` Dmitry Baryshkov
2025-06-24 6:40 ` Slark Xiao
@ 2025-07-08 11:30 ` Slark Xiao
1 sibling, 0 replies; 7+ messages in thread
From: Slark Xiao @ 2025-07-08 11:30 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Manivannan Sadhasivam, manivannan.sadhasivam, johan+linaro, mhi,
linux-arm-msm, linux-kernel
At 2025-06-24 10:50:11, "Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com> wrote:
>On Fri, Jun 20, 2025 at 03:01:25PM +0800, Slark Xiao wrote:
>>
>>
>> At 2025-06-17 17:39:11, "Manivannan Sadhasivam" <mani@kernel.org> wrote:
>> >On Wed, May 28, 2025 at 05:22:32PM +0800, Slark Xiao wrote:
>> >> T99W696 is designed based on Qualcomm SDX61 chip which is a cost
>> >> down chip refer to previous SDX62/SDX65. Though we have a support
>> >> on SDX62/SDX65, we create a new channel config for SDX61 since
>> >> we add a NMEA channel support from this product.
>> >> For new products we are allowed to customize the subVID and
>> >> subPID only.
>> >>
>> >
>> >Could you please push the firmware to linux-firmware? I don't expect the users
>> >of the products to upstream the firmware, but I do expect the vendors to do so.
>> >
>> >FYI: Qcom was able to upstream the firmware for one of their modems:
>> >https://web.git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/qcom/qdu100/xbl_s.melf?id=01842da45df0a9f862098d1597f6ae5774b3e48a
>> >
>> >So there should be no licensing issues. Going forward, I want both Qcom and
>> >vendors to upstream the firmware before the modem support gets in.
>> >
>> >- Mani
>> >
>> It should be okay. But we are facing that we can't commit files to linux-firmware
>> since China was banned from that community.
>> I will share the edl file to you in another mail.
>
>You can use b4 Web Relay to send patches. Or you can use the git
>send-email to send it to the linux-firmware ML. The issue is that
>linux-firmware maintainers could not identify you as a valid sender of
>the firmware. Either use a Foxconn-related business email to Sign-off
>the patch (and probably send the email through Foxconn email channels)
>or find somebody in Qualcomm who can acknowledge you as a valid sender
>for Foxconn firmware. Otherwise your emails to linux-firmware look like
>coming from the random user.
>>
>> Thanks
Hi Mani,
The edl file has been merged into linux-firmware. You can refer to below link:
https://gitlab.com/kernel-firmware/linux-firmware/-/merge_requests/594
So please help do a review in driver side. ( Currently LVFS/MM/linux-firmware
support of Foxconn SDX61 are ready, except driver).
Thanks
>> >> Signed-off-by: Slark Xiao <slark_xiao@163.com>
>> >> ---
>> >> v2: Correct the ch_cfg as sdx61 channels
>> >> ---
>> >> drivers/bus/mhi/host/pci_generic.c | 52 ++++++++++++++++++++++++++++++
>> >> 1 file changed, 52 insertions(+)
>> >>
>> >> diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
>> >> index a4a62429c784..a90ab31c46a9 100644
>> >> --- a/drivers/bus/mhi/host/pci_generic.c
>> >> +++ b/drivers/bus/mhi/host/pci_generic.c
>> >> @@ -490,6 +490,23 @@ static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = {
>> >> MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
>> >> };
>> >>
>> >> +static const struct mhi_channel_config mhi_foxconn_sdx61_channels[] = {
>> >> + MHI_CHANNEL_CONFIG_UL(0, "LOOPBACK", 32, 0),
>> >> + MHI_CHANNEL_CONFIG_DL(1, "LOOPBACK", 32, 0),
>> >> + MHI_CHANNEL_CONFIG_UL(4, "DIAG", 32, 1),
>> >> + MHI_CHANNEL_CONFIG_DL(5, "DIAG", 32, 1),
>> >> + MHI_CHANNEL_CONFIG_UL(12, "MBIM", 32, 0),
>> >> + MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
>> >> + MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
>> >> + MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
>> >> + MHI_CHANNEL_CONFIG_UL_FP(34, "FIREHOSE", 32, 0),
>> >> + MHI_CHANNEL_CONFIG_DL_FP(35, "FIREHOSE", 32, 0),
>> >> + MHI_CHANNEL_CONFIG_UL(50, "NMEA", 32, 0),
>> >> + MHI_CHANNEL_CONFIG_DL(51, "NMEA", 32, 0),
>> >> + MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
>> >> + MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
>> >> +};
>> >> +
>> >> static struct mhi_event_config mhi_foxconn_sdx55_events[] = {
>> >> MHI_EVENT_CONFIG_CTRL(0, 128),
>> >> MHI_EVENT_CONFIG_DATA(1, 128),
>> >> @@ -506,6 +523,15 @@ static const struct mhi_controller_config modem_foxconn_sdx55_config = {
>> >> .event_cfg = mhi_foxconn_sdx55_events,
>> >> };
>> >>
>> >> +static const struct mhi_controller_config modem_foxconn_sdx61_config = {
>> >> + .max_channels = 128,
>> >> + .timeout_ms = 20000,
>> >> + .num_channels = ARRAY_SIZE(mhi_foxconn_sdx61_channels),
>> >> + .ch_cfg = mhi_foxconn_sdx61_channels,
>> >> + .num_events = ARRAY_SIZE(mhi_foxconn_sdx55_events),
>> >> + .event_cfg = mhi_foxconn_sdx55_events,
>> >> +};
>> >> +
>> >> static const struct mhi_controller_config modem_foxconn_sdx72_config = {
>> >> .max_channels = 128,
>> >> .timeout_ms = 20000,
>> >> @@ -615,6 +641,17 @@ static const struct mhi_pci_dev_info mhi_foxconn_dw5934e_info = {
>> >> .sideband_wake = false,
>> >> };
>> >>
>> >> +static const struct mhi_pci_dev_info mhi_foxconn_t99w696_info = {
>> >> + .name = "foxconn-t99w696",
>> >> + .edl = "qcom/sdx61/foxconn/prog_firehose_lite.elf",
>> >> + .edl_trigger = true,
>> >> + .config = &modem_foxconn_sdx61_config,
>> >> + .bar_num = MHI_PCI_DEFAULT_BAR_NUM,
>> >> + .dma_data_width = 32,
>> >> + .mru_default = 32768,
>> >> + .sideband_wake = false,
>> >> +};
>> >> +
>> >> static const struct mhi_channel_config mhi_mv3x_channels[] = {
>> >> MHI_CHANNEL_CONFIG_UL(0, "LOOPBACK", 64, 0),
>> >> MHI_CHANNEL_CONFIG_DL(1, "LOOPBACK", 64, 0),
>> >> @@ -863,6 +900,21 @@ static const struct pci_device_id mhi_pci_id_table[] = {
>> >> /* Telit FE990A */
>> >> { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, 0x1c5d, 0x2015),
>> >> .driver_data = (kernel_ulong_t) &mhi_telit_fe990a_info },
>> >> + /* Foxconn T99W696.01, Lenovo Generic SKU */
>> >> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe142),
>> >> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
>> >> + /* Foxconn T99W696.02, Lenovo X1 Carbon SKU */
>> >> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe143),
>> >> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
>> >> + /* Foxconn T99W696.03, Lenovo X1 2in1 SKU */
>> >> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe144),
>> >> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
>> >> + /* Foxconn T99W696.04, Lenovo PRC SKU */
>> >> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe145),
>> >> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
>> >> + /* Foxconn T99W696.00, Foxconn SKU */
>> >> + { PCI_DEVICE_SUB(PCI_VENDOR_ID_QCOM, 0x0308, PCI_VENDOR_ID_FOXCONN, 0xe146),
>> >> + .driver_data = (kernel_ulong_t) &mhi_foxconn_t99w696_info },
>> >> { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0308),
>> >> .driver_data = (kernel_ulong_t) &mhi_qcom_sdx65_info },
>> >> { PCI_DEVICE(PCI_VENDOR_ID_QCOM, 0x0309),
>> >> --
>> >> 2.25.1
>> >>
>> >
>> >--
>> >மணிவண்ணன் சதாசிவம்
>
>--
>With best wishes
>Dmitry
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] bus: mhi: host: pci_generic: Add Foxconn T99W696
2025-05-28 9:22 [PATCH v2] bus: mhi: host: pci_generic: Add Foxconn T99W696 Slark Xiao
2025-06-17 9:39 ` Manivannan Sadhasivam
@ 2025-07-08 12:49 ` Manivannan Sadhasivam
1 sibling, 0 replies; 7+ messages in thread
From: Manivannan Sadhasivam @ 2025-07-08 12:49 UTC (permalink / raw)
To: johan+linaro, mhi, Manivannan Sadhasivam, Slark Xiao
Cc: linux-arm-msm, linux-kernel
On Wed, 28 May 2025 17:22:32 +0800, Slark Xiao wrote:
> T99W696 is designed based on Qualcomm SDX61 chip which is a cost
> down chip refer to previous SDX62/SDX65. Though we have a support
> on SDX62/SDX65, we create a new channel config for SDX61 since
> we add a NMEA channel support from this product.
> For new products we are allowed to customize the subVID and
> subPID only.
>
> [...]
Applied, thanks!
[1/1] bus: mhi: host: pci_generic: Add Foxconn T99W696
commit: 7a793ba2cc4a9ef59ab290d50cd847d314514323
Best regards,
--
Manivannan Sadhasivam <mani@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-07-08 12:49 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-28 9:22 [PATCH v2] bus: mhi: host: pci_generic: Add Foxconn T99W696 Slark Xiao
2025-06-17 9:39 ` Manivannan Sadhasivam
2025-06-20 7:01 ` Slark Xiao
2025-06-24 2:50 ` Dmitry Baryshkov
2025-06-24 6:40 ` Slark Xiao
2025-07-08 11:30 ` Slark Xiao
2025-07-08 12:49 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).