From: "Miguel Gómez" <magomez@igalia.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: arnaud.patard@rtp-net.org, aaro.koskinen@iki.fi,
dan.carpenter@oracle.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/19 v2] Staging: xgifb: Remove LCDA detection in xgifb_probe().
Date: Fri, 13 Jul 2012 16:02:30 +0200 [thread overview]
Message-ID: <50002A76.6000609@igalia.com> (raw)
In-Reply-To: <20120709183947.GA21153@kroah.com>
El 09/07/12 20:39, Greg KH escribió:
> On Fri, Jul 06, 2012 at 12:40:38PM +0200, Miguel Gómez wrote:
>> The piece of code that checks for LCDA in xgifb_probe() just checks for some
>> register values but doesn't really do anything in response to them (the actions
>> that should be executed are commented).
>> As nothing is really being done, the code can be safely removed.
>
> Are you sure? Some devices (foolish ones that is) need registers read
> to work properly as that is part of their start-up logic. Yeah, it
> doesn't seem to make sense, but hardware designers usually have good
> reasons for doing this type of thing. Or at least they think they do :)
Weird... I didn't expect that some devices might need those reads to
work properly... I'm writing down that comment for the future ;)
> So have you tested the device after this change and it all works
> properly? You do have this device, right?
I have an XGI Z7 card that I use for testing, and it doesn't require
those reads to work properly, despite I don't have a Z9 or Z11 to test.
But according to Aaro's comment, it seems that the patch is safe as
these register reads don't have any effect.
Regards!
--
Miguel Gómez
Igalia - http://www.igalia.com
next prev parent reply other threads:[~2012-07-13 14:02 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 14:45 [PATCH 00/19] Several cleanings and style fixes Miguel Gómez
2012-07-05 14:45 ` [PATCH 01/19] Staging: xgifb: Comment cleaning Miguel Gómez
2012-07-05 17:24 ` Aaro Koskinen
2012-07-06 8:00 ` Miguel Gómez
2012-07-05 17:35 ` Joe Perches
2012-07-06 8:02 ` Miguel Gómez
2012-07-05 20:35 ` Dan Carpenter
2012-07-06 8:14 ` Miguel Gómez
2012-07-05 14:45 ` [PATCH 02/19] Staging: xgifb: Remove unneeded XGI_LCD_TYPE enumeration Miguel Gómez
2012-07-05 14:45 ` [PATCH 03/19] Staging: xgifb: Remove LCDA detection in xgifb_probe() Miguel Gómez
2012-07-05 14:45 ` [PATCH 04/19] Staging: xgifb: Remove unused struct _chswtable Miguel Gómez
2012-07-05 14:45 ` [PATCH 05/19] Staging: xgifb: Improve debug strings Miguel Gómez
2012-07-05 17:42 ` Aaro Koskinen
2012-07-06 8:09 ` Miguel Gómez
2012-07-05 14:45 ` [PATCH 06/19] Staging: xgifb: Remove useless switch in XGIfb_detect_VB() Miguel Gómez
2012-07-05 14:45 ` [PATCH 07/19] Staging: xgifb: Simplify XGIfb_GetXG21DefaultLVDSModeIdx() Miguel Gómez
2012-07-05 14:45 ` [PATCH 08/19] Staging: xgifb: Remove unneeded var and condition in XGIfb_search_vesamode() Miguel Gómez
2012-07-05 14:45 ` [PATCH 09/19] Staging: xgifb: Remove useless always true condition Miguel Gómez
2012-07-05 14:45 ` [PATCH 10/19] Staging: xgifb: Rework conditions in XGI_SetATTRegs() Miguel Gómez
2012-07-05 14:45 ` [PATCH 11/19] Staging: xgifb: Refactor XGI_AjustCRT2Rate() Miguel Gómez
2012-07-05 14:45 ` [PATCH 12/19] Staging: xgifb: Refactor XGI_GetVBType() Miguel Gómez
2012-07-05 14:45 ` [PATCH 13/19] Staging: xgifb: Rework conditions in XGI_GetVBInfo() Miguel Gómez
2012-07-05 14:45 ` [PATCH 14/19] Staging: xgifb: Refactor XGI_GetCRT2ResInfo() Miguel Gómez
2012-07-05 14:45 ` [PATCH 15/19] Staging: xgifb: Rework conditions in XGI_SetLockRegs() Miguel Gómez
2012-07-05 18:00 ` Aaro Koskinen
2012-07-06 8:12 ` Miguel Gómez
2012-07-06 6:51 ` Dan Carpenter
2012-07-06 9:04 ` Miguel Gómez
2012-07-06 10:27 ` Dan Carpenter
2012-07-05 14:45 ` [PATCH 16/19] Staging: xgifb: Rework conditions in XGI_EnableBridge() Miguel Gómez
2012-07-05 14:46 ` [PATCH 17/19] Staging: xgifb: Rework some conditions in XGI_SetCRT2ModeRegs() Miguel Gómez
2012-07-05 14:46 ` [PATCH 18/19] Staging: xgifb: Fix coding style Miguel Gómez
2012-07-05 14:46 ` [PATCH 19/19] Staging: xgifb: Remove useless condition Miguel Gómez
2012-07-06 10:40 ` [PATCH 00/19 v2] Several cleanings and style fixes Miguel Gómez
2012-07-06 10:40 ` [PATCH 01/19 v2] Staging: xgifb: Comment cleaning Miguel Gómez
2012-07-06 10:40 ` [PATCH 02/19 v2] Staging: xgifb: Remove unneeded XGI_LCD_TYPE enumeration Miguel Gómez
2012-07-06 10:40 ` [PATCH 03/19 v2] Staging: xgifb: Remove LCDA detection in xgifb_probe() Miguel Gómez
2012-07-09 18:39 ` Greg KH
2012-07-09 22:08 ` Aaro Koskinen
2012-07-13 14:02 ` Miguel Gómez [this message]
2012-07-06 10:40 ` [PATCH 04/19 v2] Staging: xgifb: Remove unused struct _chswtable Miguel Gómez
2012-07-06 10:40 ` [PATCH 05/19 v2] Staging: xgifb: Improve debug strings Miguel Gómez
2012-07-06 10:40 ` [PATCH 06/19 v2] Staging: xgifb: Remove useless switch in XGIfb_detect_VB() Miguel Gómez
2012-07-06 10:40 ` [PATCH 07/19 v2] Staging: xgifb: Simplify XGIfb_GetXG21DefaultLVDSModeIdx() Miguel Gómez
2012-07-06 10:40 ` [PATCH 08/19 v2] Staging: xgifb: Remove unneeded var and condition in XGIfb_search_vesamode() Miguel Gómez
2012-07-06 10:40 ` [PATCH 09/19 v2] Staging: xgifb: Remove useless always true condition Miguel Gómez
2012-07-06 10:40 ` [PATCH 10/19 v2] Staging: xgifb: Rework conditions in XGI_SetATTRegs() Miguel Gómez
2012-07-06 10:40 ` [PATCH 11/19 v2] Staging: xgifb: Refactor XGI_AjustCRT2Rate() Miguel Gómez
2012-07-06 10:40 ` [PATCH 12/19 v2] Staging: xgifb: Refactor XGI_GetVBType() Miguel Gómez
2012-07-06 10:40 ` [PATCH 13/19 v2] Staging: xgifb: Rework conditions in XGI_GetVBInfo() Miguel Gómez
2012-07-06 10:40 ` [PATCH 14/19 v2] Staging: xgifb: Refactor XGI_GetCRT2ResInfo() Miguel Gómez
2012-07-06 10:40 ` [PATCH 15/19 v2] Staging: xgifb: Rework conditions in XGI_SetLockRegs() Miguel Gómez
2012-07-06 10:40 ` [PATCH 16/19 v2] Staging: xgifb: Rework conditions in XGI_EnableBridge() Miguel Gómez
2012-07-06 10:40 ` [PATCH 17/19 v2] Staging: xgifb: Rework some conditions in XGI_SetCRT2ModeRegs() Miguel Gómez
2012-07-06 10:40 ` [PATCH 18/19 v2] Staging: xgifb: Fix coding style Miguel Gómez
2012-07-06 10:40 ` [PATCH 19/19 v2] Staging: xgifb: Remove useless condition Miguel Gómez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50002A76.6000609@igalia.com \
--to=magomez@igalia.com \
--cc=aaro.koskinen@iki.fi \
--cc=arnaud.patard@rtp-net.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox