From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756044AbcASPEX (ORCPT ); Tue, 19 Jan 2016 10:04:23 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:51428 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753920AbcASPEO (ORCPT ); Tue, 19 Jan 2016 10:04:14 -0500 From: Arnd Bergmann To: Herbert Xu Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, Krzysztof =?utf-8?B?SGHFgmFzYQ==?= Subject: Re: [PATCH] crypto: ixp4xx: avoid uninitialized variable use Date: Tue, 19 Jan 2016 16:03:50 +0100 Message-ID: <5000322.oxUQo4qxNF@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160119010021.GB5571@gondor.apana.org.au> References: <4569235.PkyVAB6DSj@wuerfel> <20160119010021.GB5571@gondor.apana.org.au> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:ftwa2K9wITshpDGqS6AzbQHO6Cabq46mWF3OOufQXC5tgbLPtdB lYySBWqk4BxUQu8p4L11aE/lSy++73k+XWwVLoBL0z7H835OEryGwhgOtirDFaBtiRulW93 1YhjaQcx4strqUGconTM8ixu9tu9vabwNgdTbr25UZKX0Ym9vZpd0i9ObuLbH+Hf08MN1X8 gE/+M0EjHr90nRhv0kT1g== X-UI-Out-Filterresults: notjunk:1;V01:K0:GqBVwW/aIxA=:ZM6zRb4mVsBIQ3piJRi6yI DxJ8BWeoWKEagaFu/0wi9NkHU6j292x4t75STIuVzXnE6qUHf1Cc+lVHQXg1dU1891v7Z7jAf KRBv5vZuaRKXRSPelA8BtVCQqYk2Cvpy7bNz8P9dJQQHkBKiQzX1wwDCKVHSjMLSHVQKt/S2f NJkSPRw3+dSfaoouI/k5oWTAfGDYNTLhbLWpBvLt35d6cXhixyifen83neUlX1NDpkujABEbF eUZ1bI19OSvWSXk1OHS/vjLzeUcU/10apamAcvmNdx2oP89/ekpyx7BOsDicvO+nrgqAzuiJ6 9PAXiTllVKjM5CcXKQvUx2UBiFRlhyjBLlEOZkjFplvSqkfhnD9JMuRwyrPSZqAmW3V+j5/6X yAtYIA4A98Ln9rGx5q0IvomnocMZPzBFc9RVE1HZnR0ovmJrY7+AHuI/UY0xlFPEu7b7EZ7wL gAVrucfkn7LqGcQjhaaAbJacYMauobxNVpVBTfe4zI4yMwZHHA8xZt8+Xu7cCS2EJNt7dBPKP AW2xrvXXK/8H3+l0LDUTXX6CF4NgXGcWKachraFEwH/sVyp5sJtHQXFbs7jPAIG7jwXH3EPFn 1BI8w79HfS7m2+Eceq180ruC1oNS6SsKstIDEf3g1y15cCHOfGhvUR5EK9o6R2n+O1go0PGu/ pzmsW2ydv+chX8DFUyxAxdlGNVicZSeAoX/SIrtUT4JH+hWsxJSbnD/ICv1mgOASS375Tr/To Uzxg+yT9uhYeS/ZE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 19 January 2016 09:00:21 Herbert Xu wrote: > Subject: crypto: ixp4xx - Fix false lastlen uninitialised warning > > This patch fixes a false positive uninitialised variable warning > in aead_perform by moving the source processing in front of the > destination processing, thus ensuring that the initialisation of > lastlen is always visible to gcc. > > Reported-by: Arnd Bergmann > Signed-off-by: Herbert Xu > I've checked that the warnings are now gone, and after reviewing the code again, I see now that it was indeed a false positive, contrary to what I thought before. Patch looks good. Acked-by: Arnd Bergmann