From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030721Ab2GMRwU (ORCPT ); Fri, 13 Jul 2012 13:52:20 -0400 Received: from g1t0027.austin.hp.com ([15.216.28.34]:4156 "EHLO g1t0027.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754748Ab2GMRwT (ORCPT ); Fri, 13 Jul 2012 13:52:19 -0400 Message-ID: <5000604F.80804@hp.com> Date: Fri, 13 Jul 2012 11:52:15 -0600 From: Khalid Aziz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: Matthew Garrett CC: linux-kernel@vger.kernel.org, tony.luck@intel.com, mikew@google.com, keescook@chromium.org, gong.chen@linux.intel.com Subject: Re: [PATCH] Add missing attributes to EFI variable attribute print out from sysfs References: <20120713153827.GA8007@hp.com> <20120713154645.GA16059@srcf.ucam.org> In-Reply-To: <20120713154645.GA16059@srcf.ucam.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/13/2012 09:46 AM, Matthew Garrett wrote: > I know you're just following the pattern of the existing code, but could > you change these to be more like > > if (var->Attributes & EFI_VARIABLE_RUNTIME_ACCESS) > > while you're at it? I think that'd be a worthwhile cleanup. > I just sent out an updated patch with this change. The constant names for EFI variable attribute are pretty darn long and cause line wrap fairly quickly. I would like to rename those constants from EFI_VARIABLE_* to EFI_VAR_* and possibly shorten the overall name as well: EFI_VARIABLE_NON_VOLATILE -> EFI_VAR_NV EFI_VARIABLE_BOOTSERVICE_ACCESS -> EFI_VAR_BOOT EFI_VARIABLE_RUNTIME_ACCESS -> EFI_VAR_RUNTIME EFI_VARIABLE_HARDWARE_ERROR_RECORD -> EFI_VAR_HW_ERROR EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS -> EFI_VAR_AUTH_WRITE EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS -> EFI_VAR_TIMED_AUTH_WRITE EFI_VARIABLE_APPEND_WRITE -> EFI_VAR_APPEND Sounds reasonable? -- Khalid Aziz khalid.aziz@hp.com