Re: [PATCH] Add missing attributes to EFI variable attribute print out from sysfs

Khalid Aziz
2012-07-13T17:52:20Z

On 07/13/2012 09:46 AM, Matthew Garrett wrote:

> I know you're just following the pattern of the existing code, but could
> you change these to be more like
>
> if (var->Attributes & EFI_VARIABLE_RUNTIME_ACCESS)
>
> while you're at it? I think that'd be a worthwhile cleanup.
>
I just sent out an updated patch with this change. The constant names
for EFI variable attribute are pretty darn long and cause line wrap
fairly quickly. I would like to rename those constants from EFI_VARIABLE_*
to EFI_VAR_* and possibly shorten the overall name as well:

EFI_VARIABLE_NON_VOLATILE -> EFI_VAR_NV
EFI_VARIABLE_BOOTSERVICE_ACCESS -> EFI_VAR_BOOT
EFI_VARIABLE_RUNTIME_ACCESS -> EFI_VAR_RUNTIME
EFI_VARIABLE_HARDWARE_ERROR_RECORD -> EFI_VAR_HW_ERROR
EFI_VARIABLE_AUTHENTICATED_WRITE_ACCESS -> EFI_VAR_AUTH_WRITE
EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS -> EFI_VAR_TIMED_AUTH_WRITE
EFI_VARIABLE_APPEND_WRITE -> EFI_VAR_APPEND

Sounds reasonable?