Re: [PATCH] Add missing attributes to EFI variable attribute print out from sysfs

Matthew Garrett
2012-07-13T15:46:52Z

On Fri, Jul 13, 2012 at 09:38:27AM -0600, Khalid Aziz wrote:
> if (var->Attributes & 0x4)
> str += sprintf(str, "EFI_VARIABLE_RUNTIME_ACCESS\n");

I know you're just following the pattern of the existing code, but could
you change these to be more like

if (var->Attributes & EFI_VARIABLE_RUNTIME_ACCESS)

while you're at it? I think that'd be a worthwhile cleanup.

--
Matthew Garrett | mjg59@srcf.ucam.org