From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752597Ab2GPJZy (ORCPT ); Mon, 16 Jul 2012 05:25:54 -0400 Received: from na3sys009aog132.obsmtp.com ([74.125.149.250]:37843 "EHLO na3sys009aog132.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751518Ab2GPJZv (ORCPT ); Mon, 16 Jul 2012 05:25:51 -0400 Message-ID: <5003DE18.7010107@ti.com> Date: Mon, 16 Jul 2012 14:55:44 +0530 From: Rajendra Nayak User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.20) Gecko/20110805 Thunderbird/3.1.12 MIME-Version: 1.0 To: Axel Lin CC: Mark Brown , Peter Ujfalusi , Liam Girdwood , linux-kernel@vger.kernel.org, Graeme Gregory , loml Subject: Re: [PATCH RFT 2/2] regulator: twl: Convert twlsmps_ops to get_voltage_sel and map_voltage References: <1342244233.4207.1.camel@phoenix> <1342244483.4207.4.camel@phoenix> In-Reply-To: <1342244483.4207.4.camel@phoenix> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Copying Graeme and linux-omap list. On Saturday 14 July 2012 11:11 AM, Axel Lin wrote: > Signed-off-by: Axel Lin > --- > drivers/regulator/twl-regulator.c | 24 +++++++++++++----------- > 1 file changed, 13 insertions(+), 11 deletions(-) > > diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c > index 03d0bea..8dae1e3 100644 > --- a/drivers/regulator/twl-regulator.c > +++ b/drivers/regulator/twl-regulator.c > @@ -755,12 +755,11 @@ static int twl6030smps_list_voltage(struct regulator_dev *rdev, unsigned index) > return voltage; > } > > -static int > -twl6030smps_set_voltage(struct regulator_dev *rdev, int min_uV, int max_uV, > - unsigned int *selector) > +static int twl6030smps_map_voltage(struct regulator_dev *rdev, int min_uV, > + int max_uV) > { > - struct twlreg_info *info = rdev_get_drvdata(rdev); > - int vsel = 0, calc_uV; > + struct twlreg_info *info = rdev_get_drvdata(rdev); > + int vsel = 0; > > switch (info->flags) { > case 0: > @@ -827,14 +826,16 @@ twl6030smps_set_voltage(struct regulator_dev *rdev, int min_uV, int max_uV, > break; > } > > - calc_uV = twl6030smps_list_voltage(rdev, vsel); > - if (calc_uV> max_uV) > - return -EINVAL; > + return vsel; > +} > > - *selector = vsel; > +static int twl6030smps_set_voltage_sel(struct regulator_dev *rdev, > + unsigned int selector) > +{ > + struct twlreg_info *info = rdev_get_drvdata(rdev); > > return twlreg_write(info, TWL_MODULE_PM_RECEIVER, VREG_VOLTAGE_SMPS, > - vsel); > + selector); > } > > static int twl6030smps_get_voltage_sel(struct regulator_dev *rdev) > @@ -846,8 +847,9 @@ static int twl6030smps_get_voltage_sel(struct regulator_dev *rdev) > > static struct regulator_ops twlsmps_ops = { > .list_voltage = twl6030smps_list_voltage, > + .map_voltage = twl6030smps_map_voltage, > > - .set_voltage = twl6030smps_set_voltage, > + .set_voltage_sel = twl6030smps_set_voltage_sel, > .get_voltage_sel = twl6030smps_get_voltage_sel, > > .enable = twl6030reg_enable,