From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Denis Turischev <denis@compulab.co.il>
Cc: Sarah Sharp <sarah.a.sharp@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] xhci: EHCI/xHCI ports switching on Intense-PC.
Date: Tue, 17 Jul 2012 16:20:48 +0400 [thread overview]
Message-ID: <500558A0.6050609@mvista.com> (raw)
In-Reply-To: <5004454E.9030903@compulab.co.il>
Hello.
On 16-07-2012 20:46, Denis Turischev wrote:
> Intense-PC is Compulab's mini-desktop with Intel Panther Point
> chipset.
> Unconditional ports switching provided by function
> usb_enable_xhci_ports() leads to surprising results, after shutdown
> system powered-on again after a few seconds. On Windows power
> related problems were not observed.
> The patch avoids ports switching for Intense-PC.
> Signed-off-by: Denis Turischev <denis@compulab.co.il>
> ---
> drivers/usb/host/pci-quirks.c | 7 +++++++
> 1 file changed, 7 insertions(+)
> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
> index df0828c..6f72593 100644
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -759,6 +759,13 @@ void usb_enable_xhci_ports(struct pci_dev *xhci_pdev)
> {
> u32 ports_available;
>
> + const char *brd_name;
Group this declaration with the above one please.
> + brd_name = dmi_get_system_info(DMI_BOARD_NAME);
Could be an initializer...
WBR, Sergei
prev parent reply other threads:[~2012-07-17 12:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 16:46 [PATCH] xhci: EHCI/xHCI ports switching on Intense-PC Denis Turischev
2012-07-17 4:54 ` Sarah Sharp
2012-07-18 6:57 ` Denis Turischev
2012-07-18 16:59 ` Sarah Sharp
2012-07-23 11:46 ` [PATCH 1/2] xhci: provide usb_disable_xhci_ports function for Intel chipsets Denis Turischev
2012-07-23 14:45 ` Sergei Shtylyov
2012-07-23 15:59 ` [PATCH 1/2 v2] " Denis Turischev
2012-07-23 11:46 ` [PATCH 2/2] xhci: EHCI/XHCI ports switching on Intense-PC Denis Turischev
2012-07-23 17:44 ` Sarah Sharp
2012-07-24 8:50 ` Denis Turischev
2012-07-24 19:46 ` Sarah Sharp
2012-07-30 22:34 ` Sarah Sharp
2012-07-31 4:49 ` Oliver Neukum
2012-07-31 17:06 ` Sarah Sharp
2012-07-31 18:39 ` Sarah Sharp
2012-07-31 10:42 ` Denis Turischev
2012-08-07 17:35 ` Sarah Sharp
2012-08-07 17:39 ` [RFT] xhci: Switch PPT ports to EHCI on shutdown Sarah Sharp
2012-08-09 14:31 ` Denis Turischev
2012-08-23 4:30 ` Robert Hancock
2012-07-17 12:20 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500558A0.6050609@mvista.com \
--to=sshtylyov@mvista.com \
--cc=denis@compulab.co.il \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox