* Re: uprobes: fix uprobe tracer wrong documentation
[not found] <CACV3sb+mHoxLWtEGbxzGQ8Lfn2JDc5F=PNMMfmU2Ayw4-JHb+w@mail.gmail.com>
@ 2012-07-16 11:16 ` Srikar Dronamraju
2012-07-18 2:44 ` Rob Landley
1 sibling, 0 replies; 2+ messages in thread
From: Srikar Dronamraju @ 2012-07-16 11:16 UTC (permalink / raw)
To: Jovi Zhang; +Cc: rob, Ingo Molnar, linux-doc, LKML
* Jovi Zhang <bookjovi@gmail.com> [2012-07-16 16:49:03]:
> From e382d2d14b8177bcd2e6bac2fee004fd1f052cb5 Mon Sep 17 00:00:00 2001
> From: Jovi Zhang <bookjovi@gmail.com>
> Date: Tue, 17 Jul 2012 00:35:30 +0800
> Subject: [PATCH] uprobes: fix uprobe tracer wrong documentation
>
> The uprobe example is wrong in current kernel:
> $ echo 'p: /bin/bash:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events
> -bash: echo: write error: Invalid argument
>
> It should be as following:
> $ echo 'p /bin/bash:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events
Right, the colon is only needed if we want to provide the optional event
name.
>
> Signed-off-by: Jovi Zhang <bookjovi@gmail.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> ---
> Documentation/trace/uprobetracer.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/trace/uprobetracer.txt
> b/Documentation/trace/uprobetracer.txt
> index 24ce682..8932726 100644
> --- a/Documentation/trace/uprobetracer.txt
> +++ b/Documentation/trace/uprobetracer.txt
> @@ -40,7 +40,7 @@ Usage examples
> To add a probe as a new event, write a new definition to uprobe_events
> as below.
>
> - echo 'p: /bin/bash:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events
> + echo 'p /bin/bash:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events
>
> This sets a uprobe at an offset of 0x4245c0 in the executable /bin/bash
>
> --
> 1.7.9.7
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: uprobes: fix uprobe tracer wrong documentation
[not found] <CACV3sb+mHoxLWtEGbxzGQ8Lfn2JDc5F=PNMMfmU2Ayw4-JHb+w@mail.gmail.com>
2012-07-16 11:16 ` uprobes: fix uprobe tracer wrong documentation Srikar Dronamraju
@ 2012-07-18 2:44 ` Rob Landley
1 sibling, 0 replies; 2+ messages in thread
From: Rob Landley @ 2012-07-18 2:44 UTC (permalink / raw)
To: Jovi Zhang; +Cc: Ingo Molnar, linux-doc, LKML, srikar
On 07/16/2012 03:49 AM, Jovi Zhang wrote:
> From e382d2d14b8177bcd2e6bac2fee004fd1f052cb5 Mon Sep 17 00:00:00 2001
> From: Jovi Zhang <bookjovi@gmail.com <mailto:bookjovi@gmail.com>>
> Date: Tue, 17 Jul 2012 00:35:30 +0800
> Subject: [PATCH] uprobes: fix uprobe tracer wrong documentation
>
> The uprobe example is wrong in current kernel:
> $ echo 'p: /bin/bash:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events
> -bash: echo: write error: Invalid argument
>
> It should be as following:
> $ echo 'p /bin/bash:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events
>
> Signed-off-by: Jovi Zhang <bookjovi@gmail.com <mailto:bookjovi@gmail.com>>
> ---
> Documentation/trace/uprobetracer.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/trace/uprobetracer.txt
> b/Documentation/trace/uprobetracer.txt
> index 24ce682..8932726 100644
> --- a/Documentation/trace/uprobetracer.txt
> +++ b/Documentation/trace/uprobetracer.txt
> @@ -40,7 +40,7 @@ Usage examples
> To add a probe as a new event, write a new definition to uprobe_events
> as below.
>
> - echo 'p: /bin/bash:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events
> + echo 'p /bin/bash:0x4245c0' > /sys/kernel/debug/tracing/uprobe_events
>
> This sets a uprobe at an offset of 0x4245c0 in the executable /bin/bash
Acked. Tracking, and I'll forward if nobody else pipes up before the
merge window opens.
Rob
--
GNU/Linux isn't: Linux=GPLv2, GNU=GPLv3+, they can't share code.
Either it's "mere aggregation", or a license violation. Pick one.
^ permalink raw reply [flat|nested] 2+ messages in thread