* spi/omap2: mark omap2_mcspi_master_setup as __devinit
@ 2012-07-19 14:52 Arnd Bergmann
2012-07-19 16:43 ` Shubhrajyoti
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2012-07-19 14:52 UTC (permalink / raw)
To: Grant Likely; +Cc: spi-devel-general, linux-kernel, Shubhrajyoti D
This warning recently appeared with omap2plus_defconfig:
WARNING: drivers/spi/built-in.o(.devinit.text+0x3c4): Section mismatch in reference from the function omap2_mcspi_probe() to the function .init.text:omap2_mcspi_master_setup()
The function __devinit omap2_mcspi_probe() references
a function __init omap2_mcspi_master_setup().
If omap2_mcspi_master_setup is only used by omap2_mcspi_probe then
annotate omap2_mcspi_master_setup with a matching annotation.
The fix is obviously to mark the omap2_mcspi_master_setup function as
__devinit, rather than __init.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
index 0c73dd4..dc02f2f 100644
--- a/drivers/spi/spi-omap2-mcspi.c
+++ b/drivers/spi/spi-omap2-mcspi.c
@@ -1032,7 +1032,7 @@ static int omap2_mcspi_transfer_one_message(struct spi_master *master,
return 0;
}
-static int __init omap2_mcspi_master_setup(struct omap2_mcspi *mcspi)
+static int __devinit omap2_mcspi_master_setup(struct omap2_mcspi *mcspi)
{
struct spi_master *master = mcspi->master;
struct omap2_mcspi_regs *ctx = &mcspi->ctx;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: spi/omap2: mark omap2_mcspi_master_setup as __devinit
2012-07-19 14:52 spi/omap2: mark omap2_mcspi_master_setup as __devinit Arnd Bergmann
@ 2012-07-19 16:43 ` Shubhrajyoti
0 siblings, 0 replies; 2+ messages in thread
From: Shubhrajyoti @ 2012-07-19 16:43 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Grant Likely, spi-devel-general, linux-kernel, broonie
+Mark
Since Grant is moving to a new house.
On Thursday 19 July 2012 08:22 PM, Arnd Bergmann wrote:
> This warning recently appeared with omap2plus_defconfig:
>
> WARNING: drivers/spi/built-in.o(.devinit.text+0x3c4): Section mismatch in reference from the function omap2_mcspi_probe() to the function .init.text:omap2_mcspi_master_setup()
> The function __devinit omap2_mcspi_probe() references
> a function __init omap2_mcspi_master_setup().
> If omap2_mcspi_master_setup is only used by omap2_mcspi_probe then
> annotate omap2_mcspi_master_setup with a matching annotation.
>
> The fix is obviously to mark the omap2_mcspi_master_setup function as
> __devinit, rather than __init.
Acked-by: Shubhrajyoti D <shubhrajyoti@ti.com <mailto:shubhrajyoti@ti.com>>
Thanks for the patch.
Apologies for breaking in one my patch series.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
> index 0c73dd4..dc02f2f 100644
> --- a/drivers/spi/spi-omap2-mcspi.c
> +++ b/drivers/spi/spi-omap2-mcspi.c
> @@ -1032,7 +1032,7 @@ static int omap2_mcspi_transfer_one_message(struct spi_master *master,
> return 0;
> }
>
> -static int __init omap2_mcspi_master_setup(struct omap2_mcspi *mcspi)
> +static int __devinit omap2_mcspi_master_setup(struct omap2_mcspi *mcspi)
> {
> struct spi_master *master = mcspi->master;
> struct omap2_mcspi_regs *ctx = &mcspi->ctx;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-07-19 16:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-19 14:52 spi/omap2: mark omap2_mcspi_master_setup as __devinit Arnd Bergmann
2012-07-19 16:43 ` Shubhrajyoti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).