From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752902Ab2GTByO (ORCPT ); Thu, 19 Jul 2012 21:54:14 -0400 Received: from mga02.intel.com ([134.134.136.20]:51275 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752589Ab2GTByN (ORCPT ); Thu, 19 Jul 2012 21:54:13 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.67,352,1309762800"; d="scan'208";a="168738933" Message-ID: <5008BA43.3050301@intel.com> Date: Fri, 20 Jul 2012 09:54:11 +0800 From: Alex Shi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111229 Thunderbird/9.0 MIME-Version: 1.0 To: Rusty Russell CC: kosaki.motohiro@jp.fujitsu.com, akpm@linux-foundation.org, paul.gortmaker@windriver.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] cpumask: cpumask_scnprintf() comments correction References: <1342406154-24001-1-git-send-email-alex.shi@intel.com> <87ehocxig6.fsf@rustcorp.com.au> <5003D0E4.2060300@intel.com> In-Reply-To: <5003D0E4.2060300@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/16/2012 04:29 PM, Alex Shi wrote: > On 07/16/2012 03:40 PM, Rusty Russell wrote: > >> On Mon, 16 Jul 2012 10:35:54 +0800, Alex Shi wrote: >>> The function has no parameter @len now, so need to remove it from >>> comments to avoid kernel-doc warning: >> >> But it still does in my tree. >> >> Please push this patch via whoever changed it? >> >> Acked-by: Rusty Russell >> > > Sorry, my fault, the commit log used a wrong function name, it is cpulist_parse() > not cpumask_scnprntf. and find a new error in the comments: used a incorrect > function name: cpulist_parse_user(), the correct one is cpulist_parse(). > Fix it in updated patch. > > Both errors appear in Rusty's commit 29c0177e6a4. Rusty. The error still exist on upstream tree. Would you like to pick this fix? > > === > > From db20433a0b321f7b4edfc57f66e816d7bec81b14 Mon Sep 17 00:00:00 2001 > From: Alex Shi > Date: Mon, 16 Jul 2012 10:25:06 +0800 > Subject: [PATCH] cpumask: cpulist_parse() comments correction > > The function has no parameter @len, so need to remove it from > comments to avoid kernel-doc warning: > > alexs@debian:~/linux-next$ scripts/kernel-doc -man > include/linux/cpumask.h | split-man.pl /tmp/man > .... > Warning(include/linux/cpumask.h:602): Excess function parameter 'len' > description in 'cpulist_parse' > > and correct the function name in comments to cpulist_parse. > > Signed-off-by: Alex Shi > --- > include/linux/cpumask.h | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h > index 8bf1c27..0325602 100644 > --- a/include/linux/cpumask.h > +++ b/include/linux/cpumask.h > @@ -591,9 +591,8 @@ static inline int cpulist_scnprintf(char *buf, int len, > } > > /** > - * cpulist_parse_user - extract a cpumask from a user string of ranges > + * cpulist_parse - extract a cpumask from a user string of ranges > * @buf: the buffer to extract from > - * @len: the length of the buffer > * @dstp: the cpumask to set. > * > * Returns -errno, or 0 for success.